You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@flink.apache.org by GitBox <gi...@apache.org> on 2022/01/26 06:43:31 UTC
[GitHub] [flink] ruanhang1993 opened a new pull request #18513: [FLINK-25753][tests] Fix KafkaTableITCase.testStartFromGroupOffsetsLatest
ruanhang1993 opened a new pull request #18513:
URL: https://github.com/apache/flink/pull/18513
## What is the purpose of the change
This pull request fix the test `KafkaTableITCase.testStartFromGroupOffsetsLatest`.
## Brief change log
- Add some sleep time before adding new data, make sure the reading latest offsets operation happen before it
## Verifying this change
This change is already covered by existing tests.
## Does this pull request potentially affect one of the following parts:
- Dependencies (does it add or upgrade a dependency): no
- The public API, i.e., is any changed class annotated with `@Public(Evolving)`: no
- The serializers: no
- The runtime per-record code paths (performance sensitive): no
- Anything that affects deployment or recovery: JobManager (and its components), Checkpointing, Kubernetes/Yarn, ZooKeeper: no
- The S3 file system connector: no
## Documentation
- Does this pull request introduce a new feature? no
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #18513: [FLINK-25753][tests] Fix KafkaTableITCase.testStartFromGroupOffsetsLatest
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #18513:
URL: https://github.com/apache/flink/pull/18513#issuecomment-1021915660
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "38ad98b2e10ec448d765d59c0e7c23a61f1050a3",
"status" : "PENDING",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=30202",
"triggerID" : "38ad98b2e10ec448d765d59c0e7c23a61f1050a3",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 38ad98b2e10ec448d765d59c0e7c23a61f1050a3 Azure: [PENDING](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=30202)
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] ruanhang1993 commented on a change in pull request #18513: [FLINK-25753][tests] Fix KafkaTableITCase.testStartFromGroupOffsetsLatest
Posted by GitBox <gi...@apache.org>.
ruanhang1993 commented on a change in pull request #18513:
URL: https://github.com/apache/flink/pull/18513#discussion_r794231443
##########
File path: flink-connectors/flink-connector-kafka/src/test/java/org/apache/flink/streaming/connectors/kafka/table/KafkaTableITCase.java
##########
@@ -852,6 +852,7 @@ public void testStartFromGroupOffsetsNone() {
+ " (2, 6),\n"
+ " (2, 7),\n"
+ " (2, 8)\n";
+ Thread.sleep(2000);
Review comment:
fix it.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #18513: [FLINK-25753][tests] Fix KafkaTableITCase.testStartFromGroupOffsetsLatest
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #18513:
URL: https://github.com/apache/flink/pull/18513#issuecomment-1021915660
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "38ad98b2e10ec448d765d59c0e7c23a61f1050a3",
"status" : "SUCCESS",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=30202",
"triggerID" : "38ad98b2e10ec448d765d59c0e7c23a61f1050a3",
"triggerType" : "PUSH"
}, {
"hash" : "9a73f9fb50a80057c8d03a55d78ec65d46a7e804",
"status" : "UNKNOWN",
"url" : "TBD",
"triggerID" : "9a73f9fb50a80057c8d03a55d78ec65d46a7e804",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 38ad98b2e10ec448d765d59c0e7c23a61f1050a3 Azure: [SUCCESS](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=30202)
* 9a73f9fb50a80057c8d03a55d78ec65d46a7e804 UNKNOWN
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot commented on pull request #18513: [FLINK-25753][tests] Fix KafkaTableITCase.testStartFromGroupOffsetsLatest
Posted by GitBox <gi...@apache.org>.
flinkbot commented on pull request #18513:
URL: https://github.com/apache/flink/pull/18513#issuecomment-1021915660
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "38ad98b2e10ec448d765d59c0e7c23a61f1050a3",
"status" : "UNKNOWN",
"url" : "TBD",
"triggerID" : "38ad98b2e10ec448d765d59c0e7c23a61f1050a3",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 38ad98b2e10ec448d765d59c0e7c23a61f1050a3 UNKNOWN
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #18513: [FLINK-25753][tests] Fix KafkaTableITCase.testStartFromGroupOffsetsLatest
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #18513:
URL: https://github.com/apache/flink/pull/18513#issuecomment-1021915660
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "38ad98b2e10ec448d765d59c0e7c23a61f1050a3",
"status" : "SUCCESS",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=30202",
"triggerID" : "38ad98b2e10ec448d765d59c0e7c23a61f1050a3",
"triggerType" : "PUSH"
}, {
"hash" : "9a73f9fb50a80057c8d03a55d78ec65d46a7e804",
"status" : "PENDING",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=30354",
"triggerID" : "9a73f9fb50a80057c8d03a55d78ec65d46a7e804",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 38ad98b2e10ec448d765d59c0e7c23a61f1050a3 Azure: [SUCCESS](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=30202)
* 9a73f9fb50a80057c8d03a55d78ec65d46a7e804 Azure: [PENDING](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=30354)
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot commented on pull request #18513: [FLINK-25753][tests] Fix KafkaTableITCase.testStartFromGroupOffsetsLatest
Posted by GitBox <gi...@apache.org>.
flinkbot commented on pull request #18513:
URL: https://github.com/apache/flink/pull/18513#issuecomment-1021915163
Thanks a lot for your contribution to the Apache Flink project. I'm the @flinkbot. I help the community
to review your pull request. We will use this comment to track the progress of the review.
## Automated Checks
Last check on commit 38ad98b2e10ec448d765d59c0e7c23a61f1050a3 (Wed Jan 26 06:47:27 UTC 2022)
**Warnings:**
* No documentation files were touched! Remember to keep the Flink docs up to date!
<sub>Mention the bot in a comment to re-run the automated checks.</sub>
## Review Progress
* ❓ 1. The [description] looks good.
* ❓ 2. There is [consensus] that the contribution should go into to Flink.
* ❓ 3. Needs [attention] from.
* ❓ 4. The change fits into the overall [architecture].
* ❓ 5. Overall code [quality] is good.
Please see the [Pull Request Review Guide](https://flink.apache.org/contributing/reviewing-prs.html) for a full explanation of the review process.<details>
The Bot is tracking the review progress through labels. Labels are applied according to the order of the review items. For consensus, approval by a Flink committer of PMC member is required <summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot approve description` to approve one or more aspects (aspects: `description`, `consensus`, `architecture` and `quality`)
- `@flinkbot approve all` to approve all aspects
- `@flinkbot approve-until architecture` to approve everything until `architecture`
- `@flinkbot attention @username1 [@username2 ..]` to require somebody's attention
- `@flinkbot disapprove architecture` to remove an approval you gave earlier
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #18513: [FLINK-25753][tests] Fix KafkaTableITCase.testStartFromGroupOffsetsLatest
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #18513:
URL: https://github.com/apache/flink/pull/18513#issuecomment-1021915660
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "38ad98b2e10ec448d765d59c0e7c23a61f1050a3",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=30202",
"triggerID" : "38ad98b2e10ec448d765d59c0e7c23a61f1050a3",
"triggerType" : "PUSH"
}, {
"hash" : "9a73f9fb50a80057c8d03a55d78ec65d46a7e804",
"status" : "SUCCESS",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=30354",
"triggerID" : "9a73f9fb50a80057c8d03a55d78ec65d46a7e804",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 9a73f9fb50a80057c8d03a55d78ec65d46a7e804 Azure: [SUCCESS](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=30354)
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] SteNicholas commented on a change in pull request #18513: [FLINK-25753][tests] Fix KafkaTableITCase.testStartFromGroupOffsetsLatest
Posted by GitBox <gi...@apache.org>.
SteNicholas commented on a change in pull request #18513:
URL: https://github.com/apache/flink/pull/18513#discussion_r792381026
##########
File path: flink-connectors/flink-connector-kafka/src/test/java/org/apache/flink/streaming/connectors/kafka/table/KafkaTableITCase.java
##########
@@ -852,6 +852,7 @@ public void testStartFromGroupOffsetsNone() {
+ " (2, 6),\n"
+ " (2, 7),\n"
+ " (2, 8)\n";
+ Thread.sleep(2000);
Review comment:
@ruanhang1993, why does this sleep 2000 millseconds? I don't think this is the fundamental solution to the problem.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] fapaul merged pull request #18513: [FLINK-25753][tests] Fix KafkaTableITCase.testStartFromGroupOffsetsLatest
Posted by GitBox <gi...@apache.org>.
fapaul merged pull request #18513:
URL: https://github.com/apache/flink/pull/18513
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] SteNicholas commented on a change in pull request #18513: [FLINK-25753][tests] Fix KafkaTableITCase.testStartFromGroupOffsetsLatest
Posted by GitBox <gi...@apache.org>.
SteNicholas commented on a change in pull request #18513:
URL: https://github.com/apache/flink/pull/18513#discussion_r792381026
##########
File path: flink-connectors/flink-connector-kafka/src/test/java/org/apache/flink/streaming/connectors/kafka/table/KafkaTableITCase.java
##########
@@ -852,6 +852,7 @@ public void testStartFromGroupOffsetsNone() {
+ " (2, 6),\n"
+ " (2, 7),\n"
+ " (2, 8)\n";
+ Thread.sleep(2000);
Review comment:
Why does this sleep 2000 millseconds? I don't think this is the fundamental solution to the problem.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #18513: [FLINK-25753][tests] Fix KafkaTableITCase.testStartFromGroupOffsetsLatest
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #18513:
URL: https://github.com/apache/flink/pull/18513#issuecomment-1021915660
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "38ad98b2e10ec448d765d59c0e7c23a61f1050a3",
"status" : "SUCCESS",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=30202",
"triggerID" : "38ad98b2e10ec448d765d59c0e7c23a61f1050a3",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 38ad98b2e10ec448d765d59c0e7c23a61f1050a3 Azure: [SUCCESS](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=30202)
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org