[GitHub] [iceberg] rdblue edited a comment on pull request #2680: Core: Add RocksDBStructLikeMap

[GitBox <gi...@apache.org>]

rdblue edited a comment on pull request #2680:
URL: https://github.com/apache/iceberg/pull/2680#issuecomment-929338288


   @openinx, thanks for working on this. The approach of adding a RocksDBStructLikeMap seems good to me. There are a couple of issues that I think we need to work out before getting into details though:
   1. How do we avoid adding new serialization, or how do we document it and avoid exposing it to library consumers?
   2. How do we want to configure the map used? Passing properties everywhere requires a ton of changes and is really disruptive
   3. How would this fit in with the writer refactor that @aokolnychyi has been working on?
   
   I think the first thing to do is to get a PR with just the StructLikeMap implementation in and then we can work on integrating this with the rest of the code.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org