[jira] [Commented] (HIVE-8916) Handle user@domain username under LDAP authentication

["Szehon Ho (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/HIVE-8916?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14218529#comment-14218529 ] 

Szehon Ho commented on HIVE-8916:
---------------------------------

Thanks for this fix!  Left a comment on the review-board.

> Handle user@domain username under LDAP authentication
> -----------------------------------------------------
>
>                 Key: HIVE-8916
>                 URL: https://issues.apache.org/jira/browse/HIVE-8916
>             Project: Hive
>          Issue Type: Bug
>          Components: Authentication
>            Reporter: Mohit Sabharwal
>            Assignee: Mohit Sabharwal
>         Attachments: HIVE-8916.patch
>
>
> If LDAP is configured with multiple domains for authentication, users can be in different domains.
> Currently, LdapAuthenticationProviderImpl blindly appends the domain configured "hive.server2.authentication.ldap.Domain" to the username, which limits user to that domain. However, under multi-domain authentication, the username may already include the domain (ex:  user@domain.foo.com). We should not append a domain if one is already present.
> Also, if username already includes the domain, rest of Hive and authorization providers still expects the "short name" ("user" and not "user@domain.foo.com") for looking up privilege rules, etc.  As such, any domain info in the username should be stripped off.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)