You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@singa.apache.org by GitBox <gi...@apache.org> on 2020/09/05 01:40:49 UTC

[GitHub] [singa] moazreyad opened a new pull request #788: code coverage for python

moazreyad opened a new pull request #788:
URL: https://github.com/apache/singa/pull/788


   Run python test from the conda build and merge the python coverage report with the C++ coverage report. The python coverage ignores the proto directory.


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [singa] codecov[bot] edited a comment on pull request #788: code coverage for python

Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #788:
URL: https://github.com/apache/singa/pull/788#issuecomment-687525335


   # [Codecov](https://codecov.io/gh/apache/singa/pull/788?src=pr&el=h1) Report
   > Merging [#788](https://codecov.io/gh/apache/singa/pull/788?src=pr&el=desc) into [dev](https://codecov.io/gh/apache/singa/commit/7586a3b14ef9a4d122435d624d8e6ae7f99c6e89?el=desc) will **increase** coverage by `4.97%`.
   > The diff coverage is `n/a`.
   
   [![Impacted file tree graph](https://codecov.io/gh/apache/singa/pull/788/graphs/tree.svg?width=650&height=150&src=pr&token=raMbqTl5Tl)](https://codecov.io/gh/apache/singa/pull/788?src=pr&el=tree)
   
   ```diff
   @@            Coverage Diff             @@
   ##              dev     #788      +/-   ##
   ==========================================
   + Coverage   65.08%   70.05%   +4.97%     
   ==========================================
     Files          86      100      +14     
     Lines        4786    11556    +6770     
   ==========================================
   + Hits         3115     8096    +4981     
   - Misses       1671     3460    +1789     
   ```
   
   | Flag | Coverage Δ | |
   |---|---|---|
   | #singa-cpp | `65.08% <ø> (?)` | |
   | #singa-python | `73.57% <ø> (?)` | |
   
   Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags#carryforward-flags-in-the-pull-request-comment) to find out more.
   
   | [Impacted Files](https://codecov.io/gh/apache/singa/pull/788?src=pr&el=tree) | Coverage Δ | |
   |---|---|---|
   | [autograd.py](https://codecov.io/gh/apache/singa/pull/788/diff?src=pr&el=tree#diff-YXV0b2dyYWQucHk=) | `89.99% <0.00%> (ø)` | |
   | [utils.py](https://codecov.io/gh/apache/singa/pull/788/diff?src=pr&el=tree#diff-dXRpbHMucHk=) | `65.78% <0.00%> (ø)` | |
   | [tensor.py](https://codecov.io/gh/apache/singa/pull/788/diff?src=pr&el=tree#diff-dGVuc29yLnB5) | `75.19% <0.00%> (ø)` | |
   | [device.py](https://codecov.io/gh/apache/singa/pull/788/diff?src=pr&el=tree#diff-ZGV2aWNlLnB5) | `43.18% <0.00%> (ø)` | |
   | [sonnx.py](https://codecov.io/gh/apache/singa/pull/788/diff?src=pr&el=tree#diff-c29ubngucHk=) | `91.94% <0.00%> (ø)` | |
   | [initializer.py](https://codecov.io/gh/apache/singa/pull/788/diff?src=pr&el=tree#diff-aW5pdGlhbGl6ZXIucHk=) | `49.39% <0.00%> (ø)` | |
   | [layer.py](https://codecov.io/gh/apache/singa/pull/788/diff?src=pr&el=tree#diff-bGF5ZXIucHk=) | `80.97% <0.00%> (ø)` | |
   | [model.py](https://codecov.io/gh/apache/singa/pull/788/diff?src=pr&el=tree#diff-bW9kZWwucHk=) | `89.65% <0.00%> (ø)` | |
   | [\_\_init\_\_.py](https://codecov.io/gh/apache/singa/pull/788/diff?src=pr&el=tree#diff-X19pbml0X18ucHk=) | `100.00% <0.00%> (ø)` | |
   | [image\_tool.py](https://codecov.io/gh/apache/singa/pull/788/diff?src=pr&el=tree#diff-aW1hZ2VfdG9vbC5weQ==) | `0.00% <0.00%> (ø)` | |
   | ... and [4 more](https://codecov.io/gh/apache/singa/pull/788/diff?src=pr&el=tree-more) | |
   
   ------
   
   [Continue to review full report at Codecov](https://codecov.io/gh/apache/singa/pull/788?src=pr&el=continue).
   > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
   > `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
   > Powered by [Codecov](https://codecov.io/gh/apache/singa/pull/788?src=pr&el=footer). Last update [7586a3b...18c2af6](https://codecov.io/gh/apache/singa/pull/788?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [singa] nudles merged pull request #788: code coverage for python

Posted by GitBox <gi...@apache.org>.
nudles merged pull request #788:
URL: https://github.com/apache/singa/pull/788


   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [singa] codecov[bot] edited a comment on pull request #788: code coverage for python

Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #788:
URL: https://github.com/apache/singa/pull/788#issuecomment-687525335


   # [Codecov](https://codecov.io/gh/apache/singa/pull/788?src=pr&el=h1) Report
   > Merging [#788](https://codecov.io/gh/apache/singa/pull/788?src=pr&el=desc) into [dev](https://codecov.io/gh/apache/singa/commit/7586a3b14ef9a4d122435d624d8e6ae7f99c6e89?el=desc) will **increase** coverage by `4.97%`.
   > The diff coverage is `n/a`.
   
   [![Impacted file tree graph](https://codecov.io/gh/apache/singa/pull/788/graphs/tree.svg?width=650&height=150&src=pr&token=raMbqTl5Tl)](https://codecov.io/gh/apache/singa/pull/788?src=pr&el=tree)
   
   ```diff
   @@            Coverage Diff             @@
   ##              dev     #788      +/-   ##
   ==========================================
   + Coverage   65.08%   70.05%   +4.97%     
   ==========================================
     Files          86      100      +14     
     Lines        4786    11556    +6770     
   ==========================================
   + Hits         3115     8096    +4981     
   - Misses       1671     3460    +1789     
   ```
   
   | Flag | Coverage Δ | |
   |---|---|---|
   | #singa-cpp | `65.08% <ø> (?)` | |
   | #singa-python | `73.57% <ø> (?)` | |
   
   Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags#carryforward-flags-in-the-pull-request-comment) to find out more.
   
   | [Impacted Files](https://codecov.io/gh/apache/singa/pull/788?src=pr&el=tree) | Coverage Δ | |
   |---|---|---|
   | [sonnx.py](https://codecov.io/gh/apache/singa/pull/788/diff?src=pr&el=tree#diff-c29ubngucHk=) | `91.94% <0.00%> (ø)` | |
   | [data.py](https://codecov.io/gh/apache/singa/pull/788/diff?src=pr&el=tree#diff-ZGF0YS5weQ==) | `0.00% <0.00%> (ø)` | |
   | [autograd.py](https://codecov.io/gh/apache/singa/pull/788/diff?src=pr&el=tree#diff-YXV0b2dyYWQucHk=) | `89.99% <0.00%> (ø)` | |
   | [initializer.py](https://codecov.io/gh/apache/singa/pull/788/diff?src=pr&el=tree#diff-aW5pdGlhbGl6ZXIucHk=) | `49.39% <0.00%> (ø)` | |
   | [\_\_init\_\_.py](https://codecov.io/gh/apache/singa/pull/788/diff?src=pr&el=tree#diff-X19pbml0X18ucHk=) | `100.00% <0.00%> (ø)` | |
   | [snapshot.py](https://codecov.io/gh/apache/singa/pull/788/diff?src=pr&el=tree#diff-c25hcHNob3QucHk=) | `0.00% <0.00%> (ø)` | |
   | [singa\_wrap.py](https://codecov.io/gh/apache/singa/pull/788/diff?src=pr&el=tree#diff-c2luZ2Ffd3JhcC5weQ==) | `66.55% <0.00%> (ø)` | |
   | [opt.py](https://codecov.io/gh/apache/singa/pull/788/diff?src=pr&el=tree#diff-b3B0LnB5) | `48.31% <0.00%> (ø)` | |
   | [device.py](https://codecov.io/gh/apache/singa/pull/788/diff?src=pr&el=tree#diff-ZGV2aWNlLnB5) | `43.18% <0.00%> (ø)` | |
   | [model.py](https://codecov.io/gh/apache/singa/pull/788/diff?src=pr&el=tree#diff-bW9kZWwucHk=) | `89.65% <0.00%> (ø)` | |
   | ... and [4 more](https://codecov.io/gh/apache/singa/pull/788/diff?src=pr&el=tree-more) | |
   
   ------
   
   [Continue to review full report at Codecov](https://codecov.io/gh/apache/singa/pull/788?src=pr&el=continue).
   > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
   > `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
   > Powered by [Codecov](https://codecov.io/gh/apache/singa/pull/788?src=pr&el=footer). Last update [7586a3b...18c2af6](https://codecov.io/gh/apache/singa/pull/788?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [singa] chrishkchris removed a comment on pull request #788: code coverage for python

Posted by GitBox <gi...@apache.org>.
chrishkchris removed a comment on pull request #788:
URL: https://github.com/apache/singa/pull/788#issuecomment-687790219


   how to pass the code coverage test? why sometime in a PR the codecov test fails?


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [singa] chrishkchris commented on pull request #788: code coverage for python

Posted by GitBox <gi...@apache.org>.
chrishkchris commented on pull request #788:
URL: https://github.com/apache/singa/pull/788#issuecomment-687790219


   how to pass the code coverage test? why sometime in a PR the codecov test fails?


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [singa] codecov[bot] commented on pull request #788: code coverage for python

Posted by GitBox <gi...@apache.org>.
codecov[bot] commented on pull request #788:
URL: https://github.com/apache/singa/pull/788#issuecomment-687525335


   # [Codecov](https://codecov.io/gh/apache/singa/pull/788?src=pr&el=h1) Report
   > Merging [#788](https://codecov.io/gh/apache/singa/pull/788?src=pr&el=desc) into [dev](https://codecov.io/gh/apache/singa/commit/7586a3b14ef9a4d122435d624d8e6ae7f99c6e89?el=desc) will **increase** coverage by `4.97%`.
   > The diff coverage is `n/a`.
   
   [![Impacted file tree graph](https://codecov.io/gh/apache/singa/pull/788/graphs/tree.svg?width=650&height=150&src=pr&token=raMbqTl5Tl)](https://codecov.io/gh/apache/singa/pull/788?src=pr&el=tree)
   
   ```diff
   @@            Coverage Diff             @@
   ##              dev     #788      +/-   ##
   ==========================================
   + Coverage   65.08%   70.05%   +4.97%     
   ==========================================
     Files          86      100      +14     
     Lines        4786    11556    +6770     
   ==========================================
   + Hits         3115     8096    +4981     
   - Misses       1671     3460    +1789     
   ```
   
   | Flag | Coverage Δ | |
   |---|---|---|
   | #singa-cpp | `65.08% <ø> (?)` | |
   | #singa-python | `73.57% <ø> (?)` | |
   
   Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags#carryforward-flags-in-the-pull-request-comment) to find out more.
   
   | [Impacted Files](https://codecov.io/gh/apache/singa/pull/788?src=pr&el=tree) | Coverage Δ | |
   |---|---|---|
   | [device.py](https://codecov.io/gh/apache/singa/pull/788/diff?src=pr&el=tree#diff-ZGV2aWNlLnB5) | `43.18% <0.00%> (ø)` | |
   | [singa\_wrap.py](https://codecov.io/gh/apache/singa/pull/788/diff?src=pr&el=tree#diff-c2luZ2Ffd3JhcC5weQ==) | `66.55% <0.00%> (ø)` | |
   | [sonnx.py](https://codecov.io/gh/apache/singa/pull/788/diff?src=pr&el=tree#diff-c29ubngucHk=) | `91.94% <0.00%> (ø)` | |
   | [opt.py](https://codecov.io/gh/apache/singa/pull/788/diff?src=pr&el=tree#diff-b3B0LnB5) | `48.31% <0.00%> (ø)` | |
   | [\_\_init\_\_.py](https://codecov.io/gh/apache/singa/pull/788/diff?src=pr&el=tree#diff-X19pbml0X18ucHk=) | `100.00% <0.00%> (ø)` | |
   | [utils.py](https://codecov.io/gh/apache/singa/pull/788/diff?src=pr&el=tree#diff-dXRpbHMucHk=) | `65.78% <0.00%> (ø)` | |
   | [model.py](https://codecov.io/gh/apache/singa/pull/788/diff?src=pr&el=tree#diff-bW9kZWwucHk=) | `89.65% <0.00%> (ø)` | |
   | [snapshot.py](https://codecov.io/gh/apache/singa/pull/788/diff?src=pr&el=tree#diff-c25hcHNob3QucHk=) | `0.00% <0.00%> (ø)` | |
   | [autograd.py](https://codecov.io/gh/apache/singa/pull/788/diff?src=pr&el=tree#diff-YXV0b2dyYWQucHk=) | `89.99% <0.00%> (ø)` | |
   | [data.py](https://codecov.io/gh/apache/singa/pull/788/diff?src=pr&el=tree#diff-ZGF0YS5weQ==) | `0.00% <0.00%> (ø)` | |
   | ... and [4 more](https://codecov.io/gh/apache/singa/pull/788/diff?src=pr&el=tree-more) | |
   
   ------
   
   [Continue to review full report at Codecov](https://codecov.io/gh/apache/singa/pull/788?src=pr&el=continue).
   > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
   > `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
   > Powered by [Codecov](https://codecov.io/gh/apache/singa/pull/788?src=pr&el=footer). Last update [7586a3b...18c2af6](https://codecov.io/gh/apache/singa/pull/788?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org