You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@skywalking.apache.org by GitBox <gi...@apache.org> on 2020/09/07 01:07:21 UTC
[GitHub] [skywalking-agent-test-tool] EvanLjp opened a new pull request #23: fix the field named isError is no mapping when serialization
EvanLjp opened a new pull request #23:
URL: https://github.com/apache/skywalking-agent-test-tool/pull/23
fix the field named isError is no mapping when serialization
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking-agent-test-tool] EvanLjp commented on a change in pull request #23: fix the field named isError is no mapping when serialization
Posted by GitBox <gi...@apache.org>.
EvanLjp commented on a change in pull request #23:
URL: https://github.com/apache/skywalking-agent-test-tool/pull/23#discussion_r484141895
##########
File path: validator/src/main/java/org/apache/skywalking/plugin/test/agent/tool/validator/entity/SegmentForRead.java
##########
@@ -176,8 +176,8 @@ public void setComponentName(String componentName) {
this.componentName = componentName;
}
- public void setError(String error) {
- isError = error;
+ public void setIsError(String isError) {
+ this.isError = isError;
Review comment:
Yesterday, I found the error status is not a valid option. After I run the unit test, the status is like the following:
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking-agent-test-tool] wu-sheng merged pull request #23: fix the field named isError is no mapping when serialization
Posted by GitBox <gi...@apache.org>.
wu-sheng merged pull request #23:
URL: https://github.com/apache/skywalking-agent-test-tool/pull/23
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking-agent-test-tool] wu-sheng commented on a change in pull request #23: fix the field named isError is no mapping when serialization
Posted by GitBox <gi...@apache.org>.
wu-sheng commented on a change in pull request #23:
URL: https://github.com/apache/skywalking-agent-test-tool/pull/23#discussion_r484140264
##########
File path: validator/src/main/java/org/apache/skywalking/plugin/test/agent/tool/validator/entity/SegmentForRead.java
##########
@@ -176,8 +176,8 @@ public void setComponentName(String componentName) {
this.componentName = componentName;
}
- public void setError(String error) {
- isError = error;
+ public void setIsError(String isError) {
+ this.isError = isError;
Review comment:
Do you mean current checking not working? IsError seems a right name from Java style.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org