You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@skywalking.apache.org by GitBox <gi...@apache.org> on 2020/05/14 00:44:58 UTC

[GitHub] [skywalking] codecov-io edited a comment on pull request #4783: [WIP] Ingest prometheus metrics through meter system

codecov-io edited a comment on pull request #4783:
URL: https://github.com/apache/skywalking/pull/4783#issuecomment-628145491


   # [Codecov](https://codecov.io/gh/apache/skywalking/pull/4783?src=pr&el=h1) Report
   > Merging [#4783](https://codecov.io/gh/apache/skywalking/pull/4783?src=pr&el=desc) into [master](https://codecov.io/gh/apache/skywalking/commit/cd41b223b89e18ecb734852d86b42f0e386cac5c&el=desc) will **decrease** coverage by `1.39%`.
   > The diff coverage is `2.78%`.
   
   [![Impacted file tree graph](https://codecov.io/gh/apache/skywalking/pull/4783/graphs/tree.svg?width=650&height=150&src=pr&token=qrILxY5yA8)](https://codecov.io/gh/apache/skywalking/pull/4783?src=pr&el=tree)
   
   ```diff
   @@             Coverage Diff              @@
   ##             master    #4783      +/-   ##
   ============================================
   - Coverage     51.11%   49.72%   -1.40%     
   - Complexity     2652     2693      +41     
   ============================================
     Files          1306      752     -554     
     Lines         28454    18491    -9963     
     Branches       3106     1798    -1308     
   ============================================
   - Hits          14544     9194    -5350     
   + Misses        13246     8562    -4684     
   - Partials        664      735      +71     
   ```
   
   
   | [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/4783?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
   |---|---|---|---|
   | [...king/oap/server/core/alarm/provider/AlarmRule.java](https://codecov.io/gh/apache/skywalking/pull/4783/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItYWxhcm0tcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvY29yZS9hbGFybS9wcm92aWRlci9BbGFybVJ1bGUuamF2YQ==) | `9.09% <0.00%> (-0.91%)` | `1.00 <0.00> (ø)` | |
   | [.../server/core/meter/prometheus/metrics/Counter.java](https://codecov.io/gh/apache/skywalking/pull/4783/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvbWV0ZXIvcHJvbWV0aGV1cy9tZXRyaWNzL0NvdW50ZXIuamF2YQ==) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
   | [...ap/server/core/meter/prometheus/metrics/Gauge.java](https://codecov.io/gh/apache/skywalking/pull/4783/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvbWV0ZXIvcHJvbWV0aGV1cy9tZXRyaWNzL0dhdWdlLmphdmE=) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
   | [...erver/core/meter/prometheus/metrics/Histogram.java](https://codecov.io/gh/apache/skywalking/pull/4783/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvbWV0ZXIvcHJvbWV0aGV1cy9tZXRyaWNzL0hpc3RvZ3JhbS5qYXZh) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
   | [...er/core/meter/prometheus/metrics/MetricFamily.java](https://codecov.io/gh/apache/skywalking/pull/4783/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvbWV0ZXIvcHJvbWV0aGV1cy9tZXRyaWNzL01ldHJpY0ZhbWlseS5qYXZh) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
   | [...rver/core/meter/prometheus/metrics/MetricType.java](https://codecov.io/gh/apache/skywalking/pull/4783/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvbWV0ZXIvcHJvbWV0aGV1cy9tZXRyaWNzL01ldHJpY1R5cGUuamF2YQ==) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
   | [.../server/core/meter/prometheus/metrics/Summary.java](https://codecov.io/gh/apache/skywalking/pull/4783/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvbWV0ZXIvcHJvbWV0aGV1cy9tZXRyaWNzL1N1bW1hcnkuamF2YQ==) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
   | [...p/server/core/meter/prometheus/parser/Context.java](https://codecov.io/gh/apache/skywalking/pull/4783/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvbWV0ZXIvcHJvbWV0aGV1cy9wYXJzZXIvQ29udGV4dC5qYXZh) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
   | [...erver/core/meter/prometheus/parser/TextParser.java](https://codecov.io/gh/apache/skywalking/pull/4783/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvbWV0ZXIvcHJvbWV0aGV1cy9wYXJzZXIvVGV4dFBhcnNlci5qYXZh) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
   | [...r/core/meter/prometheus/parser/sample/Context.java](https://codecov.io/gh/apache/skywalking/pull/4783/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvbWV0ZXIvcHJvbWV0aGV1cy9wYXJzZXIvc2FtcGxlL0NvbnRleHQuamF2YQ==) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
   | ... and [898 more](https://codecov.io/gh/apache/skywalking/pull/4783/diff?src=pr&el=tree-more) | |
   
   ------
   
   [Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/4783?src=pr&el=continue).
   > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
   > `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
   > Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/4783?src=pr&el=footer). Last update [cd41b22...513bc1d](https://codecov.io/gh/apache/skywalking/pull/4783?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org