You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@pig.apache.org by Richard Ding <rd...@yahoo-inc.com> on 2011/02/11 00:33:13 UTC

Review Request: Add macro invoking macro in Pig Latin

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/419/
-----------------------------------------------------------

Review request for pig and Julien Le Dem.


Summary
-------

Macros will be allowed to inline other macros. However, forward declarations will not be supported. Note that macro inlining is not a complete replacement for function calls, as it does not support recursive calls.


This addresses bug PIG-1793.
    https://issues.apache.org/jira/browse/PIG-1793


Diffs
-----

  http://svn.apache.org/repos/asf/pig/trunk/build.xml 1069543 
  http://svn.apache.org/repos/asf/pig/trunk/src/org/apache/pig/parser/AliasMasker.g 1069543 
  http://svn.apache.org/repos/asf/pig/trunk/src/org/apache/pig/parser/MacroExpansion.g 1069543 
  http://svn.apache.org/repos/asf/pig/trunk/src/org/apache/pig/parser/MacroRecursion.g PRE-CREATION 
  http://svn.apache.org/repos/asf/pig/trunk/src/org/apache/pig/parser/PigMacro.java 1069543 
  http://svn.apache.org/repos/asf/pig/trunk/test/org/apache/pig/test/TestMacroExpansion.java 1069543 

Diff: https://reviews.apache.org/r/419/diff


Testing
-------


Thanks,

Richard

Re: Review Request: Add macro invoking macro in Pig Latin

Posted by Julien Le Dem <ju...@ledem.net>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/419/#review222
-----------------------------------------------------------

Ship it!


Nice.
I'm wondering if there could be only one grammar definition for the macro expansion, but it's not a big deal and I don't have time to look into it.
Ship it!


http://svn.apache.org/repos/asf/pig/trunk/src/org/apache/pig/parser/PigMacro.java
<https://reviews.apache.org/r/419/#comment456>

    why do we need this special case (\\\\) here ?



http://svn.apache.org/repos/asf/pig/trunk/test/org/apache/pig/test/TestMacroExpansion.java
<https://reviews.apache.org/r/419/#comment457>

    cool!


- Julien


On 2011-02-10 15:33:13, Richard Ding wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/419/
> -----------------------------------------------------------
> 
> (Updated 2011-02-10 15:33:13)
> 
> 
> Review request for pig and Julien Le Dem.
> 
> 
> Summary
> -------
> 
> Macros will be allowed to inline other macros. However, forward declarations will not be supported. Note that macro inlining is not a complete replacement for function calls, as it does not support recursive calls.
> 
> 
> This addresses bug PIG-1793.
>     https://issues.apache.org/jira/browse/PIG-1793
> 
> 
> Diffs
> -----
> 
>   http://svn.apache.org/repos/asf/pig/trunk/build.xml 1069543 
>   http://svn.apache.org/repos/asf/pig/trunk/src/org/apache/pig/parser/AliasMasker.g 1069543 
>   http://svn.apache.org/repos/asf/pig/trunk/src/org/apache/pig/parser/MacroExpansion.g 1069543 
>   http://svn.apache.org/repos/asf/pig/trunk/src/org/apache/pig/parser/MacroRecursion.g PRE-CREATION 
>   http://svn.apache.org/repos/asf/pig/trunk/src/org/apache/pig/parser/PigMacro.java 1069543 
>   http://svn.apache.org/repos/asf/pig/trunk/test/org/apache/pig/test/TestMacroExpansion.java 1069543 
> 
> Diff: https://reviews.apache.org/r/419/diff
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Richard
> 
>