You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@mesos.apache.org by Benno Evers <be...@mesosphere.com> on 2019/03/15 01:53:33 UTC
Review Request 70211: PoC: Prefix filtering for the metrics endpoint.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/70211/
-----------------------------------------------------------
Review request for mesos.
Repository: mesos
Description
-------
This patch adds the ability to dynamically select a subset of
metrics. This is done by accessing e.g.
/metrics/master/messages
to retrieve all metrics whose name starts with '/master/messages'.
Diffs
-----
3rdparty/libprocess/include/process/metrics/metrics.hpp 75711edbaf46797e5eb54ba720ea11cf3de81522
3rdparty/libprocess/src/metrics/metrics.cpp 623d44adbe838f995ddbe89ee26f5bcc9c600be5
Diff: https://reviews.apache.org/r/70211/diff/1/
Testing
-------
Thanks,
Benno Evers
Re: Review Request 70211: PoC: Prefix filtering for the metrics
endpoint.
Posted by Mesos Reviewbot <re...@mesos.apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/70211/#review213742
-----------------------------------------------------------
Bad review!
Reviews applied: []
Error:
No reviewers specified. Please find a reviewer by asking on JIRA or the mailing list.
- Mesos Reviewbot
On March 15, 2019, 1:53 a.m., Benno Evers wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/70211/
> -----------------------------------------------------------
>
> (Updated March 15, 2019, 1:53 a.m.)
>
>
> Review request for mesos.
>
>
> Repository: mesos
>
>
> Description
> -------
>
> This patch adds the ability to dynamically select a subset of
> metrics. This is done by accessing e.g.
>
> /metrics/master/messages
>
> to retrieve all metrics whose name starts with '/master/messages'.
>
>
> Diffs
> -----
>
> 3rdparty/libprocess/include/process/metrics/metrics.hpp 75711edbaf46797e5eb54ba720ea11cf3de81522
> 3rdparty/libprocess/src/metrics/metrics.cpp 623d44adbe838f995ddbe89ee26f5bcc9c600be5
>
>
> Diff: https://reviews.apache.org/r/70211/diff/1/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Benno Evers
>
>
Re: Review Request 70211: PoC: Prefix filtering for the metrics
endpoint.
Posted by Mesos Reviewbot Windows <re...@mesos.apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/70211/#review213743
-----------------------------------------------------------
FAIL: Some of the unit tests failed. Please check the relevant logs.
Reviews applied: `['70210', '70211']`
Failed command: `Start-MesosCITesting`
All the build artifacts available at: http://dcos-win.westus2.cloudapp.azure.com/artifacts/mesos-reviewbot-testing/2968/mesos-review-70211
Relevant logs:
- [mesos-tests.log](http://dcos-win.westus2.cloudapp.azure.com/artifacts/mesos-reviewbot-testing/2968/mesos-review-70211/logs/mesos-tests.log):
```
W0315 03:04:16.506247 17680 slave.cpp:3932] Ignoring shutdown framework 1ba552c5-a690-4fba-bfca-5c7ba4ec3f12-0000 because it is terminating
I0315 03:04:16.509368 18824 master.cpp:1295] Agent 1ba552c5-a690-4fba-bfca-5c7ba4ec3f12-S0 at slave(494)@192.10.1.6:57537 (windows-02.chtsmhjxogyevckjfayqqcnjda.xx.internal.cloudapp.net) disconnected
I0315 03:04:16.509368 18824 master.cpp:3330] Disconnecting agent 1ba552c5-a690-4fba-bfca-5c7ba4ec3f12-S0 at slave(494)@192.10.1.6:57537 (windows-02.chtsmhjxogyevckjfayqqcnjda.xx.internal.cloudapp.net)
I0315 03:04:16.509368 18824 master.cpp:3349] Deactivating agent 1ba552c5-a690-4fba-bfca-5c7ba4ec3f12-S0 at slave(494)@192.10.1.6:57537 (windows-02.chtsmhjxogyevckjfayqqcnjda.xx.internal.cloudapp.net)
I0315 03:04:16.509368 12320 hierarchical.cpp:390] Removed framework 1ba552c5-a690-4fba-bfca-5c7ba4ec3f12-0000
I0315 03:04:16.510242 12320 hierarchical.cpp:827] Agent 1ba552c5-a690-4fba-bfca-5c7ba4ec3f12-S0 deactivated
I0315 03:04:16.511258 18824 containerizer.cpp:2576] Destroying container b15d248c-b976-4e67-952d-4d51f94b8251 in RUNNING state
I0315 03:04:16.511258 18824 containerizer.cpp:3278] Transitioning the state of container b15d248c-b976-4e67-952d-4d51f94b8251 from RUNNING to DESTROYING
I0315 03:04:16.511258 18824 launcher.cpp:161] Asked to destroy container b15d248c-b976-4e67-952d-4d51f94b8251
W0315 03:04:16.512260 18672 process.cpp:1423] Failed to recv on socket WindowsFD::Type::SOCKET=10952 to peer '192.10.1.6:59898': I[ OK ] IsolationFlag/MemoryIsolatorTest.ROOT_MemUsage/0 (691 ms)
[----------] 1 test from IsolationFlag/MemoryIsolatorTest (707 ms total)
[----------] Global test environment tear-down
[==========] 1115 tests from 106 test cases ran. (507018 ms total)
[ PASSED ] 1114 tests.
[ FAILED ] 1 test, listed below:
[ FAILED ] DockerFetcherPluginTest.INTERNET_CURL_InvokeFetchByName
1 FAILED TEST
YOU HAVE 232 DISABLED TESTS
O failed with error code: The specified network name is no longer available.
W0315 03:04:16.512260 18672 process.cpp:838] Failed to recv on socket WindowsFD::Type::SOCKET=11092 to peer '192.10.1.6:59899': IO failed with error code: The specified network name is no longer available.
I0315 03:04:16.604290 15188 containerizer.cpp:3117] Container b15d248c-b976-4e67-952d-4d51f94b8251 has exited
I0315 03:04:16.633249 18652 master.cpp:1135] Master terminating
I0315 03:04:16.635253 18932 hierarchical.cpp:678] Removed agent 1ba552c5-a690-4fba-bfca-5c7ba4ec3f12-S0
I0315 03:04:16.974295 18672 process.cpp:927] Stopped the socket accept loop
```
- Mesos Reviewbot Windows
On March 15, 2019, 1:53 a.m., Benno Evers wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/70211/
> -----------------------------------------------------------
>
> (Updated March 15, 2019, 1:53 a.m.)
>
>
> Review request for mesos.
>
>
> Repository: mesos
>
>
> Description
> -------
>
> This patch adds the ability to dynamically select a subset of
> metrics. This is done by accessing e.g.
>
> /metrics/master/messages
>
> to retrieve all metrics whose name starts with '/master/messages'.
>
>
> Diffs
> -----
>
> 3rdparty/libprocess/include/process/metrics/metrics.hpp 75711edbaf46797e5eb54ba720ea11cf3de81522
> 3rdparty/libprocess/src/metrics/metrics.cpp 623d44adbe838f995ddbe89ee26f5bcc9c600be5
>
>
> Diff: https://reviews.apache.org/r/70211/diff/1/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Benno Evers
>
>