You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@hive.apache.org by Krishna <n_...@yahoo.com> on 2011/03/28 18:27:14 UTC
Review Request: Fixes for (a) removing redundant synchronized (b)
calculating and writing the correct record length and (c) making the layout
and the key/value classes actually sequencefile compliant
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/529/
-----------------------------------------------------------
Review request for hive and Yongqiang He.
Summary
-------
Patch for HIVE-2065
This addresses bug HIVE-2065.
https://issues.apache.org/jira/browse/HIVE-2065
Diffs
-----
build-common.xml 9f21a69
data/files/test_v6_compressed.rc PRE-CREATION
data/files/test_v6_uncompressed.rc PRE-CREATION
ql/src/java/org/apache/hadoop/hive/ql/io/RCFile.java eb5305b
ql/src/java/org/apache/hadoop/hive/ql/io/rcfile/merge/RCFileBlockMergeRecordReader.java 20d1f4e
ql/src/java/org/apache/hadoop/hive/ql/io/rcfile/merge/RCFileKeyBufferWrapper.java f7eacdc
ql/src/java/org/apache/hadoop/hive/ql/io/rcfile/merge/RCFileMergeMapper.java bb1e3c9
ql/src/test/org/apache/hadoop/hive/ql/io/TestRCFile.java 8bb6f3a
ql/src/test/results/clientpositive/alter_merge.q.out 25f36c0
ql/src/test/results/clientpositive/alter_merge_stats.q.out 243f7cc
ql/src/test/results/clientpositive/partition_wise_fileformat.q.out cee2e72
ql/src/test/results/clientpositive/partition_wise_fileformat3.q.out 067ab43
ql/src/test/results/clientpositive/sample10.q.out 50406c3
Diff: https://reviews.apache.org/r/529/diff
Testing
-------
Tests added, existing tests updated
Thanks,
Krishna
Re: Review Request: Fixes for (a) removing redundant synchronized (b)
calculating and writing the correct record length and (c) making the layout
and the key/value classes actually sequencefile compliant
Posted by Krishna <n_...@yahoo.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/529/
-----------------------------------------------------------
(Updated 2011-04-06 17:13:30.910168)
Review request for hive and Yongqiang He.
Changes
-------
Updated patch where sequence file compliance is not addressed but the other two issues are.
Summary
-------
Patch for HIVE-2065
This addresses bug HIVE-2065.
https://issues.apache.org/jira/browse/HIVE-2065
Diffs (updated)
-----
build-common.xml 9f21a69
data/files/test_v6dot0_compressed.rc PRE-CREATION
data/files/test_v6dot0_uncompressed.rc PRE-CREATION
ql/src/java/org/apache/hadoop/hive/ql/io/RCFile.java eb5305b
ql/src/java/org/apache/hadoop/hive/ql/io/rcfile/merge/RCFileBlockMergeRecordReader.java 20d1f4e
ql/src/java/org/apache/hadoop/hive/ql/io/rcfile/merge/RCFileKeyBufferWrapper.java f7eacdc
ql/src/java/org/apache/hadoop/hive/ql/io/rcfile/merge/RCFileMergeMapper.java bb1e3c9
ql/src/test/org/apache/hadoop/hive/ql/io/TestRCFile.java 8bb6f3a
ql/src/test/results/clientpositive/alter_merge.q.out 25f36c0
ql/src/test/results/clientpositive/alter_merge_stats.q.out 243f7cc
ql/src/test/results/clientpositive/partition_wise_fileformat.q.out cee2e72
ql/src/test/results/clientpositive/partition_wise_fileformat3.q.out 067ab43
ql/src/test/results/clientpositive/sample10.q.out 50406c3
Diff: https://reviews.apache.org/r/529/diff
Testing
-------
Tests added, existing tests updated
Thanks,
Krishna