You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@zookeeper.apache.org by "Thomas Dudziak (JIRA)" <ji...@apache.org> on 2009/09/26 00:26:16 UTC
[jira] Created: (ZOOKEEPER-537) The zookeeper jar includes the java
source files
The zookeeper jar includes the java source files
------------------------------------------------
Key: ZOOKEEPER-537
URL: https://issues.apache.org/jira/browse/ZOOKEEPER-537
Project: Zookeeper
Issue Type: Bug
Affects Versions: 3.2.1
Reporter: Thomas Dudziak
Fix For: 3.2.1
This is a problem if you use zookeeper as a dependency in maven because for whatever reason the maven compiler plugin will pick up the java files in the jar and compile them to the output directory. From there they will land in the generated jar file for whatever project happens to depend on zookeeper thus introducing duplicate classes (once in zookeeper.jar, once in the project's artifact).
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (ZOOKEEPER-537) The zookeeper jar includes the java
source files
Posted by "Patrick Hunt (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/ZOOKEEPER-537?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Patrick Hunt updated ZOOKEEPER-537:
-----------------------------------
Component/s: build
> The zookeeper jar includes the java source files
> ------------------------------------------------
>
> Key: ZOOKEEPER-537
> URL: https://issues.apache.org/jira/browse/ZOOKEEPER-537
> Project: Zookeeper
> Issue Type: Bug
> Components: build
> Affects Versions: 3.3.0
> Reporter: Thomas Dudziak
> Assignee: Thomas Dudziak
> Fix For: 3.3.0
>
> Attachments: build.patch, ZOOKEEPER-537.patch
>
>
> This is a problem if you use zookeeper as a dependency in maven because for whatever reason the maven compiler plugin will pick up the java files in the jar and compile them to the output directory. From there they will land in the generated jar file for whatever project happens to depend on zookeeper thus introducing duplicate classes (once in zookeeper.jar, once in the project's artifact).
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Resolved: (ZOOKEEPER-537) The zookeeper jar includes the
java source files
Posted by "Patrick Hunt (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/ZOOKEEPER-537?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Patrick Hunt resolved ZOOKEEPER-537.
------------------------------------
Resolution: Fixed
Hadoop Flags: [Reviewed]
+1 -- Awesome to see this make it in.
Thanks Thomas for helping to hammer this out!
> The zookeeper jar includes the java source files
> ------------------------------------------------
>
> Key: ZOOKEEPER-537
> URL: https://issues.apache.org/jira/browse/ZOOKEEPER-537
> Project: Zookeeper
> Issue Type: Bug
> Affects Versions: 3.3.0
> Reporter: Thomas Dudziak
> Assignee: Thomas Dudziak
> Fix For: 3.3.0
>
> Attachments: build.patch, ZOOKEEPER-537.patch
>
>
> This is a problem if you use zookeeper as a dependency in maven because for whatever reason the maven compiler plugin will pick up the java files in the jar and compile them to the output directory. From there they will land in the generated jar file for whatever project happens to depend on zookeeper thus introducing duplicate classes (once in zookeeper.jar, once in the project's artifact).
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (ZOOKEEPER-537) The zookeeper jar includes the java
source files
Posted by "Patrick Hunt (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/ZOOKEEPER-537?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Patrick Hunt updated ZOOKEEPER-537:
-----------------------------------
Assignee: Thomas Dudziak
Status: Patch Available (was: Open)
> The zookeeper jar includes the java source files
> ------------------------------------------------
>
> Key: ZOOKEEPER-537
> URL: https://issues.apache.org/jira/browse/ZOOKEEPER-537
> Project: Zookeeper
> Issue Type: Bug
> Affects Versions: 3.3.0
> Reporter: Thomas Dudziak
> Assignee: Thomas Dudziak
> Fix For: 3.3.0
>
> Attachments: build.patch
>
>
> This is a problem if you use zookeeper as a dependency in maven because for whatever reason the maven compiler plugin will pick up the java files in the jar and compile them to the output directory. From there they will land in the generated jar file for whatever project happens to depend on zookeeper thus introducing duplicate classes (once in zookeeper.jar, once in the project's artifact).
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (ZOOKEEPER-537) The zookeeper jar includes the
java source files
Posted by "Thomas Dudziak (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/ZOOKEEPER-537?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12761079#action_12761079 ]
Thomas Dudziak commented on ZOOKEEPER-537:
------------------------------------------
Yes, all I'd like to see is separate zookeeper.jar and zookeeper-source.jar (and zookeeper-javadoc.jar would also be nice). Having source code is definitely a good thing because it makes debugging so much easier :-)
In the maven world you would get that automatically by adding something like this to the build section in the POM
<plugin>
<groupId>org.apache.maven.plugins</groupId>
<artifactId>maven-source-plugin</artifactId>
<executions>
<execution>
<id>attach-sources</id>
<phase>verify</phase>
<goals>
<goal>jar</goal>
</goals>
</execution>
</executions>
</plugin>
(and similarly for javadoc).
> The zookeeper jar includes the java source files
> ------------------------------------------------
>
> Key: ZOOKEEPER-537
> URL: https://issues.apache.org/jira/browse/ZOOKEEPER-537
> Project: Zookeeper
> Issue Type: Bug
> Affects Versions: 3.2.1
> Reporter: Thomas Dudziak
> Fix For: 3.3.0
>
>
> This is a problem if you use zookeeper as a dependency in maven because for whatever reason the maven compiler plugin will pick up the java files in the jar and compile them to the output directory. From there they will land in the generated jar file for whatever project happens to depend on zookeeper thus introducing duplicate classes (once in zookeeper.jar, once in the project's artifact).
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (ZOOKEEPER-537) The zookeeper jar includes the
java source files
Posted by "Mahadev konar (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/ZOOKEEPER-537?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12772679#action_12772679 ]
Mahadev konar commented on ZOOKEEPER-537:
-----------------------------------------
thomas,
After reading hiram's comments on this jira, do you still think this is a problem and needs to get fixed?
https://issues.apache.org/jira/browse/ZOOKEEPER-537?focusedCommentId=12767931&page=com.atlassian.jira.plugin.system.issuetabpanels%3Acomment-tabpanel#action_12767931
is the link to his comments.
> The zookeeper jar includes the java source files
> ------------------------------------------------
>
> Key: ZOOKEEPER-537
> URL: https://issues.apache.org/jira/browse/ZOOKEEPER-537
> Project: Zookeeper
> Issue Type: Bug
> Affects Versions: 3.3.0
> Reporter: Thomas Dudziak
> Fix For: 3.3.0
>
> Attachments: build.patch
>
>
> This is a problem if you use zookeeper as a dependency in maven because for whatever reason the maven compiler plugin will pick up the java files in the jar and compile them to the output directory. From there they will land in the generated jar file for whatever project happens to depend on zookeeper thus introducing duplicate classes (once in zookeeper.jar, once in the project's artifact).
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (ZOOKEEPER-537) The zookeeper jar includes the
java source files
Posted by "Thomas Dudziak (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/ZOOKEEPER-537?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12759786#action_12759786 ]
Thomas Dudziak commented on ZOOKEEPER-537:
------------------------------------------
Fixing is easy, just add exludes in the Ant build:
<target name="compile-extra" depends="compile-main" if="extra.src.dir">
...
<copy todir="${build.classes}">
<fileset dir="${extra.src.dir}">
<exclude name="**/*.java"/>
</fileset>
</copy>
</target>
<target name="compile-main" depends="build-generated">
...
<copy todir="${build.classes}">
<fileset dir="${java.src.dir}">
<exclude name="**/*.java"/>
</fileset>
<fileset dir="${src_generated.dir}">
<exclude name="**/*.java"/>
</fileset>
</copy>
</target>
> The zookeeper jar includes the java source files
> ------------------------------------------------
>
> Key: ZOOKEEPER-537
> URL: https://issues.apache.org/jira/browse/ZOOKEEPER-537
> Project: Zookeeper
> Issue Type: Bug
> Affects Versions: 3.2.1
> Reporter: Thomas Dudziak
> Fix For: 3.2.1
>
>
> This is a problem if you use zookeeper as a dependency in maven because for whatever reason the maven compiler plugin will pick up the java files in the jar and compile them to the output directory. From there they will land in the generated jar file for whatever project happens to depend on zookeeper thus introducing duplicate classes (once in zookeeper.jar, once in the project's artifact).
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (ZOOKEEPER-537) The zookeeper jar includes the
java source files
Posted by "Thomas Dudziak (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/ZOOKEEPER-537?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12772682#action_12772682 ]
Thomas Dudziak commented on ZOOKEEPER-537:
------------------------------------------
@Patrick: I'll tweak it.
> The zookeeper jar includes the java source files
> ------------------------------------------------
>
> Key: ZOOKEEPER-537
> URL: https://issues.apache.org/jira/browse/ZOOKEEPER-537
> Project: Zookeeper
> Issue Type: Bug
> Affects Versions: 3.3.0
> Reporter: Thomas Dudziak
> Fix For: 3.3.0
>
> Attachments: build.patch
>
>
> This is a problem if you use zookeeper as a dependency in maven because for whatever reason the maven compiler plugin will pick up the java files in the jar and compile them to the output directory. From there they will land in the generated jar file for whatever project happens to depend on zookeeper thus introducing duplicate classes (once in zookeeper.jar, once in the project's artifact).
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (ZOOKEEPER-537) The zookeeper jar includes the java
source files
Posted by "Patrick Hunt (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/ZOOKEEPER-537?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Patrick Hunt updated ZOOKEEPER-537:
-----------------------------------
Fix Version/s: (was: 3.2.1)
3.3.0
3.2.1 is out the door so moving this for consideration in 3.3. I know Hadoop in general does this (mr/hdfs/etc...) and Mahadev feels strongly about this "feature".
Thomas, can't Maven handle this? Perhaps by explicitly excluding the zk classes in question from the generated jar (the one in your project I mean). Seems like a bug in Maven regardless (we don't see this in other build systems), perhaps you can followup by entering a JIRA against Maven itself?
> The zookeeper jar includes the java source files
> ------------------------------------------------
>
> Key: ZOOKEEPER-537
> URL: https://issues.apache.org/jira/browse/ZOOKEEPER-537
> Project: Zookeeper
> Issue Type: Bug
> Affects Versions: 3.2.1
> Reporter: Thomas Dudziak
> Fix For: 3.3.0
>
>
> This is a problem if you use zookeeper as a dependency in maven because for whatever reason the maven compiler plugin will pick up the java files in the jar and compile them to the output directory. From there they will land in the generated jar file for whatever project happens to depend on zookeeper thus introducing duplicate classes (once in zookeeper.jar, once in the project's artifact).
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (ZOOKEEPER-537) The zookeeper jar includes the java
source files
Posted by "Thomas Dudziak (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/ZOOKEEPER-537?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Thomas Dudziak updated ZOOKEEPER-537:
-------------------------------------
Attachment: build.patch
Updated patch that creates additional -bin, -src, -javadoc jars.
> The zookeeper jar includes the java source files
> ------------------------------------------------
>
> Key: ZOOKEEPER-537
> URL: https://issues.apache.org/jira/browse/ZOOKEEPER-537
> Project: Zookeeper
> Issue Type: Bug
> Affects Versions: 3.3.0
> Reporter: Thomas Dudziak
> Fix For: 3.3.0
>
> Attachments: build.patch
>
>
> This is a problem if you use zookeeper as a dependency in maven because for whatever reason the maven compiler plugin will pick up the java files in the jar and compile them to the output directory. From there they will land in the generated jar file for whatever project happens to depend on zookeeper thus introducing duplicate classes (once in zookeeper.jar, once in the project's artifact).
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (ZOOKEEPER-537) The zookeeper jar includes the java
source files
Posted by "Thomas Dudziak (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/ZOOKEEPER-537?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Thomas Dudziak updated ZOOKEEPER-537:
-------------------------------------
Affects Version/s: (was: 3.2.1)
3.3.0
Status: Patch Available (was: Open)
This is a patch to the build.xml in trunk to add the generation of a separate src jar file.
> The zookeeper jar includes the java source files
> ------------------------------------------------
>
> Key: ZOOKEEPER-537
> URL: https://issues.apache.org/jira/browse/ZOOKEEPER-537
> Project: Zookeeper
> Issue Type: Bug
> Affects Versions: 3.3.0
> Reporter: Thomas Dudziak
> Fix For: 3.3.0
>
> Attachments: build.patch
>
>
> This is a problem if you use zookeeper as a dependency in maven because for whatever reason the maven compiler plugin will pick up the java files in the jar and compile them to the output directory. From there they will land in the generated jar file for whatever project happens to depend on zookeeper thus introducing duplicate classes (once in zookeeper.jar, once in the project's artifact).
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (ZOOKEEPER-537) The zookeeper jar includes the
java source files
Posted by "Thomas Dudziak (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/ZOOKEEPER-537?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12761024#action_12761024 ]
Thomas Dudziak commented on ZOOKEEPER-537:
------------------------------------------
Every other open or closed source project I've worked with, separated these into two jars, one just for the binary class files and additional resources, and one only for the sources. In the maven world, you'd also see a third one containing the javadoc. The reasons for that are several. For instance, a lot of people still care about the size of a released artifact and a few kilobytes actually matters to them. Also, all kinds of tools are build among these assumptions. Take your usual Java IDE - you can point it at a jar containing class files and it will happily use them. Or you tell it this other jar contains source files, and it will link them. However if the jar contains both, then you might encounter problems in the IDE because the assumption was that they are actually separate jars.
> The zookeeper jar includes the java source files
> ------------------------------------------------
>
> Key: ZOOKEEPER-537
> URL: https://issues.apache.org/jira/browse/ZOOKEEPER-537
> Project: Zookeeper
> Issue Type: Bug
> Affects Versions: 3.2.1
> Reporter: Thomas Dudziak
> Fix For: 3.3.0
>
>
> This is a problem if you use zookeeper as a dependency in maven because for whatever reason the maven compiler plugin will pick up the java files in the jar and compile them to the output directory. From there they will land in the generated jar file for whatever project happens to depend on zookeeper thus introducing duplicate classes (once in zookeeper.jar, once in the project's artifact).
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (ZOOKEEPER-537) The zookeeper jar includes the
java source files
Posted by "Hiram Chirino (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/ZOOKEEPER-537?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12767931#action_12767931 ]
Hiram Chirino commented on ZOOKEEPER-537:
-----------------------------------------
I think the reported issue is invalid. There are many cases where maven jars contain source code. For example all GWT builds include the source in jars. There has never been a report of this problem. I would close this issue out until the reporter can demonstrate the problem with a test case.
> The zookeeper jar includes the java source files
> ------------------------------------------------
>
> Key: ZOOKEEPER-537
> URL: https://issues.apache.org/jira/browse/ZOOKEEPER-537
> Project: Zookeeper
> Issue Type: Bug
> Affects Versions: 3.2.1
> Reporter: Thomas Dudziak
> Fix For: 3.3.0
>
>
> This is a problem if you use zookeeper as a dependency in maven because for whatever reason the maven compiler plugin will pick up the java files in the jar and compile them to the output directory. From there they will land in the generated jar file for whatever project happens to depend on zookeeper thus introducing duplicate classes (once in zookeeper.jar, once in the project's artifact).
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (ZOOKEEPER-537) The zookeeper jar includes the
java source files
Posted by "Patrick Hunt (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/ZOOKEEPER-537?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12774407#action_12774407 ]
Patrick Hunt commented on ZOOKEEPER-537:
----------------------------------------
hadoopqa issues are ok - rat is complaining about the new jars/checksums, which is not a real issue.
> The zookeeper jar includes the java source files
> ------------------------------------------------
>
> Key: ZOOKEEPER-537
> URL: https://issues.apache.org/jira/browse/ZOOKEEPER-537
> Project: Zookeeper
> Issue Type: Bug
> Affects Versions: 3.3.0
> Reporter: Thomas Dudziak
> Assignee: Thomas Dudziak
> Fix For: 3.3.0
>
> Attachments: build.patch, ZOOKEEPER-537.patch
>
>
> This is a problem if you use zookeeper as a dependency in maven because for whatever reason the maven compiler plugin will pick up the java files in the jar and compile them to the output directory. From there they will land in the generated jar file for whatever project happens to depend on zookeeper thus introducing duplicate classes (once in zookeeper.jar, once in the project's artifact).
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (ZOOKEEPER-537) The zookeeper jar includes the
java source files
Posted by "Patrick Hunt (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/ZOOKEEPER-537?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12763561#action_12763561 ]
Patrick Hunt commented on ZOOKEEPER-537:
----------------------------------------
Here's an idea, Thomas tell me if this works for you (maven):
1) do everything the same as today (legacy, not maven optimal), except
2) add a new "maven" directory to the release that contains the 3 jars thomas suggested (signed bin/src/doc jars, pom)
We can then deploy the contents of the maven directory to the maven repo as part of the release process.
Thomas, we use Ivy to generate, any idea how to do what you detailed (the xml) for maven but with Ivy? How about a pointer to a project that you think "does things right" that I can look at and make sure we have similar output.
> The zookeeper jar includes the java source files
> ------------------------------------------------
>
> Key: ZOOKEEPER-537
> URL: https://issues.apache.org/jira/browse/ZOOKEEPER-537
> Project: Zookeeper
> Issue Type: Bug
> Affects Versions: 3.2.1
> Reporter: Thomas Dudziak
> Fix For: 3.3.0
>
>
> This is a problem if you use zookeeper as a dependency in maven because for whatever reason the maven compiler plugin will pick up the java files in the jar and compile them to the output directory. From there they will land in the generated jar file for whatever project happens to depend on zookeeper thus introducing duplicate classes (once in zookeeper.jar, once in the project's artifact).
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (ZOOKEEPER-537) The zookeeper jar includes the java
source files
Posted by "Patrick Hunt (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/ZOOKEEPER-537?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Patrick Hunt updated ZOOKEEPER-537:
-----------------------------------
Status: Open (was: Patch Available)
Thomas there are at least a couple of outstanding comments not addressed by this patch, specifically there
is interest to not change the existing jar file as it is currently used for those non-maven users.. I put forth the
idea to have a separate set of jars for bin/src/jdoc (btw, I don't see the jdoc jar in your patch, isn't that something
you had mentioned would be useful?)
https://issues.apache.org/jira/browse/ZOOKEEPER-537?focusedCommentId=12761052&page=com.atlassian.jira.plugin.system.issuetabpanels%3Acomment-tabpanel#action_12761052
https://issues.apache.org/jira/browse/ZOOKEEPER-537?focusedCommentId=12763561&page=com.atlassian.jira.plugin.system.issuetabpanels%3Acomment-tabpanel#action_12763561
Do you see an issue with what I'm suggesting?
> The zookeeper jar includes the java source files
> ------------------------------------------------
>
> Key: ZOOKEEPER-537
> URL: https://issues.apache.org/jira/browse/ZOOKEEPER-537
> Project: Zookeeper
> Issue Type: Bug
> Affects Versions: 3.3.0
> Reporter: Thomas Dudziak
> Fix For: 3.3.0
>
> Attachments: build.patch
>
>
> This is a problem if you use zookeeper as a dependency in maven because for whatever reason the maven compiler plugin will pick up the java files in the jar and compile them to the output directory. From there they will land in the generated jar file for whatever project happens to depend on zookeeper thus introducing duplicate classes (once in zookeeper.jar, once in the project's artifact).
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (ZOOKEEPER-537) The zookeeper jar includes the
java source files
Posted by "Thomas Dudziak (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/ZOOKEEPER-537?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12768029#action_12768029 ]
Thomas Dudziak commented on ZOOKEEPER-537:
------------------------------------------
@Patrick: I can make a stab at the build.xml later this week.
@Hiram: Well, I'm no expert in GWT, but doesn't it have to be this way so that GWT compiles the java source code on the fly in a web application (quite similar to JSP pages) ? But this then means that you're not depending on the GWT build as a library, and you thus won't get any dependency conflicts because you happen to have another conflicting version on the classpath. And this is exactly the problem with zookeeper: Maven sees source files in the jar and compiles them, so I'll get zookeeper classes in my jar which then can conflict with some other version of zookeeper that I might have on the classpath.
> The zookeeper jar includes the java source files
> ------------------------------------------------
>
> Key: ZOOKEEPER-537
> URL: https://issues.apache.org/jira/browse/ZOOKEEPER-537
> Project: Zookeeper
> Issue Type: Bug
> Affects Versions: 3.2.1
> Reporter: Thomas Dudziak
> Fix For: 3.3.0
>
>
> This is a problem if you use zookeeper as a dependency in maven because for whatever reason the maven compiler plugin will pick up the java files in the jar and compile them to the output directory. From there they will land in the generated jar file for whatever project happens to depend on zookeeper thus introducing duplicate classes (once in zookeeper.jar, once in the project's artifact).
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (ZOOKEEPER-537) The zookeeper jar includes the
java source files
Posted by "Patrick Hunt (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/ZOOKEEPER-537?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12768030#action_12768030 ]
Patrick Hunt commented on ZOOKEEPER-537:
----------------------------------------
Thanks Thomas! We really would like to provide official ZK in a Maven repo, unfortunately we don't
have the experience/expertise/cycles to study all these issues. Every time I think we are close
something else pops up. Your/Hiram's help is appreciated.
> The zookeeper jar includes the java source files
> ------------------------------------------------
>
> Key: ZOOKEEPER-537
> URL: https://issues.apache.org/jira/browse/ZOOKEEPER-537
> Project: Zookeeper
> Issue Type: Bug
> Affects Versions: 3.2.1
> Reporter: Thomas Dudziak
> Fix For: 3.3.0
>
>
> This is a problem if you use zookeeper as a dependency in maven because for whatever reason the maven compiler plugin will pick up the java files in the jar and compile them to the output directory. From there they will land in the generated jar file for whatever project happens to depend on zookeeper thus introducing duplicate classes (once in zookeeper.jar, once in the project's artifact).
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (ZOOKEEPER-537) The zookeeper jar includes the java
source files
Posted by "Thomas Dudziak (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/ZOOKEEPER-537?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Thomas Dudziak updated ZOOKEEPER-537:
-------------------------------------
Attachment: build.patch
> The zookeeper jar includes the java source files
> ------------------------------------------------
>
> Key: ZOOKEEPER-537
> URL: https://issues.apache.org/jira/browse/ZOOKEEPER-537
> Project: Zookeeper
> Issue Type: Bug
> Affects Versions: 3.3.0
> Reporter: Thomas Dudziak
> Fix For: 3.3.0
>
> Attachments: build.patch
>
>
> This is a problem if you use zookeeper as a dependency in maven because for whatever reason the maven compiler plugin will pick up the java files in the jar and compile them to the output directory. From there they will land in the generated jar file for whatever project happens to depend on zookeeper thus introducing duplicate classes (once in zookeeper.jar, once in the project's artifact).
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (ZOOKEEPER-537) The zookeeper jar includes the
java source files
Posted by "Hadoop QA (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/ZOOKEEPER-537?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12774373#action_12774373 ]
Hadoop QA commented on ZOOKEEPER-537:
-------------------------------------
-1 overall. Here are the results of testing the latest attachment
http://issues.apache.org/jira/secure/attachment/12423862/build.patch
against trunk revision 831486.
+1 @author. The patch does not contain any @author tags.
-1 tests included. The patch doesn't appear to include any new or modified tests.
Please justify why no tests are needed for this patch.
+1 javadoc. The javadoc tool did not generate any warning messages.
+1 javac. The applied patch does not increase the total number of javac compiler warnings.
+1 findbugs. The patch does not introduce any new Findbugs warnings.
-1 release audit. The applied patch generated 186 release audit warnings (more than the trunk's current 182 warnings).
+1 core tests. The patch passed core unit tests.
+1 contrib tests. The patch passed contrib unit tests.
Test results: http://hudson.zones.apache.org/hudson/job/Zookeeper-Patch-h8.grid.sp2.yahoo.net/48/testReport/
Release audit warnings: http://hudson.zones.apache.org/hudson/job/Zookeeper-Patch-h8.grid.sp2.yahoo.net/48/artifact/trunk/patchprocess/releaseAuditDiffWarnings.txt
Findbugs warnings: http://hudson.zones.apache.org/hudson/job/Zookeeper-Patch-h8.grid.sp2.yahoo.net/48/artifact/trunk/build/test/findbugs/newPatchFindbugsWarnings.html
Console output: http://hudson.zones.apache.org/hudson/job/Zookeeper-Patch-h8.grid.sp2.yahoo.net/48/console
This message is automatically generated.
> The zookeeper jar includes the java source files
> ------------------------------------------------
>
> Key: ZOOKEEPER-537
> URL: https://issues.apache.org/jira/browse/ZOOKEEPER-537
> Project: Zookeeper
> Issue Type: Bug
> Affects Versions: 3.3.0
> Reporter: Thomas Dudziak
> Assignee: Thomas Dudziak
> Fix For: 3.3.0
>
> Attachments: build.patch
>
>
> This is a problem if you use zookeeper as a dependency in maven because for whatever reason the maven compiler plugin will pick up the java files in the jar and compile them to the output directory. From there they will land in the generated jar file for whatever project happens to depend on zookeeper thus introducing duplicate classes (once in zookeeper.jar, once in the project's artifact).
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (ZOOKEEPER-537) The zookeeper jar includes the
java source files
Posted by "Hudson (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/ZOOKEEPER-537?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12774726#action_12774726 ]
Hudson commented on ZOOKEEPER-537:
----------------------------------
Integrated in ZooKeeper-trunk #522 (See [http://hudson.zones.apache.org/hudson/job/ZooKeeper-trunk/522/])
> The zookeeper jar includes the java source files
> ------------------------------------------------
>
> Key: ZOOKEEPER-537
> URL: https://issues.apache.org/jira/browse/ZOOKEEPER-537
> Project: Zookeeper
> Issue Type: Bug
> Affects Versions: 3.3.0
> Reporter: Thomas Dudziak
> Assignee: Thomas Dudziak
> Fix For: 3.3.0
>
> Attachments: build.patch, ZOOKEEPER-537.patch
>
>
> This is a problem if you use zookeeper as a dependency in maven because for whatever reason the maven compiler plugin will pick up the java files in the jar and compile them to the output directory. From there they will land in the generated jar file for whatever project happens to depend on zookeeper thus introducing duplicate classes (once in zookeeper.jar, once in the project's artifact).
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (ZOOKEEPER-537) The zookeeper jar includes the java
source files
Posted by "Thomas Dudziak (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/ZOOKEEPER-537?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Thomas Dudziak updated ZOOKEEPER-537:
-------------------------------------
Attachment: (was: build.patch)
> The zookeeper jar includes the java source files
> ------------------------------------------------
>
> Key: ZOOKEEPER-537
> URL: https://issues.apache.org/jira/browse/ZOOKEEPER-537
> Project: Zookeeper
> Issue Type: Bug
> Affects Versions: 3.3.0
> Reporter: Thomas Dudziak
> Fix For: 3.3.0
>
> Attachments: build.patch
>
>
> This is a problem if you use zookeeper as a dependency in maven because for whatever reason the maven compiler plugin will pick up the java files in the jar and compile them to the output directory. From there they will land in the generated jar file for whatever project happens to depend on zookeeper thus introducing duplicate classes (once in zookeeper.jar, once in the project's artifact).
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (ZOOKEEPER-537) The zookeeper jar includes the
java source files
Posted by "Hadoop QA (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/ZOOKEEPER-537?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12772642#action_12772642 ]
Hadoop QA commented on ZOOKEEPER-537:
-------------------------------------
-1 overall. Here are the results of testing the latest attachment
http://issues.apache.org/jira/secure/attachment/12423846/build.patch
against trunk revision 831486.
+1 @author. The patch does not contain any @author tags.
-1 tests included. The patch doesn't appear to include any new or modified tests.
Please justify why no tests are needed for this patch.
+1 javadoc. The javadoc tool did not generate any warning messages.
+1 javac. The applied patch does not increase the total number of javac compiler warnings.
+1 findbugs. The patch does not introduce any new Findbugs warnings.
-1 release audit. The applied patch generated 184 release audit warnings (more than the trunk's current 182 warnings).
+1 core tests. The patch passed core unit tests.
+1 contrib tests. The patch passed contrib unit tests.
Test results: http://hudson.zones.apache.org/hudson/job/Zookeeper-Patch-h8.grid.sp2.yahoo.net/43/testReport/
Release audit warnings: http://hudson.zones.apache.org/hudson/job/Zookeeper-Patch-h8.grid.sp2.yahoo.net/43/artifact/trunk/patchprocess/releaseAuditDiffWarnings.txt
Findbugs warnings: http://hudson.zones.apache.org/hudson/job/Zookeeper-Patch-h8.grid.sp2.yahoo.net/43/artifact/trunk/build/test/findbugs/newPatchFindbugsWarnings.html
Console output: http://hudson.zones.apache.org/hudson/job/Zookeeper-Patch-h8.grid.sp2.yahoo.net/43/console
This message is automatically generated.
> The zookeeper jar includes the java source files
> ------------------------------------------------
>
> Key: ZOOKEEPER-537
> URL: https://issues.apache.org/jira/browse/ZOOKEEPER-537
> Project: Zookeeper
> Issue Type: Bug
> Affects Versions: 3.3.0
> Reporter: Thomas Dudziak
> Fix For: 3.3.0
>
> Attachments: build.patch
>
>
> This is a problem if you use zookeeper as a dependency in maven because for whatever reason the maven compiler plugin will pick up the java files in the jar and compile them to the output directory. From there they will land in the generated jar file for whatever project happens to depend on zookeeper thus introducing duplicate classes (once in zookeeper.jar, once in the project's artifact).
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (ZOOKEEPER-537) The zookeeper jar includes the
java source files
Posted by "Mahadev konar (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/ZOOKEEPER-537?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12761052#action_12761052 ]
Mahadev konar commented on ZOOKEEPER-537:
-----------------------------------------
the only reason I feel strongly about this is the following-
- we have had a lot of production installations for hadoop and zookeeper. I have been invloved in supporting both of them. One thing I have found while supporting these frameworks/services is that folks tend to sometime add patches to there specific installations. So, having source code as an artifact of the release makes it easy for folks like me (developers), wherein we can take a look at the code sometimes (when all else fails) and find out what this source code contains or what changes it might have (different from the real apache release, sometimes that information gets missing as well).
Thomas:
are you proposing a seperate source jar as a part of release artifact as well?
> The zookeeper jar includes the java source files
> ------------------------------------------------
>
> Key: ZOOKEEPER-537
> URL: https://issues.apache.org/jira/browse/ZOOKEEPER-537
> Project: Zookeeper
> Issue Type: Bug
> Affects Versions: 3.2.1
> Reporter: Thomas Dudziak
> Fix For: 3.3.0
>
>
> This is a problem if you use zookeeper as a dependency in maven because for whatever reason the maven compiler plugin will pick up the java files in the jar and compile them to the output directory. From there they will land in the generated jar file for whatever project happens to depend on zookeeper thus introducing duplicate classes (once in zookeeper.jar, once in the project's artifact).
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (ZOOKEEPER-537) The zookeeper jar includes the java
source files
Posted by "Patrick Hunt (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/ZOOKEEPER-537?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Patrick Hunt updated ZOOKEEPER-537:
-----------------------------------
Attachment: ZOOKEEPER-537.patch
The patch looks good to me, a few minor issues:
There was an issue I noticed with the license file being spec'd wrong (that's legacy though, so an old bug). This latest patch fixes that as well.
I also added some detail to the readme about what to expect from the build artifacts (the jars).
Thomas -- the pom does not need to be signed? (minor nit, you should name the patches after the JIRA (makes our lives easier - committers/reviewers) and also you can just upload a new patch with the same name, don't delete the old one, jira will handle it correctly, allows us to see old versions)
ZOOKEEPER_537.patch obsoletes build.patch.
Thanks Thomas!
> The zookeeper jar includes the java source files
> ------------------------------------------------
>
> Key: ZOOKEEPER-537
> URL: https://issues.apache.org/jira/browse/ZOOKEEPER-537
> Project: Zookeeper
> Issue Type: Bug
> Affects Versions: 3.3.0
> Reporter: Thomas Dudziak
> Assignee: Thomas Dudziak
> Fix For: 3.3.0
>
> Attachments: build.patch, ZOOKEEPER-537.patch
>
>
> This is a problem if you use zookeeper as a dependency in maven because for whatever reason the maven compiler plugin will pick up the java files in the jar and compile them to the output directory. From there they will land in the generated jar file for whatever project happens to depend on zookeeper thus introducing duplicate classes (once in zookeeper.jar, once in the project's artifact).
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (ZOOKEEPER-537) The zookeeper jar includes the
java source files
Posted by "Patrick Hunt (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/ZOOKEEPER-537?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12761036#action_12761036 ]
Patrick Hunt commented on ZOOKEEPER-537:
----------------------------------------
For some reason hadoop does it this way, we inherited their basic build structure. I don't see why we couldn't provide build artifacts like you suggest (although others may disagree. this is the first time we've ever heard of this issue, it is not a recent change), however my point before was addressed to the fact that currently released/published artifacts include the source. Unless you want to wait for this to be resolved and a new release shipped, it would be good to find a workable solution for what we have today. I'm not familiar enough with maven, hence my suggestion that you talk with someone who is.
> The zookeeper jar includes the java source files
> ------------------------------------------------
>
> Key: ZOOKEEPER-537
> URL: https://issues.apache.org/jira/browse/ZOOKEEPER-537
> Project: Zookeeper
> Issue Type: Bug
> Affects Versions: 3.2.1
> Reporter: Thomas Dudziak
> Fix For: 3.3.0
>
>
> This is a problem if you use zookeeper as a dependency in maven because for whatever reason the maven compiler plugin will pick up the java files in the jar and compile them to the output directory. From there they will land in the generated jar file for whatever project happens to depend on zookeeper thus introducing duplicate classes (once in zookeeper.jar, once in the project's artifact).
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (ZOOKEEPER-537) The zookeeper jar includes the
java source files
Posted by "Thomas Dudziak (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/ZOOKEEPER-537?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12772680#action_12772680 ]
Thomas Dudziak commented on ZOOKEEPER-537:
------------------------------------------
@Mahadev: Yes - see my reply above. His comparison to GWT does not apply as afaik you don't typically depend on the GWT builds as libraries.
> The zookeeper jar includes the java source files
> ------------------------------------------------
>
> Key: ZOOKEEPER-537
> URL: https://issues.apache.org/jira/browse/ZOOKEEPER-537
> Project: Zookeeper
> Issue Type: Bug
> Affects Versions: 3.3.0
> Reporter: Thomas Dudziak
> Fix For: 3.3.0
>
> Attachments: build.patch
>
>
> This is a problem if you use zookeeper as a dependency in maven because for whatever reason the maven compiler plugin will pick up the java files in the jar and compile them to the output directory. From there they will land in the generated jar file for whatever project happens to depend on zookeeper thus introducing duplicate classes (once in zookeeper.jar, once in the project's artifact).
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (ZOOKEEPER-537) The zookeeper jar includes the java
source files
Posted by "Patrick Hunt (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/ZOOKEEPER-537?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Patrick Hunt updated ZOOKEEPER-537:
-----------------------------------
Status: Open (was: Patch Available)
> The zookeeper jar includes the java source files
> ------------------------------------------------
>
> Key: ZOOKEEPER-537
> URL: https://issues.apache.org/jira/browse/ZOOKEEPER-537
> Project: Zookeeper
> Issue Type: Bug
> Affects Versions: 3.3.0
> Reporter: Thomas Dudziak
> Assignee: Thomas Dudziak
> Fix For: 3.3.0
>
> Attachments: build.patch
>
>
> This is a problem if you use zookeeper as a dependency in maven because for whatever reason the maven compiler plugin will pick up the java files in the jar and compile them to the output directory. From there they will land in the generated jar file for whatever project happens to depend on zookeeper thus introducing duplicate classes (once in zookeeper.jar, once in the project's artifact).
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.