You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@kudu.apache.org by "Hao Hao (Code Review)" <ge...@cloudera.org> on 2018/03/13 00:20:44 UTC
[kudu-CR] [release notes]: RYW read mode
Hao Hao has uploaded this change for review. ( http://gerrit.cloudera.org:8080/9594
Change subject: [release notes]: RYW read mode
......................................................................
[release notes]: RYW read mode
Change-Id: I9906398b0796307c26150f78e0e256e285ded516
---
M docs/release_notes.adoc
1 file changed, 8 insertions(+), 1 deletion(-)
git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/94/9594/1
--
To view, visit http://gerrit.cloudera.org:8080/9594
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: newchange
Gerrit-Change-Id: I9906398b0796307c26150f78e0e256e285ded516
Gerrit-Change-Number: 9594
Gerrit-PatchSet: 1
Gerrit-Owner: Hao Hao <ha...@cloudera.com>
[kudu-CR] [release notes]: RYW read mode
Posted by "Hao Hao (Code Review)" <ge...@cloudera.org>.
Hao Hao has removed a vote on this change.
Change subject: [release notes]: RYW read mode
......................................................................
Removed Verified-1 by Kudu Jenkins (120)
--
To view, visit http://gerrit.cloudera.org:8080/9594
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: deleteVote
Gerrit-Change-Id: I9906398b0796307c26150f78e0e256e285ded516
Gerrit-Change-Number: 9594
Gerrit-PatchSet: 1
Gerrit-Owner: Hao Hao <ha...@cloudera.com>
Gerrit-Reviewer: Dan Burkert <da...@apache.org>
Gerrit-Reviewer: David Ribeiro Alves <da...@gmail.com>
Gerrit-Reviewer: Kudu Jenkins
[kudu-CR] [release notes]: RYW read mode
Posted by "Hao Hao (Code Review)" <ge...@cloudera.org>.
Hao Hao has posted comments on this change. ( http://gerrit.cloudera.org:8080/9594 )
Change subject: [release notes]: RYW read mode
......................................................................
Patch Set 3:
(1 comment)
http://gerrit.cloudera.org:8080/#/c/9594/2/docs/release_notes.adoc
File docs/release_notes.adoc:
http://gerrit.cloudera.org:8080/#/c/9594/2/docs/release_notes.adoc@78
PS2, Line 78: C++ and Java
> Capitalize C++ and Java.
Done
--
To view, visit http://gerrit.cloudera.org:8080/9594
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I9906398b0796307c26150f78e0e256e285ded516
Gerrit-Change-Number: 9594
Gerrit-PatchSet: 3
Gerrit-Owner: Hao Hao <ha...@cloudera.com>
Gerrit-Reviewer: Dan Burkert <da...@apache.org>
Gerrit-Reviewer: David Ribeiro Alves <da...@gmail.com>
Gerrit-Reviewer: Grant Henke <gr...@gmail.com>
Gerrit-Reviewer: Hao Hao <ha...@cloudera.com>
Gerrit-Reviewer: Kudu Jenkins
Gerrit-Comment-Date: Tue, 13 Mar 2018 19:37:37 +0000
Gerrit-HasComments: Yes
[kudu-CR] [release notes]: RYW read mode
Posted by "Dan Burkert (Code Review)" <ge...@cloudera.org>.
Dan Burkert has posted comments on this change. ( http://gerrit.cloudera.org:8080/9594 )
Change subject: [release notes]: RYW read mode
......................................................................
Patch Set 2:
(1 comment)
http://gerrit.cloudera.org:8080/#/c/9594/2/docs/release_notes.adoc
File docs/release_notes.adoc:
http://gerrit.cloudera.org:8080/#/c/9594/2/docs/release_notes.adoc@78
PS2, Line 78: c++ and java
Capitalize C++ and Java.
--
To view, visit http://gerrit.cloudera.org:8080/9594
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I9906398b0796307c26150f78e0e256e285ded516
Gerrit-Change-Number: 9594
Gerrit-PatchSet: 2
Gerrit-Owner: Hao Hao <ha...@cloudera.com>
Gerrit-Reviewer: Dan Burkert <da...@apache.org>
Gerrit-Reviewer: David Ribeiro Alves <da...@gmail.com>
Gerrit-Reviewer: Grant Henke <gr...@gmail.com>
Gerrit-Reviewer: Hao Hao <ha...@cloudera.com>
Gerrit-Reviewer: Kudu Jenkins
Gerrit-Comment-Date: Tue, 13 Mar 2018 19:08:41 +0000
Gerrit-HasComments: Yes
[kudu-CR] [release notes]: RYW read mode
Posted by "Hao Hao (Code Review)" <ge...@cloudera.org>.
Hao Hao has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/9594 )
Change subject: [release notes]: RYW read mode
......................................................................
[release notes]: RYW read mode
Change-Id: I9906398b0796307c26150f78e0e256e285ded516
Reviewed-on: http://gerrit.cloudera.org:8080/9594
Reviewed-by: Dan Burkert <da...@apache.org>
Reviewed-by: Grant Henke <gr...@gmail.com>
Reviewed-by: David Ribeiro Alves <da...@gmail.com>
Tested-by: Kudu Jenkins
---
M docs/release_notes.adoc
1 file changed, 9 insertions(+), 0 deletions(-)
Approvals:
Dan Burkert: Looks good to me, but someone else must approve
Grant Henke: Looks good to me, approved
David Ribeiro Alves: Looks good to me, approved
Kudu Jenkins: Verified
--
To view, visit http://gerrit.cloudera.org:8080/9594
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: merged
Gerrit-Change-Id: I9906398b0796307c26150f78e0e256e285ded516
Gerrit-Change-Number: 9594
Gerrit-PatchSet: 4
Gerrit-Owner: Hao Hao <ha...@cloudera.com>
Gerrit-Reviewer: Dan Burkert <da...@apache.org>
Gerrit-Reviewer: David Ribeiro Alves <da...@gmail.com>
Gerrit-Reviewer: Grant Henke <gr...@gmail.com>
Gerrit-Reviewer: Hao Hao <ha...@cloudera.com>
Gerrit-Reviewer: Kudu Jenkins
[kudu-CR] [release notes]: RYW read mode
Posted by "David Ribeiro Alves (Code Review)" <ge...@cloudera.org>.
David Ribeiro Alves has posted comments on this change. ( http://gerrit.cloudera.org:8080/9594 )
Change subject: [release notes]: RYW read mode
......................................................................
Patch Set 1:
(1 comment)
http://gerrit.cloudera.org:8080/#/c/9594/1/docs/release_notes.adoc
File docs/release_notes.adoc:
http://gerrit.cloudera.org:8080/#/c/9594/1/docs/release_notes.adoc@67
PS1, Line 67: new read
nit: "new scan read mode" or a "new read mode for scans" and add "that users can specify when creating a new scanner in both c++ and java clients"
--
To view, visit http://gerrit.cloudera.org:8080/9594
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I9906398b0796307c26150f78e0e256e285ded516
Gerrit-Change-Number: 9594
Gerrit-PatchSet: 1
Gerrit-Owner: Hao Hao <ha...@cloudera.com>
Gerrit-Reviewer: Dan Burkert <da...@apache.org>
Gerrit-Reviewer: David Ribeiro Alves <da...@gmail.com>
Gerrit-Reviewer: Grant Henke <gr...@gmail.com>
Gerrit-Reviewer: Hao Hao <ha...@cloudera.com>
Gerrit-Reviewer: Kudu Jenkins
Gerrit-Comment-Date: Tue, 13 Mar 2018 18:29:20 +0000
Gerrit-HasComments: Yes
[kudu-CR] [release notes]: RYW read mode
Posted by "Grant Henke (Code Review)" <ge...@cloudera.org>.
Grant Henke has posted comments on this change. ( http://gerrit.cloudera.org:8080/9594 )
Change subject: [release notes]: RYW read mode
......................................................................
Patch Set 3: Code-Review+2
--
To view, visit http://gerrit.cloudera.org:8080/9594
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I9906398b0796307c26150f78e0e256e285ded516
Gerrit-Change-Number: 9594
Gerrit-PatchSet: 3
Gerrit-Owner: Hao Hao <ha...@cloudera.com>
Gerrit-Reviewer: Dan Burkert <da...@apache.org>
Gerrit-Reviewer: David Ribeiro Alves <da...@gmail.com>
Gerrit-Reviewer: Grant Henke <gr...@gmail.com>
Gerrit-Reviewer: Hao Hao <ha...@cloudera.com>
Gerrit-Reviewer: Kudu Jenkins
Gerrit-Comment-Date: Tue, 13 Mar 2018 20:18:22 +0000
Gerrit-HasComments: No
[kudu-CR] [release notes]: RYW read mode
Posted by "David Ribeiro Alves (Code Review)" <ge...@cloudera.org>.
David Ribeiro Alves has posted comments on this change. ( http://gerrit.cloudera.org:8080/9594 )
Change subject: [release notes]: RYW read mode
......................................................................
Patch Set 3: Code-Review+2
--
To view, visit http://gerrit.cloudera.org:8080/9594
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I9906398b0796307c26150f78e0e256e285ded516
Gerrit-Change-Number: 9594
Gerrit-PatchSet: 3
Gerrit-Owner: Hao Hao <ha...@cloudera.com>
Gerrit-Reviewer: Dan Burkert <da...@apache.org>
Gerrit-Reviewer: David Ribeiro Alves <da...@gmail.com>
Gerrit-Reviewer: Grant Henke <gr...@gmail.com>
Gerrit-Reviewer: Hao Hao <ha...@cloudera.com>
Gerrit-Reviewer: Kudu Jenkins
Gerrit-Comment-Date: Tue, 13 Mar 2018 20:56:39 +0000
Gerrit-HasComments: No
[kudu-CR] [release notes]: RYW read mode
Posted by "Hao Hao (Code Review)" <ge...@cloudera.org>.
Hello Dan Burkert, David Ribeiro Alves, Kudu Jenkins, Grant Henke,
I'd like you to reexamine a change. Please visit
http://gerrit.cloudera.org:8080/9594
to look at the new patch set (#2).
Change subject: [release notes]: RYW read mode
......................................................................
[release notes]: RYW read mode
Change-Id: I9906398b0796307c26150f78e0e256e285ded516
---
M docs/release_notes.adoc
1 file changed, 9 insertions(+), 0 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/94/9594/2
--
To view, visit http://gerrit.cloudera.org:8080/9594
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: I9906398b0796307c26150f78e0e256e285ded516
Gerrit-Change-Number: 9594
Gerrit-PatchSet: 2
Gerrit-Owner: Hao Hao <ha...@cloudera.com>
Gerrit-Reviewer: Dan Burkert <da...@apache.org>
Gerrit-Reviewer: David Ribeiro Alves <da...@gmail.com>
Gerrit-Reviewer: Grant Henke <gr...@gmail.com>
Gerrit-Reviewer: Hao Hao <ha...@cloudera.com>
Gerrit-Reviewer: Kudu Jenkins
[kudu-CR] [release notes]: RYW read mode
Posted by "Dan Burkert (Code Review)" <ge...@cloudera.org>.
Dan Burkert has posted comments on this change. ( http://gerrit.cloudera.org:8080/9594 )
Change subject: [release notes]: RYW read mode
......................................................................
Patch Set 3: Code-Review+1
--
To view, visit http://gerrit.cloudera.org:8080/9594
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I9906398b0796307c26150f78e0e256e285ded516
Gerrit-Change-Number: 9594
Gerrit-PatchSet: 3
Gerrit-Owner: Hao Hao <ha...@cloudera.com>
Gerrit-Reviewer: Dan Burkert <da...@apache.org>
Gerrit-Reviewer: David Ribeiro Alves <da...@gmail.com>
Gerrit-Reviewer: Grant Henke <gr...@gmail.com>
Gerrit-Reviewer: Hao Hao <ha...@cloudera.com>
Gerrit-Reviewer: Kudu Jenkins
Gerrit-Comment-Date: Tue, 13 Mar 2018 20:15:29 +0000
Gerrit-HasComments: No
[kudu-CR] [release notes]: RYW read mode
Posted by "Hao Hao (Code Review)" <ge...@cloudera.org>.
Hao Hao has posted comments on this change. ( http://gerrit.cloudera.org:8080/9594 )
Change subject: [release notes]: RYW read mode
......................................................................
Patch Set 2:
(1 comment)
http://gerrit.cloudera.org:8080/#/c/9594/1/docs/release_notes.adoc
File docs/release_notes.adoc:
http://gerrit.cloudera.org:8080/#/c/9594/1/docs/release_notes.adoc@67
PS1, Line 67:
> nit: "new scan read mode" or a "new read mode for scans" and add "that user
Done
--
To view, visit http://gerrit.cloudera.org:8080/9594
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I9906398b0796307c26150f78e0e256e285ded516
Gerrit-Change-Number: 9594
Gerrit-PatchSet: 2
Gerrit-Owner: Hao Hao <ha...@cloudera.com>
Gerrit-Reviewer: Dan Burkert <da...@apache.org>
Gerrit-Reviewer: David Ribeiro Alves <da...@gmail.com>
Gerrit-Reviewer: Grant Henke <gr...@gmail.com>
Gerrit-Reviewer: Hao Hao <ha...@cloudera.com>
Gerrit-Reviewer: Kudu Jenkins
Gerrit-Comment-Date: Tue, 13 Mar 2018 18:42:32 +0000
Gerrit-HasComments: Yes
[kudu-CR] [release notes]: RYW read mode
Posted by "Hao Hao (Code Review)" <ge...@cloudera.org>.
Hao Hao has posted comments on this change. ( http://gerrit.cloudera.org:8080/9594 )
Change subject: [release notes]: RYW read mode
......................................................................
Patch Set 1: Verified+1
Unrelated test failure.
--
To view, visit http://gerrit.cloudera.org:8080/9594
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I9906398b0796307c26150f78e0e256e285ded516
Gerrit-Change-Number: 9594
Gerrit-PatchSet: 1
Gerrit-Owner: Hao Hao <ha...@cloudera.com>
Gerrit-Reviewer: Dan Burkert <da...@apache.org>
Gerrit-Reviewer: David Ribeiro Alves <da...@gmail.com>
Gerrit-Reviewer: Hao Hao <ha...@cloudera.com>
Gerrit-Reviewer: Kudu Jenkins
Gerrit-Comment-Date: Tue, 13 Mar 2018 02:18:52 +0000
Gerrit-HasComments: No
[kudu-CR] [release notes]: RYW read mode
Posted by "Hao Hao (Code Review)" <ge...@cloudera.org>.
Hello Dan Burkert, David Ribeiro Alves, Kudu Jenkins, Grant Henke,
I'd like you to reexamine a change. Please visit
http://gerrit.cloudera.org:8080/9594
to look at the new patch set (#3).
Change subject: [release notes]: RYW read mode
......................................................................
[release notes]: RYW read mode
Change-Id: I9906398b0796307c26150f78e0e256e285ded516
---
M docs/release_notes.adoc
1 file changed, 9 insertions(+), 0 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/94/9594/3
--
To view, visit http://gerrit.cloudera.org:8080/9594
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: I9906398b0796307c26150f78e0e256e285ded516
Gerrit-Change-Number: 9594
Gerrit-PatchSet: 3
Gerrit-Owner: Hao Hao <ha...@cloudera.com>
Gerrit-Reviewer: Dan Burkert <da...@apache.org>
Gerrit-Reviewer: David Ribeiro Alves <da...@gmail.com>
Gerrit-Reviewer: Grant Henke <gr...@gmail.com>
Gerrit-Reviewer: Hao Hao <ha...@cloudera.com>
Gerrit-Reviewer: Kudu Jenkins