[jira] Commented: (HADOOP-4176) Implement getFileChecksum(Path) in HftpFileSystem

["Chris Douglas (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/HADOOP-4176?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12632044#action_12632044 ] 

Chris Douglas commented on HADOOP-4176:
---------------------------------------

This looks good. Only a couple minor suggestions in DFSClient:
* Since callGetBlockLocations is private, there's no compatibility issue and its signature can be changed and all the calls updated instead of redirecting again.
* In the javadoc for getFileChecksum, {{@see}} is more standard than "Similar to..."

Would you expect the load on the namenode to be significant for large numbers of checksum requests? Might it make sense to redirect this request to a datanode that can compute and return the checksum?

> Implement getFileChecksum(Path) in HftpFileSystem
> -------------------------------------------------
>
>                 Key: HADOOP-4176
>                 URL: https://issues.apache.org/jira/browse/HADOOP-4176
>             Project: Hadoop Core
>          Issue Type: New Feature
>          Components: dfs, tools/distcp
>            Reporter: Tsz Wo (Nicholas), SZE
>            Assignee: Tsz Wo (Nicholas), SZE
>             Fix For: 0.19.0
>
>         Attachments: 4176_20080917.patch
>
>
> In order to use FileChecksum in DistCp, we should implement getFileChecksum(Path) in HftpFileSystem

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.