You are viewing a plain text version of this content. The canonical link for it is here.

Posted to dev@ranger.apache.org by Madhan Neethiraj <ma...@apache.org> on 2022/05/27 00:00:09 UTC

Review Request 74002: RANGER-3779: conditions enhancement to support macros IS_IN_ANY_GROUP, IS_IN_ANY_ROLE, HAS_TAGS

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/74002/
-----------------------------------------------------------

Review request for ranger, Abhishek  Kumar, Ankita Sinha, Kishor Gollapalliwar, Abhay Kulkarni, Mehul Parikh, Pradeep Agrawal, Ramesh Mani, Sailaja Polavarapu, and Velmurugan Periasamy.


Bugs: RANGER-3779
    https://issues.apache.org/jira/browse/RANGER-3779


Repository: ranger


Description
-------

updated conditions evaluator to support following macros:
- IS_IN_ANY_GROUP
- IS_NOT_IN_ANY_GROUP
- IS_IN_ANY_ROLE
- IS_NOT_IN_ANY_ROLE
- HAS_ANY_TAG
- HAS_NO_TAG


Diffs
-----

  agents-common/src/main/java/org/apache/ranger/plugin/policyengine/RangerRequestScriptEvaluator.java f9b01b632 
  agents-common/src/main/java/org/apache/ranger/plugin/util/RangerCommonConstants.java a372ea019 
  agents-common/src/test/java/org/apache/ranger/plugin/conditionevaluator/RangerRequestScriptEvaluatorTest.java 97b92ef78 


Diff: https://reviews.apache.org/r/74002/diff/1/


Testing
-------

- added unit tests to cover new macros
- verified that existing tests pass successfully


Thanks,

Madhan Neethiraj

Re: Review Request 74002: RANGER-3779: conditions enhancement to support macros IS_IN_ANY_GROUP, IS_IN_ANY_ROLE, HAS_TAGS

Posted by Madhan Neethiraj <ma...@apache.org>.

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/74002/#review224476
-----------------------------------------------------------



Reminder to review this patch. Thanks!

- Madhan Neethiraj


On May 27, 2022, midnight, Madhan Neethiraj wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/74002/
> -----------------------------------------------------------
> 
> (Updated May 27, 2022, midnight)
> 
> 
> Review request for ranger, Abhishek  Kumar, Ankita Sinha, Kishor Gollapalliwar, Abhay Kulkarni, Mehul Parikh, Pradeep Agrawal, Ramesh Mani, Sailaja Polavarapu, and Velmurugan Periasamy.
> 
> 
> Bugs: RANGER-3779
>     https://issues.apache.org/jira/browse/RANGER-3779
> 
> 
> Repository: ranger
> 
> 
> Description
> -------
> 
> updated conditions evaluator to support following macros:
> - IS_IN_ANY_GROUP
> - IS_NOT_IN_ANY_GROUP
> - IS_IN_ANY_ROLE
> - IS_NOT_IN_ANY_ROLE
> - HAS_ANY_TAG
> - HAS_NO_TAG
> 
> 
> Diffs
> -----
> 
>   agents-common/src/main/java/org/apache/ranger/plugin/policyengine/RangerRequestScriptEvaluator.java f9b01b632 
>   agents-common/src/main/java/org/apache/ranger/plugin/util/RangerCommonConstants.java a372ea019 
>   agents-common/src/test/java/org/apache/ranger/plugin/conditionevaluator/RangerRequestScriptEvaluatorTest.java 97b92ef78 
> 
> 
> Diff: https://reviews.apache.org/r/74002/diff/1/
> 
> 
> Testing
> -------
> 
> - added unit tests to cover new macros
> - verified that existing tests pass successfully
> 
> 
> Thanks,
> 
> Madhan Neethiraj
> 
>

Re: Review Request 74002: RANGER-3779: conditions enhancement to support macros IS_IN_ANY_GROUP, IS_IN_ANY_ROLE, HAS_TAGS

Posted by Abhay Kulkarni <ak...@hortonworks.com>.

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/74002/#review224478
-----------------------------------------------------------


Ship it!




Ship It!

- Abhay Kulkarni


On May 27, 2022, midnight, Madhan Neethiraj wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/74002/
> -----------------------------------------------------------
> 
> (Updated May 27, 2022, midnight)
> 
> 
> Review request for ranger, Abhishek  Kumar, Ankita Sinha, Kishor Gollapalliwar, Abhay Kulkarni, Mehul Parikh, Pradeep Agrawal, Ramesh Mani, Sailaja Polavarapu, and Velmurugan Periasamy.
> 
> 
> Bugs: RANGER-3779
>     https://issues.apache.org/jira/browse/RANGER-3779
> 
> 
> Repository: ranger
> 
> 
> Description
> -------
> 
> updated conditions evaluator to support following macros:
> - IS_IN_ANY_GROUP
> - IS_NOT_IN_ANY_GROUP
> - IS_IN_ANY_ROLE
> - IS_NOT_IN_ANY_ROLE
> - HAS_ANY_TAG
> - HAS_NO_TAG
> 
> 
> Diffs
> -----
> 
>   agents-common/src/main/java/org/apache/ranger/plugin/policyengine/RangerRequestScriptEvaluator.java f9b01b632 
>   agents-common/src/main/java/org/apache/ranger/plugin/util/RangerCommonConstants.java a372ea019 
>   agents-common/src/test/java/org/apache/ranger/plugin/conditionevaluator/RangerRequestScriptEvaluatorTest.java 97b92ef78 
> 
> 
> Diff: https://reviews.apache.org/r/74002/diff/1/
> 
> 
> Testing
> -------
> 
> - added unit tests to cover new macros
> - verified that existing tests pass successfully
> 
> 
> Thanks,
> 
> Madhan Neethiraj
> 
>

Re: Review Request 74002: RANGER-3779: conditions enhancement to support macros IS_IN_ANY_GROUP, IS_IN_ANY_ROLE, HAS_TAGS

Posted by Abhishek Kumar <ab...@gmail.com>.

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/74002/#review224477
-----------------------------------------------------------


Ship it!




Ship It!

- Abhishek  Kumar


On May 27, 2022, midnight, Madhan Neethiraj wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/74002/
> -----------------------------------------------------------
> 
> (Updated May 27, 2022, midnight)
> 
> 
> Review request for ranger, Abhishek  Kumar, Ankita Sinha, Kishor Gollapalliwar, Abhay Kulkarni, Mehul Parikh, Pradeep Agrawal, Ramesh Mani, Sailaja Polavarapu, and Velmurugan Periasamy.
> 
> 
> Bugs: RANGER-3779
>     https://issues.apache.org/jira/browse/RANGER-3779
> 
> 
> Repository: ranger
> 
> 
> Description
> -------
> 
> updated conditions evaluator to support following macros:
> - IS_IN_ANY_GROUP
> - IS_NOT_IN_ANY_GROUP
> - IS_IN_ANY_ROLE
> - IS_NOT_IN_ANY_ROLE
> - HAS_ANY_TAG
> - HAS_NO_TAG
> 
> 
> Diffs
> -----
> 
>   agents-common/src/main/java/org/apache/ranger/plugin/policyengine/RangerRequestScriptEvaluator.java f9b01b632 
>   agents-common/src/main/java/org/apache/ranger/plugin/util/RangerCommonConstants.java a372ea019 
>   agents-common/src/test/java/org/apache/ranger/plugin/conditionevaluator/RangerRequestScriptEvaluatorTest.java 97b92ef78 
> 
> 
> Diff: https://reviews.apache.org/r/74002/diff/1/
> 
> 
> Testing
> -------
> 
> - added unit tests to cover new macros
> - verified that existing tests pass successfully
> 
> 
> Thanks,
> 
> Madhan Neethiraj
> 
>