You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@cloudstack.apache.org by Harikrishna Patnala <ha...@citrix.com> on 2013/06/12 09:12:06 UTC

Review Request: fix for CLOUDSTACK-2347: Zone filter for listSnapshots API

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/11820/
-----------------------------------------------------------

Review request for cloudstack, Abhinandan Prateek, Nitin Mehta, and Koushik Das.


Description
-------

CLOUDSTACK-2347:  Zone filter for listSnapshots API 

Added new optional parameter zone id in listSnapshots API which allows to list snapshots with additional criteria.


This addresses bug CLOUDSTACK-2347.


Diffs
-----

  api/src/org/apache/cloudstack/api/command/user/snapshot/ListSnapshotsCmd.java d7e6bc8 
  api/src/org/apache/cloudstack/api/response/SnapshotResponse.java 7484ac9 
  server/src/com/cloud/api/ApiResponseHelper.java 0c98abc 
  server/src/com/cloud/storage/snapshot/SnapshotManagerImpl.java 92d80ee 

Diff: https://reviews.apache.org/r/11820/diff/


Testing
-------

Tested locally


Thanks,

Harikrishna Patnala


Re: Review Request: fix for CLOUDSTACK-2347: Zone filter for listSnapshots API

Posted by Nitin Mehta <ni...@citrix.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/11820/#review21783
-----------------------------------------------------------

Ship it!


Ship It!

- Nitin Mehta


On June 12, 2013, 7:12 a.m., Harikrishna Patnala wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/11820/
> -----------------------------------------------------------
> 
> (Updated June 12, 2013, 7:12 a.m.)
> 
> 
> Review request for cloudstack, Abhinandan Prateek, Nitin Mehta, and Koushik Das.
> 
> 
> Description
> -------
> 
> CLOUDSTACK-2347:  Zone filter for listSnapshots API 
> 
> Added new optional parameter zone id in listSnapshots API which allows to list snapshots with additional criteria.
> 
> 
> This addresses bug CLOUDSTACK-2347.
> 
> 
> Diffs
> -----
> 
>   api/src/org/apache/cloudstack/api/command/user/snapshot/ListSnapshotsCmd.java d7e6bc8 
>   api/src/org/apache/cloudstack/api/response/SnapshotResponse.java 7484ac9 
>   server/src/com/cloud/api/ApiResponseHelper.java 0c98abc 
>   server/src/com/cloud/storage/snapshot/SnapshotManagerImpl.java 92d80ee 
> 
> Diff: https://reviews.apache.org/r/11820/diff/
> 
> 
> Testing
> -------
> 
> Tested locally
> 
> 
> Thanks,
> 
> Harikrishna Patnala
> 
>


Re: Review Request: fix for CLOUDSTACK-2347: Zone filter for listSnapshots API

Posted by ASF Subversion and Git Services <as...@urd.zones.apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/11820/#review21784
-----------------------------------------------------------


Commit 215b638e8eb22fd433ebdc396d4b7a38b0f6796a in branch refs/heads/master from Harikrishna Patnala
[ https://git-wip-us.apache.org/repos/asf?p=cloudstack.git;h=215b638 ]

CLOUDSTACK-2347:  Zone filter for listSnapshots API

Added new optional parameter zone id in listSnapshots API which allows to list snapshots with additional criteria.
   Signed off by :- Nitin Mehta <ni...@citrix.com>


- ASF Subversion and Git Services


On June 12, 2013, 7:12 a.m., Harikrishna Patnala wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/11820/
> -----------------------------------------------------------
> 
> (Updated June 12, 2013, 7:12 a.m.)
> 
> 
> Review request for cloudstack, Abhinandan Prateek, Nitin Mehta, and Koushik Das.
> 
> 
> Description
> -------
> 
> CLOUDSTACK-2347:  Zone filter for listSnapshots API 
> 
> Added new optional parameter zone id in listSnapshots API which allows to list snapshots with additional criteria.
> 
> 
> This addresses bug CLOUDSTACK-2347.
> 
> 
> Diffs
> -----
> 
>   api/src/org/apache/cloudstack/api/command/user/snapshot/ListSnapshotsCmd.java d7e6bc8 
>   api/src/org/apache/cloudstack/api/response/SnapshotResponse.java 7484ac9 
>   server/src/com/cloud/api/ApiResponseHelper.java 0c98abc 
>   server/src/com/cloud/storage/snapshot/SnapshotManagerImpl.java 92d80ee 
> 
> Diff: https://reviews.apache.org/r/11820/diff/
> 
> 
> Testing
> -------
> 
> Tested locally
> 
> 
> Thanks,
> 
> Harikrishna Patnala
> 
>