[GitHub] [rocketmq-client-go] francisoliverlee commented on a diff in pull request #1000: [ISSUE #999]support admin topicList and groupList method

["francisoliverlee (via GitHub)" <gi...@apache.org>]

francisoliverlee commented on code in PR #1000:
URL: https://github.com/apache/rocketmq-client-go/pull/1000#discussion_r1105236994


##########
admin/admin.go:
##########
@@ -34,7 +34,8 @@ type Admin interface {
 	CreateTopic(ctx context.Context, opts ...OptionCreate) error
 	DeleteTopic(ctx context.Context, opts ...OptionDelete) error
 	//TODO
-	//TopicList(ctx context.Context, mq *primitive.MessageQueue) (*remote.RemotingCommand, error)
+	GroupList(ctx context.Context, brokerAddr string) (*remote.RemotingCommand, error)
+	TopicList(ctx context.Context) (*remote.RemotingCommand, error)

Review Comment:
   实现最好和java保持一致。
   1. 方法名GroupList 对应 getAllSubscriptionGroupadmin；TopicList 对应 fetchAllTopicList
   3. 通信层返回的RemotingCommand，admin这一层的返回值建议做成明确的struct



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@rocketmq.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org