[GitHub] [maven-shade-plugin] rmannibucau commented on pull request #59: MSHADE-373: adds a property to skip manifest transformer application when transforming a source file.

[GitBox <gi...@apache.org>]

rmannibucau commented on pull request #59:
URL: https://github.com/apache/maven-shade-plugin/pull/59#issuecomment-652953635


   Hi @raphw ,
   
   I wonder if it wouldn't be more consistent and correct to handle it at transformer level.
   We already started to work to support OSGi relocation (org.apache.maven.plugins.shade.resource.ManifestResourceTransformer#defaultAttributes) so I guess it is the thing to enhance instead of adding a global property which only works in association with some transformer setup anyway.
   
   So here is how I'm seeing it:
   
   1. you want to keep the bnd manifest -> you don't set manifest transformer
   2. you want a new custom manifest (jars must have one anyway) -> you set manifest transformer with a custom entries configuration. In this case the change is about exposing manifestDiscovered with a setter to let it be configured in the transformer (setSkipManifest(boolean v) {manifestDiscovered=v;})
   
   Does it makes sense for your case?
   
   
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org