[GitHub] raphinesse commented on issue #12: Use const whenever possible

[GitBox <gi...@apache.org>]

raphinesse commented on issue #12: Use const whenever possible
URL: https://github.com/apache/cordova/issues/12#issuecomment-421402055
 
 
   Yup, I've been doing that as I go. I just haven't felt it was important enough to be tackled just for the sake of it. Consider that it will create quite some diff noise and probably merge conflicts for any open PRs.
   
   That being said, there's a tool that does these transformations for you: https://lebab.io/. Last time I checked it was a bit overzealous with the arrow functions, resulting in bad code layout. And some transformed choked on our license header. So *if* we do this, it might be worth considering throwing something like `prettier` at the code to format it uniformly (and make sure we make `git blame` completely useless). @janpio Would love to do that, I hear :wink:
   
   Of course, for `var` to `const` simple search and replace should work too. Then step through linter errors and change these all to let. Probably gets you 99% there with the minimal impact.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@cordova.apache.org
For additional commands, e-mail: commits-help@cordova.apache.org