You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@zookeeper.apache.org by "Jackie Chang (JIRA)" <ji...@apache.org> on 2013/09/26 06:28:04 UTC
[jira] [Updated] (ZOOKEEPER-1766) Consistent log severity level
guards and statements
[ https://issues.apache.org/jira/browse/ZOOKEEPER-1766?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Jackie Chang updated ZOOKEEPER-1766:
------------------------------------
Attachment: ZOOKEEPER-1766.patch
Proposed patch against trunk
> Consistent log severity level guards and statements
> ---------------------------------------------------
>
> Key: ZOOKEEPER-1766
> URL: https://issues.apache.org/jira/browse/ZOOKEEPER-1766
> Project: ZooKeeper
> Issue Type: Improvement
> Reporter: Jackie Chang
> Attachments: ZOOKEEPER-1766.patch
>
>
> A log statement should be guarded by its matching severity level. A log statement like
> if (LOG.isTraceEnabled()) {
> LOG.debug(identifier + " opening connection to ZooKeeper ensemble=" + ensemble);
> doesn't make much sense because the log message is only printed out when TRACE-level is enabled. This inconsistency was possibly introduced when developers demoted the original log statement from DEBUG but forgot to change its corresponding log severity level.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira