You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@ranger.apache.org by Mahesh Bandal <ma...@gmail.com> on 2025/09/09 16:56:07 UTC

Review Request 75406: RANGER-5294: FileUtils.isOwnerOfFileHierarchy doesn’t have the recurse parameter

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/75406/
-----------------------------------------------------------

Review request for ranger, Ankita Sinha, Dhaval Shah, Dineshkumar Yadav, Gautam Borad, Kishor Gollapalliwar, Abhay Kulkarni, Madhan Neethiraj, Mehul Parikh, Pradeep Agrawal, Ramesh Mani, Sailaja Polavarapu, and Velmurugan Periasamy.


Bugs: RANGER-5294
    https://issues.apache.org/jira/browse/RANGER-5294


Repository: ranger


Description
-------

Invoke FileUtils.isOwnerOfFileHierarchy() with recurse parameter which can be controlled through an existing config "xasecure.hive.uri.permission.coarse.check". When the values is set to true it will avoid a URL recursive permission check.


Diffs
-----

  hive-agent/src/main/java/org/apache/ranger/authorization/hive/authorizer/RangerHiveAuthorizer.java 8ff5a4219 


Diff: https://reviews.apache.org/r/75406/diff/1/


Testing
-------

build successful with "mvn clean install" command.
Passed all unit tests.
Verified performance improved by 40-50%. ADD PARTITION call with a large number of files under a partition table authorizes faster.


Thanks,

Mahesh Bandal


Re: Review Request 75406: RANGER-5294: FileUtils.isOwnerOfFileHierarchy doesn’t have the recurse parameter

Posted by Dineshkumar Yadav <di...@outlook.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/75406/#review227359
-----------------------------------------------------------


Ship it!




Ship It!

- Dineshkumar Yadav


On Sept. 10, 2025, 6:14 a.m., Mahesh Bandal wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/75406/
> -----------------------------------------------------------
> 
> (Updated Sept. 10, 2025, 6:14 a.m.)
> 
> 
> Review request for ranger, Ankita Sinha, Dhaval Shah, Dineshkumar Yadav, Gautam Borad, Kishor Gollapalliwar, Abhay Kulkarni, Madhan Neethiraj, Mehul Parikh, Pradeep Agrawal, Ramesh Mani, Sailaja Polavarapu, and Velmurugan Periasamy.
> 
> 
> Bugs: RANGER-5294
>     https://issues.apache.org/jira/browse/RANGER-5294
> 
> 
> Repository: ranger
> 
> 
> Description
> -------
> 
> Invoke FileUtils.isOwnerOfFileHierarchy() with recurse parameter which can be controlled through an existing config "xasecure.hive.uri.permission.coarse.check". When the values is set to true it will avoid a URL recursive permission check.
> 
> 
> Diffs
> -----
> 
>   hive-agent/src/main/java/org/apache/ranger/authorization/hive/authorizer/RangerHiveAuthorizer.java 8ff5a4219 
> 
> 
> Diff: https://reviews.apache.org/r/75406/diff/2/
> 
> 
> Testing
> -------
> 
> build successful with "mvn clean install" command.
> Passed all unit tests.
> Verified performance improved by 40-50%. ADD PARTITION call with a large number of files under a partition table authorizes faster.
> 
> 
> Thanks,
> 
> Mahesh Bandal
> 
>


Re: Review Request 75406: RANGER-5294: FileUtils.isOwnerOfFileHierarchy doesn’t have the recurse parameter

Posted by Mahesh Bandal <ma...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/75406/
-----------------------------------------------------------

(Updated Sept. 10, 2025, 6:14 a.m.)


Review request for ranger, Ankita Sinha, Dhaval Shah, Dineshkumar Yadav, Gautam Borad, Kishor Gollapalliwar, Abhay Kulkarni, Madhan Neethiraj, Mehul Parikh, Pradeep Agrawal, Ramesh Mani, Sailaja Polavarapu, and Velmurugan Periasamy.


Changes
-------

Thanks for review. I have addressed review comment.


Bugs: RANGER-5294
    https://issues.apache.org/jira/browse/RANGER-5294


Repository: ranger


Description
-------

Invoke FileUtils.isOwnerOfFileHierarchy() with recurse parameter which can be controlled through an existing config "xasecure.hive.uri.permission.coarse.check". When the values is set to true it will avoid a URL recursive permission check.


Diffs (updated)
-----

  hive-agent/src/main/java/org/apache/ranger/authorization/hive/authorizer/RangerHiveAuthorizer.java 8ff5a4219 


Diff: https://reviews.apache.org/r/75406/diff/2/

Changes: https://reviews.apache.org/r/75406/diff/1-2/


Testing
-------

build successful with "mvn clean install" command.
Passed all unit tests.
Verified performance improved by 40-50%. ADD PARTITION call with a large number of files under a partition table authorizes faster.


Thanks,

Mahesh Bandal