You are viewing a plain text version of this content. The canonical link for it is here.

Posted to commits@airflow.apache.org by GitBox <gi...@apache.org> on 2022/05/19 15:20:42 UTC

[GitHub] [airflow] ashb commented on a diff in pull request #23797: Add TaskInstance State 'REMOVED' to finished states and success states

ashb commented on code in PR #23797:
URL: https://github.com/apache/airflow/pull/23797#discussion_r877203870


##########
airflow/utils/state.py:
##########
@@ -192,7 +193,7 @@ def color_fg(cls, state):
     """
 
     success_states: FrozenSet[TaskInstanceState] = frozenset(
-        [TaskInstanceState.SUCCESS, TaskInstanceState.SKIPPED]
+        [TaskInstanceState.SUCCESS, TaskInstanceState.SKIPPED, TaskInstanceState.REMOVED]

Review Comment:
   This one I'm not so sure of. Adding it to finished states seems fine, but this one feels like it's asking for trouble.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org