You are viewing a plain text version of this content. The canonical link for it is here.

Posted to commits@hudi.apache.org by "danny0405 (via GitHub)" <gi...@apache.org> on 2023/02/08 03:25:48 UTC

[GitHub] [hudi] danny0405 commented on pull request #6121: [HUDI-4406] Support Flink compaction commit write error resolvement to avoid data loss

danny0405 commented on PR #6121:
URL: https://github.com/apache/hudi/pull/6121#issuecomment-1421938531

   > @danny0405 @yuzhaojing could you help review this pr? It has been here for a long time.
   > 
   > Its purpose is clear that we should include errors/exceptions wrapped in compaction write status into rollback policies.
   > 
   > Otherwise, it will still be committed even if this compaction has met with some data loss exceptions.
   
   I see there are so many code refactoring in the patch, can we have a quick fix in `CompactionCommitSink` and left the refactoring to maybe another PR?


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org