You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@flume.apache.org by Mike Percy <mp...@gmail.com> on 2012/03/30 02:54:39 UTC
Review Request: FLUME-1073: Default shipping log4j config to rolling file
appender
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/4565/
-----------------------------------------------------------
Review request for Flume.
Summary
-------
Simple patch to default to a reasonably-configured rolling file appender.
This addresses bug FLUME-1073.
https://issues.apache.org/jira/browse/FLUME-1073
Diffs
-----
conf/log4j.properties 3dcffd4
Diff: https://reviews.apache.org/r/4565/diff
Testing
-------
Did some manual testing, looks fine to me.
Thanks,
Mike
Re: Review Request: FLUME-1073: Default shipping log4j config to rolling
file appender
Posted by Arvind Prabhakar <ar...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/4565/#review6612
-----------------------------------------------------------
Ship it!
+1.
Thanks for the patch Mike. Please attach the patch to the Jira.
- Arvind
On 2012-03-30 21:38:31, Mike Percy wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/4565/
> -----------------------------------------------------------
>
> (Updated 2012-03-30 21:38:31)
>
>
> Review request for Flume.
>
>
> Summary
> -------
>
> Simple patch to default to a reasonably-configured rolling file appender.
>
>
> This addresses bug FLUME-1073.
> https://issues.apache.org/jira/browse/FLUME-1073
>
>
> Diffs
> -----
>
> bin/flume-ng a31f171
> conf/log4j.properties 3dcffd4
>
> Diff: https://reviews.apache.org/r/4565/diff
>
>
> Testing
> -------
>
> Did some manual testing, looks fine to me.
>
>
> Thanks,
>
> Mike
>
>
Re: Review Request: FLUME-1073: Default shipping log4j config to rolling
file appender
Posted by Mike Percy <mp...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/4565/
-----------------------------------------------------------
(Updated 2012-03-30 21:38:31.640395)
Review request for Flume.
Changes
-------
Updated patch so that we can now specify -Dflume.root.logger=DEBUG,console when invoking Flume on the command line, which overrides the log4j.rootLogger. I think that's a reasonable thing to ask of developers. At the same time, "out of the box", Flume has logging that is sane for a production environment.
Summary
-------
Simple patch to default to a reasonably-configured rolling file appender.
This addresses bug FLUME-1073.
https://issues.apache.org/jira/browse/FLUME-1073
Diffs (updated)
-----
bin/flume-ng a31f171
conf/log4j.properties 3dcffd4
Diff: https://reviews.apache.org/r/4565/diff
Testing
-------
Did some manual testing, looks fine to me.
Thanks,
Mike
Re: Review Request: FLUME-1073: Default shipping log4j config to rolling
file appender
Posted by Arvind Prabhakar <ar...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/4565/#review6561
-----------------------------------------------------------
Ship it!
+1. Please attach the patch to the Jira.
nit: we should add the console appender as well since up until now the output was visible on the console only.
- Arvind
On 2012-03-30 00:54:39, Mike Percy wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/4565/
> -----------------------------------------------------------
>
> (Updated 2012-03-30 00:54:39)
>
>
> Review request for Flume.
>
>
> Summary
> -------
>
> Simple patch to default to a reasonably-configured rolling file appender.
>
>
> This addresses bug FLUME-1073.
> https://issues.apache.org/jira/browse/FLUME-1073
>
>
> Diffs
> -----
>
> conf/log4j.properties 3dcffd4
>
> Diff: https://reviews.apache.org/r/4565/diff
>
>
> Testing
> -------
>
> Did some manual testing, looks fine to me.
>
>
> Thanks,
>
> Mike
>
>