You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@flink.apache.org by "ASF GitHub Bot (JIRA)" <ji...@apache.org> on 2016/02/01 15:39:40 UTC
[jira] [Commented] (FLINK-3254) CombineFunction interface not
respected
[ https://issues.apache.org/jira/browse/FLINK-3254?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15126309#comment-15126309 ]
ASF GitHub Bot commented on FLINK-3254:
---------------------------------------
GitHub user kl0u opened a pull request:
https://github.com/apache/flink/pull/1568
FLINK-3254: Adding functionality to support the CombineFunction contract.
Solves ISSUE-3254: now a function that implements the GroupReduceFunction and the CombineFunction interfaces will be executed with a combiner. Before, this was the case only if the function was implementing the GroupReduceFunction and the GroupCombineFunction interfaces.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/kl0u/flink combiner_fix
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/flink/pull/1568.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #1568
----
commit 49aabd959472a49f9803023bbec360fec824db75
Author: Kostas Kloudas <kk...@gmail.com>
Date: 2016-02-01T08:46:00Z
FLINK-3254: Adding functionality to support the CombineFunction contract.
----
> CombineFunction interface not respected
> ---------------------------------------
>
> Key: FLINK-3254
> URL: https://issues.apache.org/jira/browse/FLINK-3254
> Project: Flink
> Issue Type: Bug
> Components: DataSet API
> Affects Versions: 1.0.0, 0.10.1
> Reporter: Fabian Hueske
> Assignee: Kostas
> Priority: Blocker
> Fix For: 1.0.0
>
>
> The DataSet API offers a {{CombineFunction}} interface, which differs from the {{GroupCombineFunction}} interface by being restricted to return a single value instead of returning arbitrary many values through a {{Collector}}.
> The JavaDocs of the {{GroupCombineFunction}} point to the {{CombineFunction}} interface, advertising it as more efficient.
> However, the {{CombineFunction}} interface is nor respected by Flink, i.e., a {{GroupReduceFunction}} that implements this interface is executed without leveraging the combine method.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)