[GitHub] [dolphinscheduler] qingwli commented on a diff in pull request #14349: [Feature][Api] LDAP SSL supports&& Add LDAP K8s configuration

["qingwli (via GitHub)" <gi...@apache.org>]

qingwli commented on code in PR #14349:
URL: https://github.com/apache/dolphinscheduler/pull/14349#discussion_r1230364058


##########
dolphinscheduler-api/src/main/java/org/apache/dolphinscheduler/api/security/impl/ldap/LdapService.java:
##########
@@ -70,6 +70,15 @@ public class LdapService {
     @Value("${security.authentication.ldap.user.not-exist-action:CREATE}")
     private String ldapUserNotExistAction;
 
+    @Value("${security.authentication.ldap.ssl.enable:false}")
+    private Boolean sslEnable;
+
+    @Value("${security.authentication.ldap.ssl.trust-store:#{null}}")
+    private String trustStore;
+
+    @Value("${security.authentication.ldap.ssl.trust-store-password:#{null}}")
+    private String trustStorePassword;

Review Comment:
   Hi, For this part, the default will use the value in `application.yaml` not null, and even these two filed is null and is ok because truestore will use in `String.format("%s/%s", System.getProperty("user.dir"), trustStore)` works well, not throw npe, and for trustStorePassword we have a StringUtils.isNotEmpty check. WDYT?



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@dolphinscheduler.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org