[GitHub] [pinot] gortiz commented on a diff in pull request #10722: Making segment replacement request apis backwards compatible

["gortiz (via GitHub)" <gi...@apache.org>]

gortiz commented on code in PR #10722:
URL: https://github.com/apache/pinot/pull/10722#discussion_r1185739268


##########
pinot-common/src/main/java/org/apache/pinot/common/restlet/resources/EndReplaceSegmentsRequest.java:
##########
@@ -37,6 +37,10 @@ public class EndReplaceSegmentsRequest {
   private final List<String> _segmentsTo;
   private final Map<String, String> _customMap;
 
+  public EndReplaceSegmentsRequest(@Nullable List<String> segmentsTo) {
+    this(segmentsTo, null);
+  }
+
   public EndReplaceSegmentsRequest(@JsonProperty("segmentsTo") @Nullable List<String> segmentsTo,

Review Comment:
   AFAIK we need to add `@JsonCreator` on each class where we have two constructors.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org
For additional commands, e-mail: commits-help@pinot.apache.org