You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@pivot.apache.org by "Sandro Martini (JIRA)" <ji...@apache.org> on 2010/07/23 14:32:49 UTC
[jira] Created: (PIVOT-579) Provide additional Color schemes
Provide additional Color schemes
--------------------------------
Key: PIVOT-579
URL: https://issues.apache.org/jira/browse/PIVOT-579
Project: Pivot
Issue Type: New Feature
Components: wtk-terra
Reporter: Sandro Martini
Assignee: Sandro Martini
Priority: Minor
Fix For: 2.0
Some reference here: http://apache-pivot-developers.417237.n3.nabble.com/Color-schemes-td963453.html#a963453
Create color schemes (json) similar to defaults in the following platforms: Windows XP and Windows 7, Ubuntu 10.04, and if possible also on Max OS X.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (PIVOT-579) Provide additional Color schemes
Posted by "Greg Brown (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/PIVOT-579?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12891592#action_12891592 ]
Greg Brown commented on PIVOT-579:
----------------------------------
> I have to restore a (backupped) version of the Dark colors containing comments to explain each color index where is used in the Terra skin
That information doesn't belong in the scheme descriptor file - it should go in the documentation for the skins themselves.
> for new json files, to simplify its usage, probably they should go inside packages of Terra skin
I think they should probably live in the same package as the existing descriptors (org.apache.pivot.wtk.skin.terra).
> To test the new look of any custom colors file, we have to remove some overrides there (if not all, at least some), in Kitchen Sink bxml files
This shouldn't be much of a problem - most examples use index setters which map directly to the color scheme.
> Provide additional Color schemes
> --------------------------------
>
> Key: PIVOT-579
> URL: https://issues.apache.org/jira/browse/PIVOT-579
> Project: Pivot
> Issue Type: New Feature
> Components: wtk-terra
> Reporter: Sandro Martini
> Assignee: Sandro Martini
> Priority: Minor
> Fix For: 2.0
>
>
> Some reference here: http://apache-pivot-developers.417237.n3.nabble.com/Color-schemes-td963453.html#a963453
> Create color schemes (json) similar to defaults in the following platforms: Windows XP and Windows 7, Ubuntu 10.04, and if possible also on Max OS X.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Closed: (PIVOT-579) Provide additional Color schemes
Posted by "Sandro Martini (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/PIVOT-579?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Sandro Martini closed PIVOT-579.
--------------------------------
resolved, so now closing it.
> Provide additional Color schemes
> --------------------------------
>
> Key: PIVOT-579
> URL: https://issues.apache.org/jira/browse/PIVOT-579
> Project: Pivot
> Issue Type: New Feature
> Components: wtk-terra
> Reporter: Sandro Martini
> Assignee: Sandro Martini
> Priority: Minor
> Fix For: 2.0
>
> Attachments: patch_package.patch, pivot_colorschemebuilder_all_colors_to_black_but_some_parts_not.png, reset_palette_colors_for_ColorSchemeBuilder.patch
>
>
> Some reference here: http://apache-pivot-developers.417237.n3.nabble.com/Color-schemes-td963453.html#a963453
> Create color schemes (json) similar to defaults in the following platforms: Windows XP and Windows 7, Ubuntu 10.04, and if possible also on Max OS X.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (PIVOT-579) Provide additional Color schemes
Posted by "Greg Brown (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/PIVOT-579?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12922149#action_12922149 ]
Greg Brown commented on PIVOT-579:
----------------------------------
> So you means this is a desired effect here ?
Yes, this is by design.
> probably the only unwanted effect here is a small corner portion of the table view
I believe this was because TerraScrollPaneCornerSkin was ignoring the theme colors. It should be fixed now.
> Provide additional Color schemes
> --------------------------------
>
> Key: PIVOT-579
> URL: https://issues.apache.org/jira/browse/PIVOT-579
> Project: Pivot
> Issue Type: New Feature
> Components: wtk-terra
> Reporter: Sandro Martini
> Assignee: Sandro Martini
> Priority: Minor
> Fix For: 2.0
>
> Attachments: patch_package.patch, pivot_colorschemebuilder_all_colors_to_black_but_some_parts_not.png, reset_palette_colors_for_ColorSchemeBuilder.patch
>
>
> Some reference here: http://apache-pivot-developers.417237.n3.nabble.com/Color-schemes-td963453.html#a963453
> Create color schemes (json) similar to defaults in the following platforms: Windows XP and Windows 7, Ubuntu 10.04, and if possible also on Max OS X.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Issue Comment Edited: (PIVOT-579) Provide additional Color
schemes
Posted by "Sandro Martini (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/PIVOT-579?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12895870#action_12895870 ]
Sandro Martini edited comment on PIVOT-579 at 9/21/10 7:13 PM:
---------------------------------------------------------------
Add also a file for Swing colors:
this week I'm planning to add even this file, and check if all my references for colors are still valid (but testing them with ColorSchemeBuilder, and not with the KitchenSink because there some colors are overridden by bxml files).
Last, update the JavaDoc page "package.html" for the Terra package, and write a reference table of where colors are used inside the Skin, to help users in create their custom color combinations.
was (Author: smartini):
Add also a file for Swing colors.
> Provide additional Color schemes
> --------------------------------
>
> Key: PIVOT-579
> URL: https://issues.apache.org/jira/browse/PIVOT-579
> Project: Pivot
> Issue Type: New Feature
> Components: wtk-terra
> Reporter: Sandro Martini
> Assignee: Sandro Martini
> Priority: Minor
> Fix For: 2.0
>
>
> Some reference here: http://apache-pivot-developers.417237.n3.nabble.com/Color-schemes-td963453.html#a963453
> Create color schemes (json) similar to defaults in the following platforms: Windows XP and Windows 7, Ubuntu 10.04, and if possible also on Max OS X.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (PIVOT-579) Provide additional Color schemes
Posted by "Sandro Martini (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/PIVOT-579?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Sandro Martini updated PIVOT-579:
---------------------------------
Attachment: pivot_colorschemebuilder_all_colors_to_black_but_some_parts_not.png
reset_palette_colors_for_ColorSchemeBuilder.patch
Hi, the patch "reset_palette_colors_for_ColorSchemeBuilder.patch" is a little addition to the ColorSchemeBuilder utility, to add a Reset button so after any changes to one or more colors, I can reset the palette to default (at the start of the execution), and it's very useful during experiments on colors.
Probably the two buttons now could have a better spacing (see screenshot), but it's a detail.
Tell me if you like so I can commit.
Note: during my tests I found a strange situation, where all colors have been put to black, but at screen I still see something (icons ok, and even some parts of the table could be ok) but there are other parts that probably are never repainted or are painter with a fixed color and not one from the palette ... comments ? You see the result in the screenshot in attach.
Bye,
Sandro
> Provide additional Color schemes
> --------------------------------
>
> Key: PIVOT-579
> URL: https://issues.apache.org/jira/browse/PIVOT-579
> Project: Pivot
> Issue Type: New Feature
> Components: wtk-terra
> Reporter: Sandro Martini
> Assignee: Sandro Martini
> Priority: Minor
> Fix For: 2.0
>
> Attachments: pivot_colorschemebuilder_all_colors_to_black_but_some_parts_not.png, reset_palette_colors_for_ColorSchemeBuilder.patch
>
>
> Some reference here: http://apache-pivot-developers.417237.n3.nabble.com/Color-schemes-td963453.html#a963453
> Create color schemes (json) similar to defaults in the following platforms: Windows XP and Windows 7, Ubuntu 10.04, and if possible also on Max OS X.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Issue Comment Edited: (PIVOT-579) Provide additional Color
schemes
Posted by "Sandro Martini (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/PIVOT-579?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12918704#action_12918704 ]
Sandro Martini edited comment on PIVOT-579 at 10/6/10 6:08 PM:
---------------------------------------------------------------
Hi, the patch "reset_palette_colors_for_ColorSchemeBuilder.patch" is a little addition to the ColorSchemeBuilder utility, to add a Reset button so after any changes to one or more colors, I can reset the palette to default (at the start of the execution), and it's very useful during experiments on colors.
Probably the two buttons now could have a better spacing (see screenshot), but it's a detail.
Tell me if you like so I can commit.
Note: during my tests I found a strange situation, where all colors have been put to black, but at screen I still see something (icons ok, and even some parts of the table could be ok) but there are other parts that probably are never repainted or are painter with a fixed color and not one from the palette ... comments ?
Sorry, a little clarification: even the part on the left (and on top, on the right upper side) keep a non-black color as a background ... it is right ?
You see the result in the screenshot in attach.
Bye,
Sandro
was (Author: smartini):
Hi, the patch "reset_palette_colors_for_ColorSchemeBuilder.patch" is a little addition to the ColorSchemeBuilder utility, to add a Reset button so after any changes to one or more colors, I can reset the palette to default (at the start of the execution), and it's very useful during experiments on colors.
Probably the two buttons now could have a better spacing (see screenshot), but it's a detail.
Tell me if you like so I can commit.
Note: during my tests I found a strange situation, where all colors have been put to black, but at screen I still see something (icons ok, and even some parts of the table could be ok) but there are other parts that probably are never repainted or are painter with a fixed color and not one from the palette ... comments ? You see the result in the screenshot in attach.
Bye,
Sandro
> Provide additional Color schemes
> --------------------------------
>
> Key: PIVOT-579
> URL: https://issues.apache.org/jira/browse/PIVOT-579
> Project: Pivot
> Issue Type: New Feature
> Components: wtk-terra
> Reporter: Sandro Martini
> Assignee: Sandro Martini
> Priority: Minor
> Fix For: 2.0
>
> Attachments: pivot_colorschemebuilder_all_colors_to_black_but_some_parts_not.png, reset_palette_colors_for_ColorSchemeBuilder.patch
>
>
> Some reference here: http://apache-pivot-developers.417237.n3.nabble.com/Color-schemes-td963453.html#a963453
> Create color schemes (json) similar to defaults in the following platforms: Windows XP and Windows 7, Ubuntu 10.04, and if possible also on Max OS X.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (PIVOT-579) Provide additional Color schemes
Posted by "Sandro Martini (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/PIVOT-579?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12922136#action_12922136 ]
Sandro Martini commented on PIVOT-579:
--------------------------------------
Hi Greg,
> Only the example components are affected by the color changes - the spinners, etc. are not (so you can change the values without making the app unusable).
So you means this is a desired effect here ?
If yes, I agree with you (it's a good behavior in this case) ...
So probably the only unwanted effect here is a small corner portion of the table view (small gray rectangle at the center of the screenshot). If confirmed, I could open a dedicated jira ticket for it.
Sandro
> Provide additional Color schemes
> --------------------------------
>
> Key: PIVOT-579
> URL: https://issues.apache.org/jira/browse/PIVOT-579
> Project: Pivot
> Issue Type: New Feature
> Components: wtk-terra
> Reporter: Sandro Martini
> Assignee: Sandro Martini
> Priority: Minor
> Fix For: 2.0
>
> Attachments: patch_package.patch, pivot_colorschemebuilder_all_colors_to_black_but_some_parts_not.png, reset_palette_colors_for_ColorSchemeBuilder.patch
>
>
> Some reference here: http://apache-pivot-developers.417237.n3.nabble.com/Color-schemes-td963453.html#a963453
> Create color schemes (json) similar to defaults in the following platforms: Windows XP and Windows 7, Ubuntu 10.04, and if possible also on Max OS X.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (PIVOT-579) Provide additional Color schemes
Posted by "Sandro Martini (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/PIVOT-579?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12895870#action_12895870 ]
Sandro Martini commented on PIVOT-579:
--------------------------------------
Add also a file for Swing colors.
> Provide additional Color schemes
> --------------------------------
>
> Key: PIVOT-579
> URL: https://issues.apache.org/jira/browse/PIVOT-579
> Project: Pivot
> Issue Type: New Feature
> Components: wtk-terra
> Reporter: Sandro Martini
> Assignee: Sandro Martini
> Priority: Minor
> Fix For: 2.0
>
>
> Some reference here: http://apache-pivot-developers.417237.n3.nabble.com/Color-schemes-td963453.html#a963453
> Create color schemes (json) similar to defaults in the following platforms: Windows XP and Windows 7, Ubuntu 10.04, and if possible also on Max OS X.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (PIVOT-579) Provide additional Color schemes
Posted by "Greg Brown (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/PIVOT-579?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12921319#action_12921319 ]
Greg Brown commented on PIVOT-579:
----------------------------------
Hi Sandro,
Just noticed your comment about the "all black" test. Only the example components are affected by the color changes - the spinners, etc. are not (so you can change the values without making the app unusable).
G
> Provide additional Color schemes
> --------------------------------
>
> Key: PIVOT-579
> URL: https://issues.apache.org/jira/browse/PIVOT-579
> Project: Pivot
> Issue Type: New Feature
> Components: wtk-terra
> Reporter: Sandro Martini
> Assignee: Sandro Martini
> Priority: Minor
> Fix For: 2.0
>
> Attachments: patch_package.patch, pivot_colorschemebuilder_all_colors_to_black_but_some_parts_not.png, reset_palette_colors_for_ColorSchemeBuilder.patch
>
>
> Some reference here: http://apache-pivot-developers.417237.n3.nabble.com/Color-schemes-td963453.html#a963453
> Create color schemes (json) similar to defaults in the following platforms: Windows XP and Windows 7, Ubuntu 10.04, and if possible also on Max OS X.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (PIVOT-579) Provide additional Color schemes
Posted by "Sandro Martini (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/PIVOT-579?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12891590#action_12891590 ]
Sandro Martini commented on PIVOT-579:
--------------------------------------
I have to restore a (backupped) version of the Dark colors containing comments to explain each color index where is used in the Terra skin, because this could be very useful to anyone wants to make a similar thing (last year when I've done this I had to check Pivot code many hours to understand this).
So this could become a template for users, but in this case probably should be moved / copied inside the skin packages (for example the TerraTheme_dark.json now is in tutorials) ... we have to see what to do here.
And for new json files, to simplify its usage, probably they should go inside packages of Terra skin, and if possible in a user-friendly package.
To test the new look of any custom colors file, we have to remove some overrides there (if not all, at least some), in Kitchen Sink bxml files, to see "standard colors" of any component.
And verify with the Component Explorer, if I can reload colors without restarting the application, but I think it will not be possible at the moment.
> Provide additional Color schemes
> --------------------------------
>
> Key: PIVOT-579
> URL: https://issues.apache.org/jira/browse/PIVOT-579
> Project: Pivot
> Issue Type: New Feature
> Components: wtk-terra
> Reporter: Sandro Martini
> Assignee: Sandro Martini
> Priority: Minor
> Fix For: 2.0
>
>
> Some reference here: http://apache-pivot-developers.417237.n3.nabble.com/Color-schemes-td963453.html#a963453
> Create color schemes (json) similar to defaults in the following platforms: Windows XP and Windows 7, Ubuntu 10.04, and if possible also on Max OS X.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (PIVOT-579) Provide additional Color schemes
Posted by "Sandro Martini (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/PIVOT-579?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Sandro Martini updated PIVOT-579:
---------------------------------
Attachment: patch_package.patch
add some documentation in the Terra package JavaDoc file
> Provide additional Color schemes
> --------------------------------
>
> Key: PIVOT-579
> URL: https://issues.apache.org/jira/browse/PIVOT-579
> Project: Pivot
> Issue Type: New Feature
> Components: wtk-terra
> Reporter: Sandro Martini
> Assignee: Sandro Martini
> Priority: Minor
> Fix For: 2.0
>
> Attachments: patch_package.patch, pivot_colorschemebuilder_all_colors_to_black_but_some_parts_not.png, reset_palette_colors_for_ColorSchemeBuilder.patch
>
>
> Some reference here: http://apache-pivot-developers.417237.n3.nabble.com/Color-schemes-td963453.html#a963453
> Create color schemes (json) similar to defaults in the following platforms: Windows XP and Windows 7, Ubuntu 10.04, and if possible also on Max OS X.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Resolved: (PIVOT-579) Provide additional Color schemes
Posted by "Sandro Martini (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/PIVOT-579?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Sandro Martini resolved PIVOT-579.
----------------------------------
Resolution: Fixed
added some documentation in the Terra package JavaDoc file on color palette usage in the Terra Skin, to help anyone wants to write their custom colors.
TerraScrollPaneCornerSkin is fixed now ... many thanks to Greg for this.
Sandro
> Provide additional Color schemes
> --------------------------------
>
> Key: PIVOT-579
> URL: https://issues.apache.org/jira/browse/PIVOT-579
> Project: Pivot
> Issue Type: New Feature
> Components: wtk-terra
> Reporter: Sandro Martini
> Assignee: Sandro Martini
> Priority: Minor
> Fix For: 2.0
>
> Attachments: patch_package.patch, pivot_colorschemebuilder_all_colors_to_black_but_some_parts_not.png, reset_palette_colors_for_ColorSchemeBuilder.patch
>
>
> Some reference here: http://apache-pivot-developers.417237.n3.nabble.com/Color-schemes-td963453.html#a963453
> Create color schemes (json) similar to defaults in the following platforms: Windows XP and Windows 7, Ubuntu 10.04, and if possible also on Max OS X.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.