You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@airflow.apache.org by GitBox <gi...@apache.org> on 2019/01/21 15:51:21 UTC
[GitHub] eladkal opened a new pull request #4566: [AIRFLOW-3566] - Adding
timeout and login_timeout to MsSqlHook
eladkal opened a new pull request #4566: [AIRFLOW-3566] - Adding timeout and login_timeout to MsSqlHook
URL: https://github.com/apache/airflow/pull/4566
### Jira
- [ ] My PR addresses the following [Airflow Jira](https://issues.apache.org/jira/browse/AIRFLOW-3566) issues and references them in the PR title. For example, "\[AIRFLOW-XXX\] My Airflow PR"
- https://issues.apache.org/jira/browse/AIRFLOW-3566
- In case you are fixing a typo in the documentation you can prepend your commit with \[AIRFLOW-XXX\], code changes always need a Jira issue.
### Description
Adding timeout and login_timeout properties.
timeout - property of the query (query timeout in seconds).
login_timeout - property of connection (timeout for connection) allowing it to be set from Connection and overwrite in the hook.
Default values (preserve backwards comparability):
timeout default value is 0 (no timeout)
login_timeout default value is 60
### Code Quality
- [V] Passes `flake8`
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services