You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@iceberg.apache.org by GitBox <gi...@apache.org> on 2022/07/14 02:30:20 UTC
[GitHub] [iceberg] huaxingao opened a new pull request, #5274: only log error message(not the stack trace) if filter conversion/bind expression fail
huaxingao opened a new pull request, #5274:
URL: https://github.com/apache/iceberg/pull/5274
This is a follow up to https://github.com/apache/iceberg/pull/5254. When filter conversion/bind expression fail, we will only log the error message instead of the whole stack trace.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org
[GitHub] [iceberg] huaxingao commented on pull request #5274: only log error message(not the stack trace) if filter conversion/bind expression fail
Posted by GitBox <gi...@apache.org>.
huaxingao commented on PR #5274:
URL: https://github.com/apache/iceberg/pull/5274#issuecomment-1185791575
Thank you all very much! @szehon-ho @kbendick @bryanck
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org
[GitHub] [iceberg] szehon-ho commented on a diff in pull request #5274: only log error message(not the stack trace) if filter conversion/bind expression fail
Posted by GitBox <gi...@apache.org>.
szehon-ho commented on code in PR #5274:
URL: https://github.com/apache/iceberg/pull/5274#discussion_r921352165
##########
spark/v3.2/spark/src/main/java/org/apache/iceberg/spark/source/SparkScanBuilder.java:
##########
@@ -108,8 +108,8 @@ public Filter[] pushFilters(Filter[] filters) {
expr = SparkFilters.convert(filter);
} catch (IllegalArgumentException e) {
// converting to Iceberg Expression failed, so this expression cannot be pushed down
- LOG.warn("Failed to convert filter to Iceberg expression, skipping push down for this expression: {}",
- filter, e);
+ LOG.info("Failed to convert filter to Iceberg expression, skipping push down for this expression: {}.{}",
Review Comment:
Nit, could you add one space between the two {}, so that it's not jumbled into one word?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org
[GitHub] [iceberg] huaxingao commented on pull request #5274: only log error message(not the stack trace) if filter conversion/bind expression fail
Posted by GitBox <gi...@apache.org>.
huaxingao commented on PR #5274:
URL: https://github.com/apache/iceberg/pull/5274#issuecomment-1183961021
cc @szehon-ho @bryanck @kbendick
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org
[GitHub] [iceberg] kbendick commented on a diff in pull request #5274: only log error message(not the stack trace) if filter conversion/bind expression fail
Posted by GitBox <gi...@apache.org>.
kbendick commented on code in PR #5274:
URL: https://github.com/apache/iceberg/pull/5274#discussion_r920732442
##########
spark/v3.2/spark/src/main/java/org/apache/iceberg/spark/source/SparkScanBuilder.java:
##########
@@ -108,8 +108,8 @@ public Filter[] pushFilters(Filter[] filters) {
expr = SparkFilters.convert(filter);
} catch (IllegalArgumentException e) {
// converting to Iceberg Expression failed, so this expression cannot be pushed down
- LOG.warn("Failed to convert filter to Iceberg expression, skipping push down for this expression: {}",
- filter, e);
+ LOG.info("Failed to convert filter to Iceberg expression, skipping push down for this expression: {} {}",
Review Comment:
I’d maybe put a `.` or `-` in between the two templated values to delineate the two sentences but I’m ok with it as is as well.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org
[GitHub] [iceberg] szehon-ho merged pull request #5274: only log error message(not the stack trace) if filter conversion/bind expression fail
Posted by GitBox <gi...@apache.org>.
szehon-ho merged PR #5274:
URL: https://github.com/apache/iceberg/pull/5274
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org
[GitHub] [iceberg] huaxingao commented on a diff in pull request #5274: only log error message(not the stack trace) if filter conversion/bind expression fail
Posted by GitBox <gi...@apache.org>.
huaxingao commented on code in PR #5274:
URL: https://github.com/apache/iceberg/pull/5274#discussion_r920739451
##########
spark/v3.2/spark/src/main/java/org/apache/iceberg/spark/source/SparkScanBuilder.java:
##########
@@ -108,8 +108,8 @@ public Filter[] pushFilters(Filter[] filters) {
expr = SparkFilters.convert(filter);
} catch (IllegalArgumentException e) {
// converting to Iceberg Expression failed, so this expression cannot be pushed down
- LOG.warn("Failed to convert filter to Iceberg expression, skipping push down for this expression: {}",
- filter, e);
+ LOG.info("Failed to convert filter to Iceberg expression, skipping push down for this expression: {} {}",
Review Comment:
added a `.` :)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org
[GitHub] [iceberg] szehon-ho commented on pull request #5274: only log error message(not the stack trace) if filter conversion/bind expression fail
Posted by GitBox <gi...@apache.org>.
szehon-ho commented on PR #5274:
URL: https://github.com/apache/iceberg/pull/5274#issuecomment-1185788683
Merged, thanks @huaxingao @kbendick @bryanck for the quick turnaround!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org
[GitHub] [iceberg] huaxingao commented on a diff in pull request #5274: only log error message(not the stack trace) if filter conversion/bind expression fail
Posted by GitBox <gi...@apache.org>.
huaxingao commented on code in PR #5274:
URL: https://github.com/apache/iceberg/pull/5274#discussion_r921363390
##########
spark/v3.2/spark/src/main/java/org/apache/iceberg/spark/source/SparkScanBuilder.java:
##########
@@ -108,8 +108,8 @@ public Filter[] pushFilters(Filter[] filters) {
expr = SparkFilters.convert(filter);
} catch (IllegalArgumentException e) {
// converting to Iceberg Expression failed, so this expression cannot be pushed down
- LOG.warn("Failed to convert filter to Iceberg expression, skipping push down for this expression: {}",
- filter, e);
+ LOG.info("Failed to convert filter to Iceberg expression, skipping push down for this expression: {}.{}",
Review Comment:
Done. Thanks!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org