You are viewing a plain text version of this content. The canonical link for it is here.

Posted to commits@pulsar.apache.org by GitBox <gi...@apache.org> on 2021/05/19 17:10:05 UTC

[GitHub] [pulsar] merlimat commented on a change in pull request #2603: Share EventLoopGroup between Broker and BK client

merlimat commented on a change in pull request #2603:
URL: https://github.com/apache/pulsar/pull/2603#discussion_r635433397



##########
File path: pulsar-broker/src/main/java/org/apache/pulsar/broker/service/schema/BookkeeperSchemaStorage.java
##########
@@ -237,9 +237,7 @@ public SchemaVersion versionFromBytes(byte[] version) {
 
     @Override
     public void close() throws Exception {
-        if (nonNull(bookKeeper)) {
-            bookKeeper.close();

Review comment:
       This was problem with the rebase. the BK client instance is owned and must be closed here. 




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org