You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@bookkeeper.apache.org by "Yixue (Andrew) Zhu (JIRA)" <ji...@apache.org> on 2012/10/24 18:38:12 UTC
[jira] [Created] (BOOKKEEPER-441) InMemorySubscriptionManager
should back up top2sub2seq before change it
Yixue (Andrew) Zhu created BOOKKEEPER-441:
---------------------------------------------
Summary: InMemorySubscriptionManager should back up top2sub2seq before change it
Key: BOOKKEEPER-441
URL: https://issues.apache.org/jira/browse/BOOKKEEPER-441
Project: Bookkeeper
Issue Type: Bug
Components: hedwig-server
Affects Versions: 4.3.0
Environment: unix
Reporter: Yixue (Andrew) Zhu
Priority: Minor
Fix For: 4.3.0
On topic loss, InMemorySubscriptionManager currently does not clear top2sub2seq. The intent is to allow readSubscription to get the information there. This introduce dependency outside the class, evidence is that general ReleaseOp has to use a boolean parameter which targets this implementation detail. Further, this prevents Acquire-topic to notify listeners (notifyFirstLocalSubscribe is not called) of first subscription to act appropriately.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (BOOKKEEPER-441) InMemorySubscriptionManager
should back up top2sub2seq before change it
Posted by "Yixue (Andrew) Zhu (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/BOOKKEEPER-441?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13483398#comment-13483398 ]
Yixue (Andrew) Zhu commented on BOOKKEEPER-441:
-----------------------------------------------
Thanks Flavio, the target version is 4.3.0.
> InMemorySubscriptionManager should back up top2sub2seq before change it
> -----------------------------------------------------------------------
>
> Key: BOOKKEEPER-441
> URL: https://issues.apache.org/jira/browse/BOOKKEEPER-441
> Project: Bookkeeper
> Issue Type: Bug
> Components: hedwig-server
> Affects Versions: 4.3.0
> Environment: unix
> Reporter: Yixue (Andrew) Zhu
> Assignee: Yixue (Andrew) Zhu
> Priority: Minor
> Labels: patch
> Fix For: 4.3.0
>
>
> On topic loss, InMemorySubscriptionManager currently does not clear top2sub2seq. The intent is to allow readSubscription to get the information there. This introduce dependency outside the class, evidence is that general ReleaseOp has to use a boolean parameter which targets this implementation detail. Further, this prevents Acquire-topic to notify listeners (notifyFirstLocalSubscribe is not called) of first subscription to act appropriately.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (BOOKKEEPER-441) InMemorySubscriptionManager
should back up top2sub2seq before change it
Posted by "Yixue (Andrew) Zhu (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/BOOKKEEPER-441?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Yixue (Andrew) Zhu updated BOOKKEEPER-441:
------------------------------------------
Affects Version/s: (was: 4.3.0)
4.2.0
Fix Version/s: (was: 4.3.0)
4.2.0
> InMemorySubscriptionManager should back up top2sub2seq before change it
> -----------------------------------------------------------------------
>
> Key: BOOKKEEPER-441
> URL: https://issues.apache.org/jira/browse/BOOKKEEPER-441
> Project: Bookkeeper
> Issue Type: Bug
> Components: hedwig-server
> Affects Versions: 4.2.0
> Environment: unix
> Reporter: Yixue (Andrew) Zhu
> Assignee: Yixue (Andrew) Zhu
> Priority: Minor
> Labels: patch
> Fix For: 4.2.0
>
> Attachments: BackupTop2Sub2Seq.patch, BackupTop2Sub2Seq.patch
>
>
> On topic loss, InMemorySubscriptionManager currently does not clear top2sub2seq. The intent is to allow readSubscription to get the information there. This introduce dependency outside the class, evidence is that general ReleaseOp has to use a boolean parameter which targets this implementation detail. Further, this prevents Acquire-topic to notify listeners (notifyFirstLocalSubscribe is not called) of first subscription to act appropriately.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (BOOKKEEPER-441) InMemorySubscriptionManager
should back up top2sub2seq before change it
Posted by "Yixue (Andrew) Zhu (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/BOOKKEEPER-441?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Yixue (Andrew) Zhu updated BOOKKEEPER-441:
------------------------------------------
Labels: patch (was: )
> InMemorySubscriptionManager should back up top2sub2seq before change it
> -----------------------------------------------------------------------
>
> Key: BOOKKEEPER-441
> URL: https://issues.apache.org/jira/browse/BOOKKEEPER-441
> Project: Bookkeeper
> Issue Type: Bug
> Components: hedwig-server
> Affects Versions: 4.3.0
> Environment: unix
> Reporter: Yixue (Andrew) Zhu
> Priority: Minor
> Labels: patch
> Fix For: 4.3.0
>
>
> On topic loss, InMemorySubscriptionManager currently does not clear top2sub2seq. The intent is to allow readSubscription to get the information there. This introduce dependency outside the class, evidence is that general ReleaseOp has to use a boolean parameter which targets this implementation detail. Further, this prevents Acquire-topic to notify listeners (notifyFirstLocalSubscribe is not called) of first subscription to act appropriately.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (BOOKKEEPER-441) InMemorySubscriptionManager
should back up top2sub2seq before change it
Posted by "Yixue (Andrew) Zhu (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/BOOKKEEPER-441?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13483378#comment-13483378 ]
Yixue (Andrew) Zhu commented on BOOKKEEPER-441:
-----------------------------------------------
I cannot assign the issue to myself for some reason (Edit/More Actions do not have the option).
> InMemorySubscriptionManager should back up top2sub2seq before change it
> -----------------------------------------------------------------------
>
> Key: BOOKKEEPER-441
> URL: https://issues.apache.org/jira/browse/BOOKKEEPER-441
> Project: Bookkeeper
> Issue Type: Bug
> Components: hedwig-server
> Affects Versions: 4.3.0
> Environment: unix
> Reporter: Yixue (Andrew) Zhu
> Priority: Minor
> Labels: patch
> Fix For: 4.3.0
>
>
> On topic loss, InMemorySubscriptionManager currently does not clear top2sub2seq. The intent is to allow readSubscription to get the information there. This introduce dependency outside the class, evidence is that general ReleaseOp has to use a boolean parameter which targets this implementation detail. Further, this prevents Acquire-topic to notify listeners (notifyFirstLocalSubscribe is not called) of first subscription to act appropriately.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (BOOKKEEPER-441) InMemorySubscriptionManager
should back up top2sub2seq before change it
Posted by "Sijie Guo (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/BOOKKEEPER-441?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13483717#comment-13483717 ]
Sijie Guo commented on BOOKKEEPER-441:
--------------------------------------
Hmm, 4.2.0 is current release. 4.3.0 is next release. Is it OK for you?
> InMemorySubscriptionManager should back up top2sub2seq before change it
> -----------------------------------------------------------------------
>
> Key: BOOKKEEPER-441
> URL: https://issues.apache.org/jira/browse/BOOKKEEPER-441
> Project: Bookkeeper
> Issue Type: Bug
> Components: hedwig-server
> Affects Versions: 4.3.0
> Environment: unix
> Reporter: Yixue (Andrew) Zhu
> Assignee: Yixue (Andrew) Zhu
> Priority: Minor
> Labels: patch
> Fix For: 4.3.0
>
> Attachments: BackupTop2Sub2Seq.patch
>
>
> On topic loss, InMemorySubscriptionManager currently does not clear top2sub2seq. The intent is to allow readSubscription to get the information there. This introduce dependency outside the class, evidence is that general ReleaseOp has to use a boolean parameter which targets this implementation detail. Further, this prevents Acquire-topic to notify listeners (notifyFirstLocalSubscribe is not called) of first subscription to act appropriately.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (BOOKKEEPER-441) InMemorySubscriptionManager
should back up top2sub2seq before change it
Posted by "Yixue (Andrew) Zhu (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/BOOKKEEPER-441?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13483741#comment-13483741 ]
Yixue (Andrew) Zhu commented on BOOKKEEPER-441:
-----------------------------------------------
4.2.0 sounds good. will update it.
> InMemorySubscriptionManager should back up top2sub2seq before change it
> -----------------------------------------------------------------------
>
> Key: BOOKKEEPER-441
> URL: https://issues.apache.org/jira/browse/BOOKKEEPER-441
> Project: Bookkeeper
> Issue Type: Bug
> Components: hedwig-server
> Affects Versions: 4.3.0
> Environment: unix
> Reporter: Yixue (Andrew) Zhu
> Assignee: Yixue (Andrew) Zhu
> Priority: Minor
> Labels: patch
> Fix For: 4.3.0
>
> Attachments: BackupTop2Sub2Seq.patch
>
>
> On topic loss, InMemorySubscriptionManager currently does not clear top2sub2seq. The intent is to allow readSubscription to get the information there. This introduce dependency outside the class, evidence is that general ReleaseOp has to use a boolean parameter which targets this implementation detail. Further, this prevents Acquire-topic to notify listeners (notifyFirstLocalSubscribe is not called) of first subscription to act appropriately.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (BOOKKEEPER-441) InMemorySubscriptionManager
should back up top2sub2seq before change it
Posted by "Ivan Kelly (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/BOOKKEEPER-441?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13483989#comment-13483989 ]
Ivan Kelly commented on BOOKKEEPER-441:
---------------------------------------
Patch looks good, and its a nice cleanup. Two comments, could you rename _top2sub2seq to top2seq2subBackup. Underscores are not very informative. Also, since after readSubscriptions, the sub info is put back into top2sub2seq, _top2sub2seq.get() in readSubscriptions should be _top2sub2seq.remove()
> InMemorySubscriptionManager should back up top2sub2seq before change it
> -----------------------------------------------------------------------
>
> Key: BOOKKEEPER-441
> URL: https://issues.apache.org/jira/browse/BOOKKEEPER-441
> Project: Bookkeeper
> Issue Type: Bug
> Components: hedwig-server
> Affects Versions: 4.2.0
> Environment: unix
> Reporter: Yixue (Andrew) Zhu
> Assignee: Yixue (Andrew) Zhu
> Priority: Minor
> Labels: patch
> Fix For: 4.2.0
>
> Attachments: BackupTop2Sub2Seq.patch, BackupTop2Sub2Seq.patch
>
>
> On topic loss, InMemorySubscriptionManager currently does not clear top2sub2seq. The intent is to allow readSubscription to get the information there. This introduce dependency outside the class, evidence is that general ReleaseOp has to use a boolean parameter which targets this implementation detail. Further, this prevents Acquire-topic to notify listeners (notifyFirstLocalSubscribe is not called) of first subscription to act appropriately.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (BOOKKEEPER-441) InMemorySubscriptionManager
should back up top2sub2seq before change it
Posted by "Flavio Junqueira (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/BOOKKEEPER-441?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Flavio Junqueira updated BOOKKEEPER-441:
----------------------------------------
Assignee: Yixue (Andrew) Zhu
> InMemorySubscriptionManager should back up top2sub2seq before change it
> -----------------------------------------------------------------------
>
> Key: BOOKKEEPER-441
> URL: https://issues.apache.org/jira/browse/BOOKKEEPER-441
> Project: Bookkeeper
> Issue Type: Bug
> Components: hedwig-server
> Affects Versions: 4.3.0
> Environment: unix
> Reporter: Yixue (Andrew) Zhu
> Assignee: Yixue (Andrew) Zhu
> Priority: Minor
> Labels: patch
> Fix For: 4.3.0
>
>
> On topic loss, InMemorySubscriptionManager currently does not clear top2sub2seq. The intent is to allow readSubscription to get the information there. This introduce dependency outside the class, evidence is that general ReleaseOp has to use a boolean parameter which targets this implementation detail. Further, this prevents Acquire-topic to notify listeners (notifyFirstLocalSubscribe is not called) of first subscription to act appropriately.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (BOOKKEEPER-441) InMemorySubscriptionManager
should back up top2sub2seq before change it
Posted by "Yixue (Andrew) Zhu (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/BOOKKEEPER-441?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13484267#comment-13484267 ]
Yixue (Andrew) Zhu commented on BOOKKEEPER-441:
-----------------------------------------------
The consideration of not removing from _top2sub2seq was that operation could fail afterwards. Given that InMemorySubscriptionManager is for test only, agreed with the change.
Updated patch.
> InMemorySubscriptionManager should back up top2sub2seq before change it
> -----------------------------------------------------------------------
>
> Key: BOOKKEEPER-441
> URL: https://issues.apache.org/jira/browse/BOOKKEEPER-441
> Project: Bookkeeper
> Issue Type: Bug
> Components: hedwig-server
> Affects Versions: 4.2.0
> Environment: unix
> Reporter: Yixue (Andrew) Zhu
> Assignee: Yixue (Andrew) Zhu
> Priority: Minor
> Labels: patch
> Fix For: 4.2.0
>
> Attachments: BackupTop2Sub2Seq.patch, BackupTop2Sub2Seq.patch, BackupTop2Sub2Seq.patch
>
>
> On topic loss, InMemorySubscriptionManager currently does not clear top2sub2seq. The intent is to allow readSubscription to get the information there. This introduce dependency outside the class, evidence is that general ReleaseOp has to use a boolean parameter which targets this implementation detail. Further, this prevents Acquire-topic to notify listeners (notifyFirstLocalSubscribe is not called) of first subscription to act appropriately.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (BOOKKEEPER-441) InMemorySubscriptionManager
should back up top2sub2seq before change it
Posted by "Flavio Junqueira (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/BOOKKEEPER-441?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13483384#comment-13483384 ]
Flavio Junqueira commented on BOOKKEEPER-441:
---------------------------------------------
I have added you to the list of contributors and assigned it to you. You have marked the fix version to 4.3.0. Is it right?
> InMemorySubscriptionManager should back up top2sub2seq before change it
> -----------------------------------------------------------------------
>
> Key: BOOKKEEPER-441
> URL: https://issues.apache.org/jira/browse/BOOKKEEPER-441
> Project: Bookkeeper
> Issue Type: Bug
> Components: hedwig-server
> Affects Versions: 4.3.0
> Environment: unix
> Reporter: Yixue (Andrew) Zhu
> Assignee: Yixue (Andrew) Zhu
> Priority: Minor
> Labels: patch
> Fix For: 4.3.0
>
>
> On topic loss, InMemorySubscriptionManager currently does not clear top2sub2seq. The intent is to allow readSubscription to get the information there. This introduce dependency outside the class, evidence is that general ReleaseOp has to use a boolean parameter which targets this implementation detail. Further, this prevents Acquire-topic to notify listeners (notifyFirstLocalSubscribe is not called) of first subscription to act appropriately.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (BOOKKEEPER-441) InMemorySubscriptionManager
should back up top2sub2seq before change it
Posted by "Hudson (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/BOOKKEEPER-441?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13484889#comment-13484889 ]
Hudson commented on BOOKKEEPER-441:
-----------------------------------
Integrated in bookkeeper-trunk #774 (See [https://builds.apache.org/job/bookkeeper-trunk/774/])
BOOKKEEPER-441: InMemorySubscriptionManager should back up top2sub2seq before change it (Yixue via ivank) (Revision 1402459)
Result = UNSTABLE
ivank :
Files :
* /zookeeper/bookkeeper/trunk/CHANGES.txt
* /zookeeper/bookkeeper/trunk/hedwig-server/src/main/java/org/apache/hedwig/server/subscriptions/AbstractSubscriptionManager.java
* /zookeeper/bookkeeper/trunk/hedwig-server/src/main/java/org/apache/hedwig/server/subscriptions/InMemorySubscriptionManager.java
> InMemorySubscriptionManager should back up top2sub2seq before change it
> -----------------------------------------------------------------------
>
> Key: BOOKKEEPER-441
> URL: https://issues.apache.org/jira/browse/BOOKKEEPER-441
> Project: Bookkeeper
> Issue Type: Bug
> Components: hedwig-server
> Affects Versions: 4.2.0
> Environment: unix
> Reporter: Yixue (Andrew) Zhu
> Assignee: Yixue (Andrew) Zhu
> Priority: Minor
> Labels: patch
> Fix For: 4.2.0
>
> Attachments: BackupTop2Sub2Seq.patch
>
>
> On topic loss, InMemorySubscriptionManager currently does not clear top2sub2seq. The intent is to allow readSubscription to get the information there. This introduce dependency outside the class, evidence is that general ReleaseOp has to use a boolean parameter which targets this implementation detail. Further, this prevents Acquire-topic to notify listeners (notifyFirstLocalSubscribe is not called) of first subscription to act appropriately.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (BOOKKEEPER-441) InMemorySubscriptionManager
should back up top2sub2seq before change it
Posted by "Yixue (Andrew) Zhu (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/BOOKKEEPER-441?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Yixue (Andrew) Zhu updated BOOKKEEPER-441:
------------------------------------------
Attachment: (was: BackupTop2Sub2Seq.patch)
> InMemorySubscriptionManager should back up top2sub2seq before change it
> -----------------------------------------------------------------------
>
> Key: BOOKKEEPER-441
> URL: https://issues.apache.org/jira/browse/BOOKKEEPER-441
> Project: Bookkeeper
> Issue Type: Bug
> Components: hedwig-server
> Affects Versions: 4.2.0
> Environment: unix
> Reporter: Yixue (Andrew) Zhu
> Assignee: Yixue (Andrew) Zhu
> Priority: Minor
> Labels: patch
> Fix For: 4.2.0
>
> Attachments: BackupTop2Sub2Seq.patch
>
>
> On topic loss, InMemorySubscriptionManager currently does not clear top2sub2seq. The intent is to allow readSubscription to get the information there. This introduce dependency outside the class, evidence is that general ReleaseOp has to use a boolean parameter which targets this implementation detail. Further, this prevents Acquire-topic to notify listeners (notifyFirstLocalSubscribe is not called) of first subscription to act appropriately.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (BOOKKEEPER-441) InMemorySubscriptionManager
should back up top2sub2seq before change it
Posted by "Yixue (Andrew) Zhu (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/BOOKKEEPER-441?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Yixue (Andrew) Zhu updated BOOKKEEPER-441:
------------------------------------------
Attachment: BackupTop2Sub2Seq.patch
> InMemorySubscriptionManager should back up top2sub2seq before change it
> -----------------------------------------------------------------------
>
> Key: BOOKKEEPER-441
> URL: https://issues.apache.org/jira/browse/BOOKKEEPER-441
> Project: Bookkeeper
> Issue Type: Bug
> Components: hedwig-server
> Affects Versions: 4.2.0
> Environment: unix
> Reporter: Yixue (Andrew) Zhu
> Assignee: Yixue (Andrew) Zhu
> Priority: Minor
> Labels: patch
> Fix For: 4.2.0
>
> Attachments: BackupTop2Sub2Seq.patch, BackupTop2Sub2Seq.patch, BackupTop2Sub2Seq.patch
>
>
> On topic loss, InMemorySubscriptionManager currently does not clear top2sub2seq. The intent is to allow readSubscription to get the information there. This introduce dependency outside the class, evidence is that general ReleaseOp has to use a boolean parameter which targets this implementation detail. Further, this prevents Acquire-topic to notify listeners (notifyFirstLocalSubscribe is not called) of first subscription to act appropriately.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (BOOKKEEPER-441) InMemorySubscriptionManager
should back up top2sub2seq before change it
Posted by "Yixue (Andrew) Zhu (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/BOOKKEEPER-441?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Yixue (Andrew) Zhu updated BOOKKEEPER-441:
------------------------------------------
Attachment: BackupTop2Sub2Seq.patch
> InMemorySubscriptionManager should back up top2sub2seq before change it
> -----------------------------------------------------------------------
>
> Key: BOOKKEEPER-441
> URL: https://issues.apache.org/jira/browse/BOOKKEEPER-441
> Project: Bookkeeper
> Issue Type: Bug
> Components: hedwig-server
> Affects Versions: 4.3.0
> Environment: unix
> Reporter: Yixue (Andrew) Zhu
> Assignee: Yixue (Andrew) Zhu
> Priority: Minor
> Labels: patch
> Fix For: 4.3.0
>
> Attachments: BackupTop2Sub2Seq.patch
>
>
> On topic loss, InMemorySubscriptionManager currently does not clear top2sub2seq. The intent is to allow readSubscription to get the information there. This introduce dependency outside the class, evidence is that general ReleaseOp has to use a boolean parameter which targets this implementation detail. Further, this prevents Acquire-topic to notify listeners (notifyFirstLocalSubscribe is not called) of first subscription to act appropriately.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (BOOKKEEPER-441) InMemorySubscriptionManager
should back up top2sub2seq before change it
Posted by "Yixue (Andrew) Zhu (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/BOOKKEEPER-441?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Yixue (Andrew) Zhu updated BOOKKEEPER-441:
------------------------------------------
Attachment: BackupTop2Sub2Seq.patch
> InMemorySubscriptionManager should back up top2sub2seq before change it
> -----------------------------------------------------------------------
>
> Key: BOOKKEEPER-441
> URL: https://issues.apache.org/jira/browse/BOOKKEEPER-441
> Project: Bookkeeper
> Issue Type: Bug
> Components: hedwig-server
> Affects Versions: 4.2.0
> Environment: unix
> Reporter: Yixue (Andrew) Zhu
> Assignee: Yixue (Andrew) Zhu
> Priority: Minor
> Labels: patch
> Fix For: 4.2.0
>
> Attachments: BackupTop2Sub2Seq.patch, BackupTop2Sub2Seq.patch
>
>
> On topic loss, InMemorySubscriptionManager currently does not clear top2sub2seq. The intent is to allow readSubscription to get the information there. This introduce dependency outside the class, evidence is that general ReleaseOp has to use a boolean parameter which targets this implementation detail. Further, this prevents Acquire-topic to notify listeners (notifyFirstLocalSubscribe is not called) of first subscription to act appropriately.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira