You are viewing a plain text version of this content. The canonical link for it is here.

Posted to jira@kafka.apache.org by GitBox <gi...@apache.org> on 2023/01/17 21:22:50 UTC

[GitHub] [kafka] jolshan commented on a diff in pull request #13112: KAFKA-14367; Add internal APIs to the new `GroupCoordinator` interface

jolshan commented on code in PR #13112:
URL: https://github.com/apache/kafka/pull/13112#discussion_r1072836630


##########
core/src/main/scala/kafka/server/BrokerServer.scala:
##########
@@ -282,8 +283,12 @@ class BrokerServer(
       tokenManager.startup() // does nothing, we just need a token manager in order to compile right now...
 
       // Create group coordinator, but don't start it until we've started replica manager.
-      // Hardcode Time.SYSTEM for now as some Streams tests fail otherwise, it would be good to fix the underlying issue

Review Comment:
   Did we decide to remove the Streams tests comment?



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: jira-unsubscribe@kafka.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org