You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@doris.apache.org by "zddr (via GitHub)" <gi...@apache.org> on 2023/04/26 14:08:57 UTC
[GitHub] [doris] zddr opened a new pull request, #19123: [improvement](FQDN)Change the implementation of fqdn
zddr opened a new pull request, #19123:
URL: https://github.com/apache/doris/pull/19123
# Proposed changes
Issue Number: close #xxx
## Problem summary
Describe your changes.
## Checklist(Required)
* [ ] Does it affect the original behavior
* [ ] Has unit tests been added
* [ ] Has document been added or modified
* [ ] Does it need to update dependencies
* [ ] Is this PR support rollback (If NO, please explain WHY)
## Further comments
If this is a relatively large or complex change, kick off the discussion at [dev@doris.apache.org](mailto:dev@doris.apache.org) by explaining why you chose the solution you did and what alternatives you considered, etc...
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
[GitHub] [doris] github-actions[bot] commented on pull request #19123: [improvement](FQDN)Change the implementation of fqdn
Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on PR #19123:
URL: https://github.com/apache/doris/pull/19123#issuecomment-1537087459
clang-tidy review says "All clean, LGTM! :+1:"
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
[GitHub] [doris] github-actions[bot] commented on pull request #19123: [improvement](FQDN)Change the implementation of fqdn
Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on PR #19123:
URL: https://github.com/apache/doris/pull/19123#issuecomment-1542255628
clang-tidy review says "All clean, LGTM! :+1:"
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
[GitHub] [doris] github-actions[bot] commented on pull request #19123: [improvement](FQDN)Change the implementation of fqdn
Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on PR #19123:
URL: https://github.com/apache/doris/pull/19123#issuecomment-1536986757
clang-tidy review says "All clean, LGTM! :+1:"
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
[GitHub] [doris] zddr commented on pull request #19123: [improvement](FQDN)Change the implementation of fqdn
Posted by "zddr (via GitHub)" <gi...@apache.org>.
zddr commented on PR #19123:
URL: https://github.com/apache/doris/pull/19123#issuecomment-1540096487
run buildall
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
[GitHub] [doris] zddr commented on pull request #19123: [improvement](FQDN)Change the implementation of fqdn
Posted by "zddr (via GitHub)" <gi...@apache.org>.
zddr commented on PR #19123:
URL: https://github.com/apache/doris/pull/19123#issuecomment-1538007438
run buildall
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
[GitHub] [doris] github-actions[bot] commented on pull request #19123: [improvement](FQDN)Change the implementation of fqdn
Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on PR #19123:
URL: https://github.com/apache/doris/pull/19123#issuecomment-1533974667
clang-tidy review says "All clean, LGTM! :+1:"
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [improvement](FQDN)Change the implementation of fqdn [doris]
Posted by "LGDHuaOPER (via GitHub)" <gi...@apache.org>.
LGDHuaOPER commented on PR #19123:
URL: https://github.com/apache/doris/pull/19123#issuecomment-3182358874
你好！
我使用 Doris v3.0.4，doris-operator v25，K8S 双栈（默认IPv6），部署 doris 集群，Pod IP 是 IPv6 形式，配置文件中 `enable_fqdn_mode = true`，启动时出现以下问题：
- 如果设置了 `priority_networks`，则 fe-0 running，fe-1 和 fe-2 crash，日志报错如下：
```text
RuntimeLogger 2025-08-13 04:03:32,999 INFO (main|1) [DorisFE.start():165] Doris FE starting...
RuntimeLogger 2025-08-13 04:03:33,004 INFO (main|1) [FrontendOptions.initAddrUsingFqdn():168] Use FQDN init local addr, FQDN: doriscluster-cloudlog-fe-1.doriscluster-cloudlog-fe-internal.deepwatch.svc.cluster.local, IP: 10.222.47.183
RuntimeLogger 2025-08-13 04:03:33,285 ERROR (main|1) [LogLog.warn():157] log4j:WARN No appenders could be found for logger (io.netty.util.internal.InternalThreadLocalMap).
RuntimeLogger 2025-08-13 04:03:33,286 ERROR (main|1) [LogLog.warn():157] log4j:WARN Please initialize the log4j system properly.
RuntimeLogger 2025-08-13 04:03:33,287 ERROR (main|1) [LogLog.warn():157] log4j:WARN See [http://logging.apache.org/log4j/1.2/faq.html#noconfig](javascript:;) for more info.
RuntimeLogger 2025-08-13 04:03:33,336 INFO (main|1) [ConsistencyChecker.initWorkTime():105] consistency checker will work from 23:00 to 23:00
RuntimeLogger 2025-08-13 04:03:34,485 INFO (main|1) [PrivTable.addEntry():89] add priv entry: Node_priv,Admin_priv
RuntimeLogger 2025-08-13 04:03:34,486 INFO (main|1) [PrivTable.addEntry():89] add priv entry: Admin_priv
RuntimeLogger 2025-08-13 04:03:34,503 INFO (main|1) [PrivTable.addEntry():89] add priv entry: database privilege.ctl: internal, db: information_schema, priv: Select_priv
RuntimeLogger 2025-08-13 04:03:34,503 INFO (main|1) [PrivTable.addEntry():89] add priv entry: database privilege.ctl: internal, db: mysql, priv: Select_priv
RuntimeLogger 2025-08-13 04:03:34,504 INFO (main|1) [PrivTable.addEntry():89] add priv entry: origWorkloadGroup:normal, priv:Usage_priv
RuntimeLogger 2025-08-13 04:03:34,505 INFO (main|1) [Auth.createUserInternal():551] finished to create user: 'root'@'%', is replay: true
RuntimeLogger 2025-08-13 04:03:34,505 INFO (main|1) [PrivTable.addEntry():89] add priv entry: database privilege.ctl: internal, db: information_schema, priv: Select_priv
RuntimeLogger 2025-08-13 04:03:34,506 INFO (main|1) [PrivTable.addEntry():89] add priv entry: database privilege.ctl: internal, db: mysql, priv: Select_priv
RuntimeLogger 2025-08-13 04:03:34,506 INFO (main|1) [PrivTable.addEntry():89] add priv entry: origWorkloadGroup:normal, priv:Usage_priv
RuntimeLogger 2025-08-13 04:03:34,507 INFO (main|1) [Auth.createUserInternal():551] finished to create user: 'admin'@'%', is replay: true
RuntimeLogger 2025-08-13 04:03:34,509 INFO (main|1) [AuthenticatorManager.<init>():42] authenticate type: DEFAULT
RuntimeLogger 2025-08-13 04:03:34,648 INFO (main|1) [MTMVService.registerHook():69] registerHook: MTMVJobManager
RuntimeLogger 2025-08-13 04:03:34,648 INFO (main|1) [MTMVService.registerHook():69] registerHook: MTMVRelationManager
RuntimeLogger 2025-08-13 04:03:34,667 INFO (main|1) [Env.getSelfHostPort():1470] get self node: HostInfo{host='doriscluster-cloudlog-fe-1.doriscluster-cloudlog-fe-internal.deepwatch.svc.cluster.local', port=9010}
RuntimeLogger 2025-08-13 04:03:34,667 INFO (main|1) [Env.getHelperNodes():1524] get helper nodes: [HostInfo{host='doriscluster-cloudlog-fe-1.doriscluster-cloudlog-fe-internal.deepwatch.svc.cluster.local', port=9010}]
RuntimeLogger 2025-08-13 04:03:34,681 INFO (main|1) [Env.checkDeployMode():1386] The current deployment mode is local.
RuntimeLogger 2025-08-13 04:03:34,681 INFO (main|1) [Env.getClusterIdAndRole():1370] finished to get cluster id: 195318165, isElectable: true, role: FOLLOWER and node name: fe_7a59cb79_af4c_43ad_8b4e_87e4b65a51a5
RuntimeLogger 2025-08-13 04:03:34,693 INFO (main|1) [Env.loadImage():2114] image does not exist: /opt/apache-doris/fe/doris-meta/image/image.0
RuntimeLogger 2025-08-13 04:03:35,277 WARN (UNKNOWN fe_7a59cb79_af4c_43ad_8b4e_87e4b65a51a5(-1)|1) [Env.notifyNewFETypeTransfer():2838] notify new FE type transfer: MASTER
RuntimeLogger 2025-08-13 04:03:35,278 INFO (UNKNOWN fe_7a59cb79_af4c_43ad_8b4e_87e4b65a51a5(-1)|1) [LogUtils.stdout():50] StdoutLogger 2025-08-13 04:03:35,278 notify new FE type transfer: MASTER
RuntimeLogger 2025-08-13 04:03:35,292 INFO (stateListener|84) [Env$5.runOneCycle():2861] begin to transfer FE type from INIT to MASTER
RuntimeLogger 2025-08-13 04:03:35,294 INFO (stateListener|84) [BDBHA.fencing():79] start fencing, epoch number is 24
RuntimeLogger 2025-08-13 04:03:35,298 INFO (stateListener|84) [Env.transferToMaster():1589] finish replay in 1 msec
RuntimeLogger 2025-08-13 04:03:35,300 INFO (stateListener|84) [BDBEnvironment.getReplicationGroupAdmin():231] addresses is empty
RuntimeLogger 2025-08-13 04:03:35,300 ERROR (stateListener|84) [Env.checkCurrentNodeExist():2009] current node doriscluster-cloudlog-fe-1.doriscluster-cloudlog-fe-internal.deepwatch.svc.cluster.local:9010 is not added to the cluster, will exit. Your FE IP maybe changed, please set 'priority_networks' config in fe.conf properly.
```
- 如果没有设置 `priority_networks`，fe-0、fe-1、fe-2 都 crash，报错日志如下（Error 级别）：
我想请问下，这个是什么原因呢？我要如何操作才能使得集群正常？是否是因为 FQDN 不支持 IPv6？
谢谢！
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
[GitHub] [doris] zddr commented on pull request #19123: [improvement](FQDN)Change the implementation of fqdn
Posted by "zddr (via GitHub)" <gi...@apache.org>.
zddr commented on PR #19123:
URL: https://github.com/apache/doris/pull/19123#issuecomment-1539577673
run buildall
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
[GitHub] [doris] zddr commented on pull request #19123: [improvement](FQDN)Change the implementation of fqdn
Posted by "zddr (via GitHub)" <gi...@apache.org>.
zddr commented on PR #19123:
URL: https://github.com/apache/doris/pull/19123#issuecomment-1533974752
run buildall
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
[GitHub] [doris] github-actions[bot] commented on pull request #19123: [improvement](FQDN)Change the implementation of fqdn
Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on PR #19123:
URL: https://github.com/apache/doris/pull/19123#issuecomment-1534139004
clang-tidy review says "All clean, LGTM! :+1:"
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
[GitHub] [doris] github-actions[bot] commented on pull request #19123: [improvement](FQDN)Change the implementation of fqdn
Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on PR #19123:
URL: https://github.com/apache/doris/pull/19123#issuecomment-1534712449
clang-tidy review says "All clean, LGTM! :+1:"
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
[GitHub] [doris] github-actions[bot] commented on pull request #19123: [improvement](FQDN)Change the implementation of fqdn
Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on PR #19123:
URL: https://github.com/apache/doris/pull/19123#issuecomment-1534718940
clang-tidy review says "All clean, LGTM! :+1:"
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
[GitHub] [doris] morningman commented on pull request #19123: [improvement](FQDN)Change the implementation of fqdn
Posted by "morningman (via GitHub)" <gi...@apache.org>.
morningman commented on PR #19123:
URL: https://github.com/apache/doris/pull/19123#issuecomment-1527024247
run buildall
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
[GitHub] [doris] zddr commented on a diff in pull request #19123: [improvement](FQDN)Change the implementation of fqdn
Posted by "zddr (via GitHub)" <gi...@apache.org>.
zddr commented on code in PR #19123:
URL: https://github.com/apache/doris/pull/19123#discussion_r1185631028
##########
be/src/util/network_util.cpp:
##########
@@ -104,6 +104,26 @@ Status hostname_to_ip_addrs(const std::string& name, std::vector<std::string>* a
return Status::OK();
}
+bool is_valid_ip(const std::string& ip) {
+ unsigned char buf[sizeof(struct in6_addr)];
+ return inet_pton(AF_INET, ip.data(), buf) > 0;
+}
+
+std::string hostname_to_ip(const std::string& host) {
Review Comment:
’convert hostname to ip ‘ is used for resolve error when ip change,if cache result,may lose this effect
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
[GitHub] [doris] github-actions[bot] commented on pull request #19123: [improvement](FQDN)Change the implementation of fqdn
Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on PR #19123:
URL: https://github.com/apache/doris/pull/19123#issuecomment-1537070970
clang-tidy review says "All clean, LGTM! :+1:"
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
[GitHub] [doris] github-actions[bot] commented on pull request #19123: [improvement](FQDN)Change the implementation of fqdn
Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on PR #19123:
URL: https://github.com/apache/doris/pull/19123#issuecomment-1536985801
#### `sh-checker report`
To get the full details, please check in the [job]("https://github.com/apache/doris/actions/runs/4899154721") output.
<details>
<summary>shellcheck errors</summary>
```
'shellcheck ' found no issues.
```
</details>
<details>
<summary>shfmt errors</summary>
```
'shfmt ' returned error 1 finding the following formatting issues:
----------
--- tools/single-node-cluster/multi-fe.orig
+++ tools/single-node-cluster/multi-fe
@@ -156,7 +156,7 @@
http_port="$(grep 'http_port' "${CURRENT_PATH}/fe1/conf/fe.conf" | sed 's/http_port[[:space:]]*=[[:space:]]*//')"
while true; do
- mysql_command "ALTER SYSTEM ADD FOLLOWER \"127.0.0.1:$((PORT + id))\"" >/dev/null 2>&1 || true
+ mysql_command "ALTER SYSTEM ADD FOLLOWER \"127.0.0.1:$((PORT + id))\"" >/dev/null 2>&1 || true
if header="$(curl --noproxy '127.0.0.1' --silent --head --fail -H "CLIENT_NODE_HOST:127.0.0.1" -H "CLIENT_NODE_PORT:$((PORT + id))" "http://127.0.0.1:${http_port}/check")"; then
break
fi
----------
You can reformat the above files to meet shfmt's requirements by typing:
shfmt -w filename
```
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
[GitHub] [doris] github-actions[bot] commented on pull request #19123: [improvement](FQDN)Change the implementation of fqdn
Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on PR #19123:
URL: https://github.com/apache/doris/pull/19123#issuecomment-1537062115
PR approved by anyone and no changes requested.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
[GitHub] [doris] github-actions[bot] commented on pull request #19123: [improvement](FQDN)Change the implementation of fqdn
Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on PR #19123:
URL: https://github.com/apache/doris/pull/19123#issuecomment-1541080961
clang-tidy review says "All clean, LGTM! :+1:"
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
[GitHub] [doris] morningman commented on pull request #19123: [improvement](FQDN)Change the implementation of fqdn
Posted by "morningman (via GitHub)" <gi...@apache.org>.
morningman commented on PR #19123:
URL: https://github.com/apache/doris/pull/19123#issuecomment-1535030015
run buildall
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
[GitHub] [doris] hello-stephen commented on pull request #19123: [improvement](FQDN)Change the implementation of fqdn
Posted by "hello-stephen (via GitHub)" <gi...@apache.org>.
hello-stephen commented on PR #19123:
URL: https://github.com/apache/doris/pull/19123#issuecomment-1524549920
TeamCity pipeline, clickbench performance test result:
the sum of best hot time: 33.87 seconds
stream load tsv: 423 seconds loaded 74807831229 Bytes, about 168 MB/s
stream load json: 23 seconds loaded 2358488459 Bytes, about 97 MB/s
stream load orc: 58 seconds loaded 1101869774 Bytes, about 18 MB/s
stream load parquet: 30 seconds loaded 861443392 Bytes, about 27 MB/s
https://doris-community-test-1308700295.cos.ap-hongkong.myqcloud.com/tmp/20230427030000_clickbench_pr_136125.html
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
[GitHub] [doris] github-actions[bot] commented on pull request #19123: [improvement](FQDN)Change the implementation of fqdn
Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on PR #19123:
URL: https://github.com/apache/doris/pull/19123#issuecomment-1524623700
clang-tidy review says "All clean, LGTM! :+1:"
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
[GitHub] [doris] github-actions[bot] commented on pull request #19123: [improvement](FQDN)Change the implementation of fqdn
Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on PR #19123:
URL: https://github.com/apache/doris/pull/19123#issuecomment-1535973147
#### `sh-checker report`
To get the full details, please check in the [job]("https://github.com/apache/doris/actions/runs/4891868885") output.
<details>
<summary>shellcheck errors</summary>
```
'shellcheck ' found no issues.
```
</details>
<details>
<summary>shfmt errors</summary>
```
'shfmt ' returned error 1 finding the following formatting issues:
----------
--- tools/single-node-cluster/multi-fe.orig
+++ tools/single-node-cluster/multi-fe
@@ -156,7 +156,7 @@
http_port="$(grep 'http_port' "${CURRENT_PATH}/fe1/conf/fe.conf" | sed 's/http_port[[:space:]]*=[[:space:]]*//')"
while true; do
- mysql_command "ALTER SYSTEM ADD FOLLOWER \"127.0.0.1:$((PORT + id))\"" >/dev/null 2>&1 || true
+ mysql_command "ALTER SYSTEM ADD FOLLOWER \"127.0.0.1:$((PORT + id))\"" >/dev/null 2>&1 || true
if header="$(curl --noproxy '127.0.0.1' --silent --head --fail -H "CLIENT_NODE_HOST:127.0.0.1" -H "CLIENT_NODE_PORT:$((PORT + id))" "http://127.0.0.1:${http_port}/check")"; then
break
fi
----------
You can reformat the above files to meet shfmt's requirements by typing:
shfmt -w filename
```
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
[GitHub] [doris] github-actions[bot] commented on pull request #19123: [improvement](FQDN)Change the implementation of fqdn
Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on PR #19123:
URL: https://github.com/apache/doris/pull/19123#issuecomment-1523574350
clang-tidy review says "All clean, LGTM! :+1:"
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
[GitHub] [doris] github-actions[bot] commented on pull request #19123: [improvement](FQDN)Change the implementation of fqdn
Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on PR #19123:
URL: https://github.com/apache/doris/pull/19123#issuecomment-1536964302
#### `sh-checker report`
To get the full details, please check in the [job]("https://github.com/apache/doris/actions/runs/4898946088") output.
<details>
<summary>shellcheck errors</summary>
```
'shellcheck ' found no issues.
```
</details>
<details>
<summary>shfmt errors</summary>
```
'shfmt ' returned error 1 finding the following formatting issues:
----------
--- tools/single-node-cluster/multi-fe.orig
+++ tools/single-node-cluster/multi-fe
@@ -156,7 +156,7 @@
http_port="$(grep 'http_port' "${CURRENT_PATH}/fe1/conf/fe.conf" | sed 's/http_port[[:space:]]*=[[:space:]]*//')"
while true; do
- mysql_command "ALTER SYSTEM ADD FOLLOWER \"127.0.0.1:$((PORT + id))\"" >/dev/null 2>&1 || true
+ mysql_command "ALTER SYSTEM ADD FOLLOWER \"127.0.0.1:$((PORT + id))\"" >/dev/null 2>&1 || true
if header="$(curl --noproxy '127.0.0.1' --silent --head --fail -H "CLIENT_NODE_HOST:127.0.0.1" -H "CLIENT_NODE_PORT:$((PORT + id))" "http://127.0.0.1:${http_port}/check")"; then
break
fi
----------
You can reformat the above files to meet shfmt's requirements by typing:
shfmt -w filename
```
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
[GitHub] [doris] github-actions[bot] commented on pull request #19123: [improvement](FQDN)Change the implementation of fqdn
Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on PR #19123:
URL: https://github.com/apache/doris/pull/19123#issuecomment-1536965602
clang-tidy review says "All clean, LGTM! :+1:"
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
[GitHub] [doris] github-actions[bot] commented on pull request #19123: [improvement](FQDN)Change the implementation of fqdn
Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on PR #19123:
URL: https://github.com/apache/doris/pull/19123#issuecomment-1539580454
clang-tidy review says "All clean, LGTM! :+1:"
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
[GitHub] [doris] github-actions[bot] commented on pull request #19123: [improvement](FQDN)Change the implementation of fqdn
Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on PR #19123:
URL: https://github.com/apache/doris/pull/19123#issuecomment-1523500218
clang-tidy review says "All clean, LGTM! :+1:"
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
[GitHub] [doris] deardeng commented on a diff in pull request #19123: [improvement](FQDN)Change the implementation of fqdn
Posted by "deardeng (via GitHub)" <gi...@apache.org>.
deardeng commented on code in PR #19123:
URL: https://github.com/apache/doris/pull/19123#discussion_r1185725481
##########
fe/fe-core/src/main/java/org/apache/doris/journal/bdbje/BDBJEJournal.java:
##########
@@ -309,9 +305,9 @@ public synchronized void open() {
File dbEnv = new File(environmentPath);
bdbEnvironment = new BDBEnvironment();
HostInfo helperNode = Env.getServingEnv().getHelperNode();
- String helperHostPort = helperNode.getIp() + ":" + helperNode.getPort();
+ String helperHostPort = helperNode.getHost() + ":" + helperNode.getPort();
if (Config.enable_fqdn_mode) {
- helperHostPort = helperNode.getHostName() + ":" + helperNode.getPort();
+ helperHostPort = helperNode.getHost() + ":" + helperNode.getPort();
Review Comment:
useless?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
[GitHub] [doris] github-actions[bot] commented on pull request #19123: [improvement](FQDN)Change the implementation of fqdn
Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on PR #19123:
URL: https://github.com/apache/doris/pull/19123#issuecomment-1535976244
clang-tidy review says "All clean, LGTM! :+1:"
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
[GitHub] [doris] github-actions[bot] commented on pull request #19123: [improvement](FQDN)Change the implementation of fqdn
Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on PR #19123:
URL: https://github.com/apache/doris/pull/19123#issuecomment-1537024802
clang-tidy review says "All clean, LGTM! :+1:"
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
[GitHub] [doris] github-actions[bot] commented on pull request #19123: [improvement](FQDN)Change the implementation of fqdn
Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on PR #19123:
URL: https://github.com/apache/doris/pull/19123#issuecomment-1536969086
clang-tidy review says "All clean, LGTM! :+1:"
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
[GitHub] [doris] github-actions[bot] commented on pull request #19123: [improvement](FQDN)Change the implementation of fqdn
Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on PR #19123:
URL: https://github.com/apache/doris/pull/19123#issuecomment-1540103347
clang-tidy review says "All clean, LGTM! :+1:"
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
[GitHub] [doris] github-actions[bot] commented on pull request #19123: [improvement](FQDN)Change the implementation of fqdn
Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on PR #19123:
URL: https://github.com/apache/doris/pull/19123#issuecomment-1535994909
clang-tidy review says "All clean, LGTM! :+1:"
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
[GitHub] [doris] github-actions[bot] commented on pull request #19123: [improvement](FQDN)Change the implementation of fqdn
Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on PR #19123:
URL: https://github.com/apache/doris/pull/19123#issuecomment-1536968003
#### `sh-checker report`
To get the full details, please check in the [job]("https://github.com/apache/doris/actions/runs/4898977886") output.
<details>
<summary>shellcheck errors</summary>
```
'shellcheck ' found no issues.
```
</details>
<details>
<summary>shfmt errors</summary>
```
'shfmt ' returned error 1 finding the following formatting issues:
----------
--- tools/single-node-cluster/multi-fe.orig
+++ tools/single-node-cluster/multi-fe
@@ -20,8 +20,8 @@
set -e
CURRENT_PATH="$(
- cd "$(dirname "${BASH_SOURCE[0]}")"
- pwd
+ cd "$(dirname "${BASH_SOURCE[0]}")"
+ pwd
)"
OUTPUT_PATH="$(readlink -f "${CURRENT_PATH}/../../output")"
@@ -29,38 +29,38 @@
readonly OUTPUT_PATH
function log() {
- local level="${1}"
- local message="${2}"
- local date
- date="$(date +'%Y-%m-%d %H:%M:%S')"
- if [[ "${level}" == 'INFO' ]]; then
- level="[\033[32;1m ${level} \033[0m]"
- elif [[ "${level}" == 'WARNING' ]]; then
- level="[\033[33;1m${level}\033[0m]"
- elif [[ "${level}" == 'ERROR' ]]; then
- level="[\033[31;1m ${level} \033[0m]"
- fi
- echo -e "${level} ${date} - ${message}"
+ local level="${1}"
+ local message="${2}"
+ local date
+ date="$(date +'%Y-%m-%d %H:%M:%S')"
+ if [[ "${level}" == 'INFO' ]]; then
+ level="[\033[32;1m ${level} \033[0m]"
+ elif [[ "${level}" == 'WARNING' ]]; then
+ level="[\033[33;1m${level}\033[0m]"
+ elif [[ "${level}" == 'ERROR' ]]; then
+ level="[\033[31;1m ${level} \033[0m]"
+ fi
+ echo -e "${level} ${date} - ${message}"
}
function log_info() {
- local message="${1}"
- log 'INFO' "${message}"
+ local message="${1}"
+ log 'INFO' "${message}"
}
function log_warning() {
- local message="${1}"
- log 'WARNING' "${message}"
+ local message="${1}"
+ log 'WARNING' "${message}"
}
function log_error() {
- local message="${1}"
- log 'ERROR' "${message}"
- exit 1
+ local message="${1}"
+ log 'ERROR' "${message}"
+ exit 1
}
function help() {
- cat >&2 <<EOF
+ cat >&2 <<EOF
${BASH_SOURCE[0]} start|stop|clean [OPTIONS ...]
start -n <NUM> -l <LIBRARY_PATH> -p <BASE_PORT>
@@ -74,56 +74,56 @@
clean Clean the data (rm -rf "\$(pwd)"/fe*).
EOF
- exit 1
+ exit 1
}
function parse_options() {
- NUMBER_INSTANCES=1
- PORT=9010
- LIBS_PATH="${OUTPUT_PATH}/fe/lib"
+ NUMBER_INSTANCES=1
+ PORT=9010
+ LIBS_PATH="${OUTPUT_PATH}/fe/lib"
- ACTION="${1}"
- if ! shift 1; then
- help
- fi
+ ACTION="${1}"
+ if ! shift 1; then
+ help
+ fi
- local option
- while getopts "+n:p:l:" option; do
- case "${option}" in
- n)
- NUMBER_INSTANCES="${OPTARG}"
- ;;
- p)
- PORT="${OPTARG}"
- ;;
- l)
- LIBS_PATH="$(readlink -f "${OPTARG}")"
- ;;
- *)
- help
- ;;
- esac
- done
+ local option
+ while getopts "+n:p:l:" option; do
+ case "${option}" in
+ n)
+ NUMBER_INSTANCES="${OPTARG}"
+ ;;
+ p)
+ PORT="${OPTARG}"
+ ;;
+ l)
+ LIBS_PATH="$(readlink -f "${OPTARG}")"
+ ;;
+ *)
+ help
+ ;;
+ esac
+ done
- readonly NUMBER_INSTANCES
- readonly PORT
- readonly LIBS_PATH
+ readonly NUMBER_INSTANCES
+ readonly PORT
+ readonly LIBS_PATH
}
function prepare() {
- local port="${1}"
- local doris_home="${2}"
- local log_dir="${3}"
- local conf_dir="${doris_home}/conf"
- local meta_dir="${doris_home}/doris-meta"
- local http_port=8030
+ local port="${1}"
+ local doris_home="${2}"
+ local log_dir="${3}"
+ local conf_dir="${doris_home}/conf"
+ local meta_dir="${doris_home}/doris-meta"
+ local http_port=8030
- mkdir -p "${doris_home}"
- mkdir -p "${log_dir}"
- mkdir -p "${conf_dir}"
- mkdir -p "${meta_dir}"
+ mkdir -p "${doris_home}"
+ mkdir -p "${log_dir}"
+ mkdir -p "${conf_dir}"
+ mkdir -p "${meta_dir}"
- cat >"${conf_dir}/fe.conf" <<EOF
+ cat >"${conf_dir}/fe.conf" <<EOF
LOG_DIR = ${log_dir}
meta_dir = ${meta_dir}
@@ -142,129 +142,129 @@
}
function mysql_command() {
- local command="${1}"
- local query_port
- query_port="$(grep 'query_port' "${CURRENT_PATH}/fe1/conf/fe.conf" | sed 's/query_port[[:space:]]*=[[:space:]]*//')"
- mysql -h127.0.0.1 -P"${query_port}" -uroot -e "${command}" -s -N
+ local command="${1}"
+ local query_port
+ query_port="$(grep 'query_port' "${CURRENT_PATH}/fe1/conf/fe.conf" | sed 's/query_port[[:space:]]*=[[:space:]]*//')"
+ mysql -h127.0.0.1 -P"${query_port}" -uroot -e "${command}" -s -N
}
function create_role_and_version() {
- local id="${1}"
- local http_port
- local header
- local meta_dir
+ local id="${1}"
+ local http_port
+ local header
+ local meta_dir
- http_port="$(grep 'http_port' "${CURRENT_PATH}/fe1/conf/fe.conf" | sed 's/http_port[[:space:]]*=[[:space:]]*//')"
- while true; do
- mysql_command "ALTER SYSTEM ADD FOLLOWER \"127.0.0.1:$((PORT + id))\"" >/dev/null 2>&1 || true
- if header="$(curl --noproxy '127.0.0.1' --silent --head --fail -H "CLIENT_NODE_HOST:127.0.0.1" -H "CLIENT_NODE_PORT:$((PORT + id))" "http://127.0.0.1:${http_port}/check")"; then
- break
- fi
- log_info "Waiting for the Master FE to be ready ..."
- sleep 1
- done
- meta_dir="$(grep 'meta_dir' "${CURRENT_PATH}/fe${id}/conf/fe.conf" | sed 's/meta_dir[[:space:]]*=[[:space:]]*//')"
+ http_port="$(grep 'http_port' "${CURRENT_PATH}/fe1/conf/fe.conf" | sed 's/http_port[[:space:]]*=[[:space:]]*//')"
+ while true; do
+ mysql_command "ALTER SYSTEM ADD FOLLOWER \"127.0.0.1:$((PORT + id))\"" >/dev/null 2>&1 || true
+ if header="$(curl --noproxy '127.0.0.1' --silent --head --fail -H "CLIENT_NODE_HOST:127.0.0.1" -H "CLIENT_NODE_PORT:$((PORT + id))" "http://127.0.0.1:${http_port}/check")"; then
+ break
+ fi
+ log_info "Waiting for the Master FE to be ready ..."
+ sleep 1
+ done
+ meta_dir="$(grep 'meta_dir' "${CURRENT_PATH}/fe${id}/conf/fe.conf" | sed 's/meta_dir[[:space:]]*=[[:space:]]*//')"
- mkdir -p "${meta_dir}/image"
- echo "${header}" | sed -n '/cluster_id/,/token/p' | sed '{s/cluster_id: /clusterId=/;s/token: /token=/;}' \
- >"${meta_dir}/image/VERSION"
+ mkdir -p "${meta_dir}/image"
+ echo "${header}" | sed -n '/cluster_id/,/token/p' | sed '{s/cluster_id: /clusterId=/;s/token: /token=/;}' \
+ >"${meta_dir}/image/VERSION"
- cat >"${meta_dir}/image/ROLE" <<EOF
+ cat >"${meta_dir}/image/ROLE" <<EOF
role=FOLLOWER
name=$(
- set -e
- mysql_command "SHOW FRONTENDS" | grep "127.0.0.1_$((PORT + id))" | awk '{print $1}'
- )
+ set -e
+ mysql_command "SHOW FRONTENDS" | grep "127.0.0.1_$((PORT + id))" | awk '{print $1}'
+ )
EOF
}
function start_fe() {
- local id="${1}"
- local port="${2}"
- local libs_path="${3}"
- local doris_home
- local helper
+ local id="${1}"
+ local port="${2}"
+ local libs_path="${3}"
+ local doris_home
+ local helper
- doris_home="$(pwd)/fe${id}"
- local pid_dir="${doris_home}"
- local log_dir="${doris_home}/log"
+ doris_home="$(pwd)/fe${id}"
+ local pid_dir="${doris_home}"
+ local log_dir="${doris_home}/log"
- if [[ -f "${pid_dir}/fe.pid" ]]; then
- if xargs kill -0 <"${pid_dir}/fe.pid"; then
- log_warning "FE(${id}) is running..."
- return
- fi
- fi
+ if [[ -f "${pid_dir}/fe.pid" ]]; then
+ if xargs kill -0 <"${pid_dir}/fe.pid"; then
+ log_warning "FE(${id}) is running..."
+ return
+ fi
+ fi
- prepare "${port}" "${doris_home}" "${log_dir}"
+ prepare "${port}" "${doris_home}" "${log_dir}"
- declare -a classpath=("${libs_path}")
- for lib in "${libs_path}"/*.jar; do
- classpath+=("${lib}")
- done
+ declare -a classpath=("${libs_path}")
+ for lib in "${libs_path}"/*.jar; do
+ classpath+=("${lib}")
+ done
- if [[ "${id}" -gt 1 ]]; then
- helper="-helper 127.0.0.1:$((PORT + 1))"
- create_role_and_version "${id}"
- fi
+ if [[ "${id}" -gt 1 ]]; then
+ helper="-helper 127.0.0.1:$((PORT + 1))"
+ create_role_and_version "${id}"
+ fi
- pushd "${doris_home}" >/dev/null
- DORIS_HOME="${doris_home}" \
- PID_DIR="${doris_home}" \
- nohup java -cp "$(
- IFS=:
- echo "${classpath[*]}"
- )" org.apache.doris.DorisFE ${helper:+${helper}} >>"${log_dir}/fe.out" 2>&1 &
- if kill -0 $!; then
- log_info "Start FE(${id}) successfully"
- else
- log_warning "Failed to start FE(${id})"
- fi
- popd >/dev/null
+ pushd "${doris_home}" >/dev/null
+ DORIS_HOME="${doris_home}" \
+ PID_DIR="${doris_home}" \
+ nohup java -cp "$(
+ IFS=:
+ echo "${classpath[*]}"
+ )" org.apache.doris.DorisFE ${helper:+${helper}} >>"${log_dir}/fe.out" 2>&1 &
+ if kill -0 $!; then
+ log_info "Start FE(${id}) successfully"
+ else
+ log_warning "Failed to start FE(${id})"
+ fi
+ popd >/dev/null
}
function start() {
- if [[ -z "${LIBS_PATH}" ]]; then
- help
- fi
+ if [[ -z "${LIBS_PATH}" ]]; then
+ help
+ fi
- log_info "NUMBER: ${NUMBER_INSTANCES}"
- log_info "BASE PORT: ${PORT}"
- log_info "LIBRARY_PATH: ${LIBS_PATH}"
+ log_info "NUMBER: ${NUMBER_INSTANCES}"
+ log_info "BASE PORT: ${PORT}"
+ log_info "LIBRARY_PATH: ${LIBS_PATH}"
- for i in $(seq "${NUMBER_INSTANCES}"); do
- start_fe "${i}" "${PORT}" "${LIBS_PATH}"
- done
+ for i in $(seq "${NUMBER_INSTANCES}"); do
+ start_fe "${i}" "${PORT}" "${LIBS_PATH}"
+ done
}
function stop() {
- local pid
- while read -r file; do
- pid="$(<"${file}")"
- if kill "${pid}"; then
- log_info "Stopped FE (${pid}) successfully"
- else
- log_warning "Failed to stop FE (${pid})"
- fi
- done < <(find "$(pwd)"/fe* -name 'fe.pid')
+ local pid
+ while read -r file; do
+ pid="$(<"${file}")"
+ if kill "${pid}"; then
+ log_info "Stopped FE (${pid}) successfully"
+ else
+ log_warning "Failed to stop FE (${pid})"
+ fi
+ done < <(find "$(pwd)"/fe* -name 'fe.pid')
}
function clean() {
- rm -rf "$(pwd)"/fe*
- log_info "Clean all data successfully"
+ rm -rf "$(pwd)"/fe*
+ log_info "Clean all data successfully"
}
function main() {
- parse_options "${@}"
+ parse_options "${@}"
- case "${ACTION}" in
- start) start ;;
- stop) stop ;;
- clean) clean ;;
- *)
- help
- ;;
- esac
+ case "${ACTION}" in
+ start) start ;;
+ stop) stop ;;
+ clean) clean ;;
+ *)
+ help
+ ;;
+ esac
}
main "${@}"
----------
You can reformat the above files to meet shfmt's requirements by typing:
shfmt -w filename
```
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
[GitHub] [doris] morningman commented on pull request #19123: [improvement](FQDN)Change the implementation of fqdn
Posted by "morningman (via GitHub)" <gi...@apache.org>.
morningman commented on PR #19123:
URL: https://github.com/apache/doris/pull/19123#issuecomment-1537615144
run buildall
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
[GitHub] [doris] morningman commented on pull request #19123: [improvement](FQDN)Change the implementation of fqdn
Posted by "morningman (via GitHub)" <gi...@apache.org>.
morningman commented on PR #19123:
URL: https://github.com/apache/doris/pull/19123#issuecomment-1537098553
run buildall
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
[GitHub] [doris] github-actions[bot] commented on pull request #19123: [improvement](FQDN)Change the implementation of fqdn
Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on PR #19123:
URL: https://github.com/apache/doris/pull/19123#issuecomment-1537095493
clang-tidy review says "All clean, LGTM! :+1:"
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
[GitHub] [doris] zddr commented on pull request #19123: [improvement](FQDN)Change the implementation of fqdn
Posted by "zddr (via GitHub)" <gi...@apache.org>.
zddr commented on PR #19123:
URL: https://github.com/apache/doris/pull/19123#issuecomment-1541074265
run buildall
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
[GitHub] [doris] github-actions[bot] commented on pull request #19123: [improvement](FQDN)Change the implementation of fqdn
Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on PR #19123:
URL: https://github.com/apache/doris/pull/19123#issuecomment-1524501655
clang-tidy review says "All clean, LGTM! :+1:"
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
[GitHub] [doris] github-actions[bot] commented on pull request #19123: [improvement](FQDN)Change the implementation of fqdn
Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on PR #19123:
URL: https://github.com/apache/doris/pull/19123#issuecomment-1525064510
clang-tidy review says "All clean, LGTM! :+1:"
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
[GitHub] [doris] github-actions[bot] commented on pull request #19123: [improvement](FQDN)Change the implementation of fqdn
Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on PR #19123:
URL: https://github.com/apache/doris/pull/19123#issuecomment-1537609144
clang-tidy review says "All clean, LGTM! :+1:"
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
[GitHub] [doris] github-actions[bot] commented on pull request #19123: [improvement](FQDN)Change the implementation of fqdn
Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on PR #19123:
URL: https://github.com/apache/doris/pull/19123#issuecomment-1538008042
clang-tidy review says "All clean, LGTM! :+1:"
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
[GitHub] [doris] zddr commented on pull request #19123: [improvement](FQDN)Change the implementation of fqdn
Posted by "zddr (via GitHub)" <gi...@apache.org>.
zddr commented on PR #19123:
URL: https://github.com/apache/doris/pull/19123#issuecomment-1534150689
run buildall
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
[GitHub] [doris] github-actions[bot] commented on pull request #19123: [improvement](FQDN)Change the implementation of fqdn
Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on PR #19123:
URL: https://github.com/apache/doris/pull/19123#issuecomment-1534709119
#### `sh-checker report`
To get the full details, please check in the [job]("https://github.com/apache/doris/actions/runs/4882885140") output.
<details>
<summary>shellcheck errors</summary>
```
'shellcheck ' found no issues.
```
</details>
<details>
<summary>shfmt errors</summary>
```
'shfmt ' returned error 1 finding the following formatting issues:
----------
--- tools/single-node-cluster/multi-fe.orig
+++ tools/single-node-cluster/multi-fe
@@ -156,7 +156,7 @@
http_port="$(grep 'http_port' "${CURRENT_PATH}/fe1/conf/fe.conf" | sed 's/http_port[[:space:]]*=[[:space:]]*//')"
while true; do
- mysql_command "ALTER SYSTEM ADD FOLLOWER \"127.0.0.1:$((PORT + id))\"" >/dev/null 2>&1 || true
+ mysql_command "ALTER SYSTEM ADD FOLLOWER \"127.0.0.1:$((PORT + id))\"" >/dev/null 2>&1 || true
if header="$(curl --noproxy '127.0.0.1' --silent --head --fail -H "CLIENT_NODE_HOST:127.0.0.1" -H "CLIENT_NODE_PORT:$((PORT + id))" "http://127.0.0.1:${http_port}/check")"; then
break
fi
----------
You can reformat the above files to meet shfmt's requirements by typing:
shfmt -w filename
```
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
[GitHub] [doris] morningman merged pull request #19123: [improvement](FQDN)Change the implementation of fqdn
Posted by "morningman (via GitHub)" <gi...@apache.org>.
morningman merged PR #19123:
URL: https://github.com/apache/doris/pull/19123
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
[GitHub] [doris] zddr commented on pull request #19123: [improvement](FQDN)Change the implementation of fqdn
Posted by "zddr (via GitHub)" <gi...@apache.org>.
zddr commented on PR #19123:
URL: https://github.com/apache/doris/pull/19123#issuecomment-1524493860
run buildall
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
[GitHub] [doris] zddr commented on pull request #19123: [improvement](FQDN)Change the implementation of fqdn
Posted by "zddr (via GitHub)" <gi...@apache.org>.
zddr commented on PR #19123:
URL: https://github.com/apache/doris/pull/19123#issuecomment-1542250046
run buildall
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
[GitHub] [doris] github-actions[bot] commented on pull request #19123: [improvement](FQDN)Change the implementation of fqdn
Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on PR #19123:
URL: https://github.com/apache/doris/pull/19123#issuecomment-1539579394
clang-tidy review says "All clean, LGTM! :+1:"
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
[GitHub] [doris] github-actions[bot] commented on pull request #19123: [improvement](FQDN)Change the implementation of fqdn
Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on PR #19123:
URL: https://github.com/apache/doris/pull/19123#issuecomment-1535992039
#### `sh-checker report`
To get the full details, please check in the [job]("https://github.com/apache/doris/actions/runs/4892000448") output.
<details>
<summary>shellcheck errors</summary>
```
'shellcheck ' found no issues.
```
</details>
<details>
<summary>shfmt errors</summary>
```
'shfmt ' returned error 1 finding the following formatting issues:
----------
--- tools/single-node-cluster/multi-fe.orig
+++ tools/single-node-cluster/multi-fe
@@ -156,7 +156,7 @@
http_port="$(grep 'http_port' "${CURRENT_PATH}/fe1/conf/fe.conf" | sed 's/http_port[[:space:]]*=[[:space:]]*//')"
while true; do
- mysql_command "ALTER SYSTEM ADD FOLLOWER \"127.0.0.1:$((PORT + id))\"" >/dev/null 2>&1 || true
+ mysql_command "ALTER SYSTEM ADD FOLLOWER \"127.0.0.1:$((PORT + id))\"" >/dev/null 2>&1 || true
if header="$(curl --noproxy '127.0.0.1' --silent --head --fail -H "CLIENT_NODE_HOST:127.0.0.1" -H "CLIENT_NODE_PORT:$((PORT + id))" "http://127.0.0.1:${http_port}/check")"; then
break
fi
----------
You can reformat the above files to meet shfmt's requirements by typing:
shfmt -w filename
```
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
[GitHub] [doris] github-actions[bot] commented on pull request #19123: [improvement](FQDN)Change the implementation of fqdn
Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on PR #19123:
URL: https://github.com/apache/doris/pull/19123#issuecomment-1534714219
#### `sh-checker report`
To get the full details, please check in the [job]("https://github.com/apache/doris/actions/runs/4882914297") output.
<details>
<summary>shellcheck errors</summary>
```
'shellcheck ' found no issues.
```
</details>
<details>
<summary>shfmt errors</summary>
```
'shfmt ' returned error 1 finding the following formatting issues:
----------
--- tools/single-node-cluster/multi-fe.orig
+++ tools/single-node-cluster/multi-fe
@@ -156,7 +156,7 @@
http_port="$(grep 'http_port' "${CURRENT_PATH}/fe1/conf/fe.conf" | sed 's/http_port[[:space:]]*=[[:space:]]*//')"
while true; do
- mysql_command "ALTER SYSTEM ADD FOLLOWER \"127.0.0.1:$((PORT + id))\"" >/dev/null 2>&1 || true
+ mysql_command "ALTER SYSTEM ADD FOLLOWER \"127.0.0.1:$((PORT + id))\"" >/dev/null 2>&1 || true
if header="$(curl --noproxy '127.0.0.1' --silent --head --fail -H "CLIENT_NODE_HOST:127.0.0.1" -H "CLIENT_NODE_PORT:$((PORT + id))" "http://127.0.0.1:${http_port}/check")"; then
break
fi
----------
You can reformat the above files to meet shfmt's requirements by typing:
shfmt -w filename
```
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
[GitHub] [doris] morningman commented on a diff in pull request #19123: [improvement](FQDN)Change the implementation of fqdn
Posted by "morningman (via GitHub)" <gi...@apache.org>.
morningman commented on code in PR #19123:
URL: https://github.com/apache/doris/pull/19123#discussion_r1185223106
##########
be/src/util/network_util.cpp:
##########
@@ -104,6 +104,26 @@ Status hostname_to_ip_addrs(const std::string& name, std::vector<std::string>* a
return Status::OK();
}
+bool is_valid_ip(const std::string& ip) {
+ unsigned char buf[sizeof(struct in6_addr)];
+ return inet_pton(AF_INET, ip.data(), buf) > 0;
+}
+
+std::string hostname_to_ip(const std::string& host) {
+ std::vector<std::string> addresses;
+ Status status = hostname_to_ip_addrs(host, &addresses);
+ if (!status.ok()) {
+ LOG(WARNING) << "status of hostname_to_ip_addrs was not ok, err is " << status.to_string();
+ return "";
+ }
+ if (addresses.size() != 1) {
+ LOG(WARNING)
+ << "the number of addresses could only be equal to 1, failed to get ip from host";
Review Comment:
Better print ip in `addresses` for debug
##########
fe/fe-core/src/main/java/org/apache/doris/service/FrontendOptions.java:
##########
@@ -53,64 +55,131 @@ public static void init() throws UnknownHostException {
return;
}
- analyzePriorityCidrs();
-
- // if not set frontend_address, get a non-loopback ip
List<InetAddress> hosts = new ArrayList<>();
NetUtils.getHosts(hosts);
if (hosts.isEmpty()) {
LOG.error("fail to get localhost");
System.exit(-1);
}
+ if (Config.enable_fqdn_mode) {
+ initAddrUseFqdn(hosts);
Review Comment:
```suggestion
initAddrUsingFqdn(hosts);
```
##########
be/src/util/network_util.cpp:
##########
@@ -104,6 +104,26 @@ Status hostname_to_ip_addrs(const std::string& name, std::vector<std::string>* a
return Status::OK();
}
+bool is_valid_ip(const std::string& ip) {
+ unsigned char buf[sizeof(struct in6_addr)];
+ return inet_pton(AF_INET, ip.data(), buf) > 0;
+}
+
+std::string hostname_to_ip(const std::string& host) {
Review Comment:
And better to cache the result so that we don't need to convert hostname to ip every time
##########
be/src/util/network_util.cpp:
##########
@@ -104,6 +104,26 @@ Status hostname_to_ip_addrs(const std::string& name, std::vector<std::string>* a
return Status::OK();
}
+bool is_valid_ip(const std::string& ip) {
+ unsigned char buf[sizeof(struct in6_addr)];
+ return inet_pton(AF_INET, ip.data(), buf) > 0;
Review Comment:
Is it suitable for ipv6?
##########
be/src/agent/heartbeat_server.cpp:
##########
@@ -83,11 +84,56 @@ Status HeartbeatServer::_heartbeat(const TMasterInfo& master_info) {
if (master_info.__isset.backend_ip) {
if (master_info.backend_ip != BackendOptions::get_localhost()) {
- LOG(WARNING) << "backend ip saved in master does not equal to backend local ip"
- << master_info.backend_ip << " vs. " << BackendOptions::get_localhost();
- std::stringstream ss;
- ss << "actual backend local ip: " << BackendOptions::get_localhost();
- return Status::InternalError(ss.str());
+ LOG(INFO) << master_info.backend_ip << " not equal to to backend localhost "
+ << BackendOptions::get_localhost();
+ if (is_valid_ip(master_info.backend_ip)) {
+ LOG(WARNING) << "backend ip saved in master does not equal to backend local ip"
+ << master_info.backend_ip << " vs. "
+ << BackendOptions::get_localhost();
+ std::stringstream ss;
+ ss << "actual backend local ip: " << BackendOptions::get_localhost();
+ return Status::InternalError(ss.str());
+ }
+
+ std::string ip = hostname_to_ip(master_info.backend_ip);
+ if (ip.empty()) {
+ std::stringstream ss;
+ ss << "can not get ip from fqdn: " << master_info.backend_ip;
+ LOG(WARNING) << ss.str();
+ return Status::InternalError(ss.str());
+ }
+
+ std::vector<InetAddress> hosts;
+ Status status = get_hosts(&hosts);
+ if (!status.ok() || hosts.empty()) {
+ std::stringstream ss;
+ ss << "the status was not ok when get_hosts_v4, error is " << status.to_string();
+ LOG(WARNING) << ss.str();
+ return Status::InternalError(ss.str());
+ }
+
+ bool set_new_localhost = false;
+ BackendOptions::set_localhost(master_info.backend_ip);
+ for (std::vector<InetAddress>::iterator addr_it = hosts.begin(); addr_it != hosts.end();
Review Comment:
for (auto& addr : hosts) {
}
##########
be/src/util/network_util.cpp:
##########
@@ -104,6 +104,26 @@ Status hostname_to_ip_addrs(const std::string& name, std::vector<std::string>* a
return Status::OK();
}
+bool is_valid_ip(const std::string& ip) {
+ unsigned char buf[sizeof(struct in6_addr)];
+ return inet_pton(AF_INET, ip.data(), buf) > 0;
+}
+
+std::string hostname_to_ip(const std::string& host) {
Review Comment:
Better return `Status`. And pass out ip addr as a parameter.
##########
be/src/agent/heartbeat_server.cpp:
##########
@@ -83,11 +84,56 @@ Status HeartbeatServer::_heartbeat(const TMasterInfo& master_info) {
if (master_info.__isset.backend_ip) {
if (master_info.backend_ip != BackendOptions::get_localhost()) {
- LOG(WARNING) << "backend ip saved in master does not equal to backend local ip"
- << master_info.backend_ip << " vs. " << BackendOptions::get_localhost();
- std::stringstream ss;
- ss << "actual backend local ip: " << BackendOptions::get_localhost();
- return Status::InternalError(ss.str());
+ LOG(INFO) << master_info.backend_ip << " not equal to to backend localhost "
Review Comment:
Please add comment in code to explain following logic, in format like:
```
step 1:
step 2:
...
``
##########
be/src/service/backend_options.cpp:
##########
@@ -91,6 +92,17 @@ const std::string& BackendOptions::get_localhost() {
return _s_localhost;
}
+TBackend BackendOptions::get_localBackend() {
Review Comment:
```suggestion
TBackend BackendOptions::get_local_backend() {
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
[GitHub] [doris] github-actions[bot] commented on pull request #19123: [improvement](FQDN)Change the implementation of fqdn
Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on PR #19123:
URL: https://github.com/apache/doris/pull/19123#issuecomment-1537031957
clang-tidy review says "All clean, LGTM! :+1:"
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
[GitHub] [doris] morningman commented on pull request #19123: [improvement](FQDN)Change the implementation of fqdn
Posted by "morningman (via GitHub)" <gi...@apache.org>.
morningman commented on PR #19123:
URL: https://github.com/apache/doris/pull/19123#issuecomment-1537061861
run buildall
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
[GitHub] [doris] github-actions[bot] commented on pull request #19123: [improvement](FQDN)Change the implementation of fqdn
Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on PR #19123:
URL: https://github.com/apache/doris/pull/19123#issuecomment-1537062108
PR approved by at least one committer and no changes requested.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
[GitHub] [doris] github-actions[bot] commented on pull request #19123: [improvement](FQDN)Change the implementation of fqdn
Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on PR #19123:
URL: https://github.com/apache/doris/pull/19123#issuecomment-1538012066
clang-tidy review says "All clean, LGTM! :+1:"
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org