You are viewing a plain text version of this content. The canonical link for it is here.
Posted to jira@kafka.apache.org by GitBox <gi...@apache.org> on 2020/06/29 05:49:33 UTC
[GitHub] [kafka] chia7712 opened a new pull request #8944: KAFKA-10209 fix flaky connect_rest_test.py
chia7712 opened a new pull request #8944:
URL: https://github.com/apache/kafka/pull/8944
There are two new configs introduced by 371f14c3c12d2e341ac96bd52393b43a10acfa84 and 1c4eb1a5757df611735cfac9b709e0d80d0da4b3 so we have to update the expected configs in connect_rest_test.py
issue: https://issues.apache.org/jira/browse/KAFKA-10209
### Committer Checklist (excluded from commit message)
- [ ] Verify design and implementation
- [ ] Verify test coverage and CI build status
- [ ] Verify documentation (including upgrade notes)
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [kafka] chia7712 commented on pull request #8944: KAFKA-10209: Fix connect_rest_test.py after the introduction of new connector configs
Posted by GitBox <gi...@apache.org>.
chia7712 commented on pull request #8944:
URL: https://github.com/apache/kafka/pull/8944#issuecomment-653702134
> Also, note this is not flaky. It's failing consistently.
Got it. I will give more accurate title next time!
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [kafka] chia7712 commented on pull request #8944: KAFKA-10209 fix flaky connect_rest_test.py
Posted by GitBox <gi...@apache.org>.
chia7712 commented on pull request #8944:
URL: https://github.com/apache/kafka/pull/8944#issuecomment-653293914
ping for reviewing this straightforward PR :)
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [kafka] chia7712 commented on pull request #8944: KAFKA-10209 fix flaky connect_rest_test.py
Posted by GitBox <gi...@apache.org>.
chia7712 commented on pull request #8944:
URL: https://github.com/apache/kafka/pull/8944#issuecomment-652435776
```
org.apache.kafka.streams.integration.EosBetaUpgradeIntegrationTest.shouldUpgradeFromEosAlphaToEosBeta[false]
org.apache.kafka.streams.integration.EosBetaUpgradeIntegrationTest.shouldUpgradeFromEosAlphaToEosBeta[true]
org.apache.kafka.streams.integration.EosBetaUpgradeIntegrationTest.shouldUpgradeFromEosAlphaToEosBeta[true]
```
they are unrelated to this PR and traced by #8963
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [kafka] kkonstantine merged pull request #8944: KAFKA-10209: Fix connect_rest_test.py after the introduction of new connector configs
Posted by GitBox <gi...@apache.org>.
kkonstantine merged pull request #8944:
URL: https://github.com/apache/kafka/pull/8944
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [kafka] kkonstantine commented on pull request #8944: KAFKA-10209 fix flaky connect_rest_test.py
Posted by GitBox <gi...@apache.org>.
kkonstantine commented on pull request #8944:
URL: https://github.com/apache/kafka/pull/8944#issuecomment-653631904
What I don't like too much about this test is that it fails on optional configs. But on the other hand I guess it's good to have a test for a complete listing, it's just that this is failing after a merge. Thanks for the fix. I confirmed by running this system test locally. Unit/integration tests are not relevant here.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [kafka] kkonstantine commented on pull request #8944: KAFKA-10209: Fix connect_rest_test.py after the introduction of new connector configs
Posted by GitBox <gi...@apache.org>.
kkonstantine commented on pull request #8944:
URL: https://github.com/apache/kafka/pull/8944#issuecomment-653633933
Merged to `trunk` and cherry-picked to `2.6`
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [kafka] kkonstantine commented on pull request #8944: KAFKA-10209 fix flaky connect_rest_test.py
Posted by GitBox <gi...@apache.org>.
kkonstantine commented on pull request #8944:
URL: https://github.com/apache/kafka/pull/8944#issuecomment-653632091
Also, note this is not flaky. It's failing consistently.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org