You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@flink.apache.org by GitBox <gi...@apache.org> on 2021/08/19 08:27:04 UTC
[GitHub] [flink] zentol commented on a change in pull request #16884: [FLINK-22221][runtime] Log instantiations of FileChannelManager to pr…
zentol commented on a change in pull request #16884:
URL: https://github.com/apache/flink/pull/16884#discussion_r691897680
##########
File path: flink-runtime/src/main/java/org/apache/flink/runtime/io/network/NettyShuffleServiceFactory.java
##########
@@ -111,6 +118,14 @@ static NettyShuffleEnvironment createNettyShuffleEnvironment(
FileChannelManager fileChannelManager =
new FileChannelManagerImpl(config.getTempDirs(), DIR_NAME_PREFIX);
+ if (LOG.isInfoEnabled()) {
+ LOG.info(
+ "Created a new {} for storing result partitions of BLOCKING shuffle. Used directories: {}.",
+ FileChannelManager.class.getSimpleName(),
+ Arrays.stream(fileChannelManager.getPaths())
+ .map(File::getAbsolutePath)
+ .collect(Collectors.joining(", ")));
Review comment:
same as above
##########
File path: flink-runtime/src/main/java/org/apache/flink/runtime/io/disk/iomanager/IOManager.java
##########
@@ -54,6 +56,14 @@
protected IOManager(String[] tempDirs) {
this.fileChannelManager =
new FileChannelManagerImpl(Preconditions.checkNotNull(tempDirs), DIR_NAME_PREFIX);
+ if (LOG.isInfoEnabled()) {
+ LOG.info(
+ "Created a new {} for spilling of task related data to disk (joins, sorting, ...). Used directories: {}.",
+ FileChannelManager.class.getSimpleName(),
+ Arrays.stream(fileChannelManager.getPaths())
+ .map(File::getAbsolutePath)
+ .collect(Collectors.joining(", ")));
Review comment:
maybe do something fancy here because the directories might be quite long:
```
Used Directories:
<directory1>
<directory2>
```
##########
File path: flink-runtime/src/main/java/org/apache/flink/runtime/io/network/NettyShuffleServiceFactory.java
##########
@@ -111,6 +118,14 @@ static NettyShuffleEnvironment createNettyShuffleEnvironment(
FileChannelManager fileChannelManager =
new FileChannelManagerImpl(config.getTempDirs(), DIR_NAME_PREFIX);
+ if (LOG.isInfoEnabled()) {
+ LOG.info(
+ "Created a new {} for storing result partitions of BLOCKING shuffle. Used directories: {}.",
Review comment:
```suggestion
"Created a new {} for storing result partitions of BLOCKING shuffles. Used directories: {}.",
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org