You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@doris.apache.org by "mrhhsg (via GitHub)" <gi...@apache.org> on 2024/03/12 07:26:47 UTC
[PR] [fix](function) incorrect result of eq_for_null [doris]
mrhhsg opened a new pull request, #32103:
URL: https://github.com/apache/doris/pull/32103
## Proposed changes
Issue Number: close #xxx
<!--Describe your changes.-->
## Further comments
If this is a relatively large or complex change, kick off the discussion at [dev@doris.apache.org](mailto:dev@doris.apache.org) by explaining why you chose the solution you did and what alternatives you considered, etc...
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [fix](function) incorrect result of eq_for_null [doris]
Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on PR #32103:
URL: https://github.com/apache/doris/pull/32103#issuecomment-1990946176
PR approved by at least one committer and no changes requested.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [fix](function) incorrect result of eq_for_null [doris]
Posted by "doris-robot (via GitHub)" <gi...@apache.org>.
doris-robot commented on PR #32103:
URL: https://github.com/apache/doris/pull/32103#issuecomment-1991011759
<details>
<summary>ClickBench: <b>Total hot run time: 30.38 s</b></summary>
```
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/clickbench-tools
ClickBench test result on commit 1c4fcdcd5f410df88e911f06a40363ede0bbf9fe, data reload: false
query1 0.04 0.04 0.03
query2 0.06 0.02 0.02
query3 0.23 0.06 0.06
query4 1.67 0.10 0.10
query5 0.51 0.52 0.50
query6 1.18 0.61 0.62
query7 0.02 0.02 0.01
query8 0.04 0.03 0.03
query9 0.59 0.51 0.48
query10 0.55 0.56 0.55
query11 0.12 0.09 0.09
query12 0.12 0.09 0.09
query13 0.58 0.57 0.56
query14 0.73 0.78 0.75
query15 0.80 0.80 0.77
query16 0.40 0.41 0.41
query17 1.05 0.98 0.94
query18 0.21 0.24 0.25
query19 1.78 1.70 1.76
query20 0.01 0.01 0.01
query21 15.40 0.53 0.56
query22 2.31 2.37 1.96
query23 17.19 0.75 0.78
query24 3.95 1.62 1.00
query25 0.27 0.13 0.07
query26 0.69 0.13 0.12
query27 0.05 0.03 0.03
query28 11.07 0.89 0.84
query29 12.56 3.14 3.17
query30 0.69 0.55 0.54
query31 2.79 0.35 0.33
query32 3.40 0.44 0.43
query33 2.79 2.74 2.80
query34 16.00 4.35 4.32
query35 4.27 4.35 4.34
query36 1.08 1.00 1.02
query37 0.07 0.05 0.06
query38 0.04 0.04 0.03
query39 0.02 0.02 0.02
query40 0.17 0.14 0.13
query41 0.07 0.02 0.02
query42 0.03 0.02 0.02
query43 0.03 0.02 0.03
Total cold run time: 105.63 s
Total hot run time: 30.38 s
```
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [fix](function) incorrect result of eq_for_null [doris]
Posted by "doris-robot (via GitHub)" <gi...@apache.org>.
doris-robot commented on PR #32103:
URL: https://github.com/apache/doris/pull/32103#issuecomment-1990940642
Thank you for your contribution to Apache Doris.
Don't know what should be done next? See [How to process your PR](https://cwiki.apache.org/confluence/display/DORIS/How+to+process+your+PR)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [fix](function) incorrect result of eq_for_null [doris]
Posted by "yiguolei (via GitHub)" <gi...@apache.org>.
yiguolei merged PR #32103:
URL: https://github.com/apache/doris/pull/32103
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [fix](function) incorrect result of eq_for_null [doris]
Posted by "doris-robot (via GitHub)" <gi...@apache.org>.
doris-robot commented on PR #32103:
URL: https://github.com/apache/doris/pull/32103#issuecomment-1990971463
TeamCity be ut coverage result:
Function Coverage: 34.98% (8556/24459)
Line Coverage: 26.82% (69528/259264)
Region Coverage: 26.06% (36074/138420)
Branch Coverage: 23.03% (18437/80072)
Coverage Report: http://coverage.selectdb-in.cc/coverage/1c4fcdcd5f410df88e911f06a40363ede0bbf9fe_1c4fcdcd5f410df88e911f06a40363ede0bbf9fe/report/index.html
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [fix](function) incorrect result of eq_for_null [doris]
Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on PR #32103:
URL: https://github.com/apache/doris/pull/32103#issuecomment-1990946225
PR approved by anyone and no changes requested.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [fix](function) incorrect result of eq_for_null [doris]
Posted by "doris-robot (via GitHub)" <gi...@apache.org>.
doris-robot commented on PR #32103:
URL: https://github.com/apache/doris/pull/32103#issuecomment-1991016425
Load test result on machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
```
Load test result on commit 1c4fcdcd5f410df88e911f06a40363ede0bbf9fe with default session variables
Stream load json: 18 seconds loaded 2358488459 Bytes, about 124 MB/s
Stream load orc: 59 seconds loaded 1101869774 Bytes, about 17 MB/s
Stream load parquet: 32 seconds loaded 861443392 Bytes, about 25 MB/s
Insert into select: 15.9 seconds inserted 10000000 Rows, about 628K ops/s
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [fix](function) incorrect result of eq_for_null [doris]
Posted by "doris-robot (via GitHub)" <gi...@apache.org>.
doris-robot commented on PR #32103:
URL: https://github.com/apache/doris/pull/32103#issuecomment-1991003815
<details>
<summary>TPC-DS: <b>Total hot run time: 186524 ms</b></summary>
```
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/tpcds-tools
TPC-DS sf100 test result on commit 1c4fcdcd5f410df88e911f06a40363ede0bbf9fe, data reload: false
query1 937 349 341 341
query2 7376 1959 2000 1959
query3 6712 217 215 215
query4 31549 20644 20772 20644
query5 4316 405 533 405
query6 270 171 170 170
query7 4621 306 289 289
query8 222 172 174 172
query9 9787 2342 2311 2311
query10 462 249 242 242
query11 14649 14015 14266 14015
query12 121 83 82 82
query13 1617 404 418 404
query14 10953 10264 11083 10264
query15 261 219 199 199
query16 7696 272 263 263
query17 1939 565 546 546
query18 1561 284 280 280
query19 212 162 152 152
query20 92 89 84 84
query21 197 131 131 131
query22 4652 4428 4471 4428
query23 31803 31016 31244 31016
query24 11367 2809 2844 2809
query25 596 381 365 365
query26 801 162 157 157
query27 2748 351 351 351
query28 6858 1925 1912 1912
query29 877 648 632 632
query30 312 151 151 151
query31 988 722 722 722
query32 101 64 58 58
query33 769 257 267 257
query34 1062 477 506 477
query35 824 610 605 605
query36 1008 872 888 872
query37 118 81 87 81
query38 3316 3131 3148 3131
query39 1425 1379 1402 1379
query40 216 111 112 111
query41 49 51 46 46
query42 101 99 100 99
query43 483 455 458 455
query44 1275 705 723 705
query45 271 264 255 255
query46 1098 688 684 684
query47 1661 1589 1600 1589
query48 465 366 353 353
query49 1104 351 337 337
query50 757 384 381 381
query51 6622 6599 6532 6532
query52 116 91 93 91
query53 339 274 283 274
query54 301 237 249 237
query55 92 82 83 82
query56 275 231 241 231
query57 1066 1003 1007 1003
query58 235 209 202 202
query59 2670 2523 2556 2523
query60 287 240 259 240
query61 97 93 106 93
query62 616 430 414 414
query63 300 272 281 272
query64 5402 3842 3747 3747
query65 3083 3076 3012 3012
query66 844 349 321 321
query67 14667 14378 14605 14378
query68 5231 523 535 523
query69 543 375 368 368
query70 1199 1139 1188 1139
query71 471 285 272 272
query72 6329 2649 2485 2485
query73 704 328 324 324
query74 7798 6632 6539 6539
query75 8753 7978 7899 7899
query76 3541 927 975 927
query77 442 288 254 254
query78 10375 9565 9666 9565
query79 7812 522 519 519
query80 1705 385 486 385
query81 557 221 217 217
query82 1413 207 208 207
query83 315 148 143 143
query84 288 81 82 81
query85 1698 376 364 364
query86 490 314 280 280
query87 3439 3240 3224 3224
query88 5168 2382 2359 2359
query89 499 370 368 368
query90 1977 187 180 180
query91 165 137 139 137
query92 57 54 56 54
query93 6042 497 492 492
query94 1262 187 181 181
query95 434 331 325 325
query96 619 270 265 265
query97 4388 4259 4277 4259
query98 218 206 209 206
query99 1078 793 745 745
Total cold run time: 304677 ms
Total hot run time: 186524 ms
```
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [fix](function) incorrect result of eq_for_null [doris]
Posted by "doris-robot (via GitHub)" <gi...@apache.org>.
doris-robot commented on PR #32103:
URL: https://github.com/apache/doris/pull/32103#issuecomment-1990986322
<details>
<summary>TPC-H: <b>Total hot run time: 36270 ms</b></summary>
```
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/tpch-tools
Tpch sf100 test result on commit 1c4fcdcd5f410df88e911f06a40363ede0bbf9fe, data reload: false
------ Round 1 ----------------------------------
q1 17710 4097 4105 4097
q2 2038 151 145 145
q3 10571 885 860 860
q4 4646 670 660 660
q5 7587 2744 2749 2744
q6 182 124 129 124
q7 1161 813 783 783
q8 9479 2041 1987 1987
q9 7248 6453 6408 6408
q10 8098 2521 2512 2512
q11 422 225 217 217
q12 767 306 298 298
q13 17945 2991 2988 2988
q14 280 249 260 249
q15 502 461 451 451
q16 481 400 393 393
q17 953 604 509 509
q18 6569 5745 5806 5745
q19 1560 1447 1479 1447
q20 548 275 273 273
q21 7404 3169 3086 3086
q22 799 294 294 294
Total cold run time: 106950 ms
Total hot run time: 36270 ms
----- Round 2, with runtime_filter_mode=off -----
q1 4117 4050 4089 4050
q2 335 223 228 223
q3 3057 2909 2940 2909
q4 1849 1563 1639 1563
q5 5231 5255 5186 5186
q6 196 114 117 114
q7 2286 1821 1815 1815
q8 3136 3248 3278 3248
q9 8567 8471 8500 8471
q10 6113 3640 3660 3640
q11 533 443 444 443
q12 727 550 545 545
q13 11161 2830 2863 2830
q14 267 249 248 248
q15 479 438 435 435
q16 452 411 420 411
q17 1714 1465 1466 1465
q18 7474 7245 7041 7041
q19 6313 1495 1544 1495
q20 1927 1694 1679 1679
q21 4819 4690 4611 4611
q22 530 449 453 449
Total cold run time: 71283 ms
Total hot run time: 52871 ms
```
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [fix](function) incorrect result of eq_for_null [doris]
Posted by "mrhhsg (via GitHub)" <gi...@apache.org>.
mrhhsg commented on PR #32103:
URL: https://github.com/apache/doris/pull/32103#issuecomment-1990940852
run buildall
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org