You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@lucene.apache.org by GitBox <gi...@apache.org> on 2022/08/12 11:20:47 UTC
[GitHub] [lucene-jira-archive] mikemccand opened a new pull request, #145: Polish INFRA instructions a bit
mikemccand opened a new pull request, #145:
URL: https://github.com/apache/lucene-jira-archive/pull/145
I made a few possible polish edits for the INFRA instructions, plus one question.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@lucene.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@lucene.apache.org
For additional commands, e-mail: issues-help@lucene.apache.org
[GitHub] [lucene-jira-archive] mocobeta commented on a diff in pull request #145: Polish INFRA instructions a bit
Posted by GitBox <gi...@apache.org>.
mocobeta commented on code in PR #145:
URL: https://github.com/apache/lucene-jira-archive/pull/145#discussion_r944395455
##########
migration/instructions-for-infra-team.md:
##########
@@ -35,7 +35,7 @@ GH-LUCENE-10677.json
# set the GitHub PAT token to an env variable
migration $ cp .env.example .env
migration $ vi .env
-export GITHUB_PAT=<set the personal access token to be used for importing here>
+export GITHUB_PAT=<set the `asfgit` personal access token to be used for importing here>
Review Comment:
Note: `asfgit` is my proposal/request. I think we are still not fully sure what account will be used, but fine with this for now. I'll make sure of the correct account information.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@lucene.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@lucene.apache.org
For additional commands, e-mail: issues-help@lucene.apache.org
[GitHub] [lucene-jira-archive] mikemccand merged pull request #145: Polish INFRA instructions a bit
Posted by GitBox <gi...@apache.org>.
mikemccand merged PR #145:
URL: https://github.com/apache/lucene-jira-archive/pull/145
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@lucene.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@lucene.apache.org
For additional commands, e-mail: issues-help@lucene.apache.org
[GitHub] [lucene-jira-archive] mocobeta commented on a diff in pull request #145: Polish INFRA instructions a bit
Posted by GitBox <gi...@apache.org>.
mocobeta commented on code in PR #145:
URL: https://github.com/apache/lucene-jira-archive/pull/145#discussion_r944385229
##########
migration/instructions-for-infra-team.md:
##########
@@ -77,17 +77,19 @@ JiraKey,GitHubUrl,GitHubNumber
LUCENE-1,https://github.com/apache/lucene/issues/1080,1080
```
+Peek at the issue through GitHub and confirm it was imported and looks reasonable.
+
### Clean up the test data
-Once the test is done, please delete `mapping-data/issue-map.csv` file and the imported issue (only admin accounts can delete an issue) before the actual migration.
+Once the test is done, please delete `mapping-data/issue-map.csv` local file and the imported issue through GitHub (only admin accounts can delete an issue) before the actual migration.
## Run the import script
-Please specify the `min` option to 1 and `max` option to the maximum number of the Lucene Jira issue, that will be known by then.
+Please specify the `min` option to 1 and `max` option to the maximum number of the Lucene Jira issue, that will be known by then (how? based on the un-tgz'd GitHub import data? or maybe you/we will communicate this number to them? if so, let's say that above?)
Review Comment:
Thanks for reviewing it.
This is the only part we cannot determine yet, I will replace the `<will be known>` with the concrete number after taking the Jira snapshot to avoid miscommunication.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@lucene.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@lucene.apache.org
For additional commands, e-mail: issues-help@lucene.apache.org
[GitHub] [lucene-jira-archive] mocobeta commented on a diff in pull request #145: Polish INFRA instructions a bit
Posted by GitBox <gi...@apache.org>.
mocobeta commented on code in PR #145:
URL: https://github.com/apache/lucene-jira-archive/pull/145#discussion_r944408114
##########
migration/instructions-for-infra-team.md:
##########
@@ -77,17 +77,19 @@ JiraKey,GitHubUrl,GitHubNumber
LUCENE-1,https://github.com/apache/lucene/issues/1080,1080
```
+Peek at the issue through GitHub and confirm it was imported and looks reasonable.
+
### Clean up the test data
-Once the test is done, please delete `mapping-data/issue-map.csv` file and the imported issue (only admin accounts can delete an issue) before the actual migration.
+Once the test is done, please delete `mapping-data/issue-map.csv` local file and the imported issue through GitHub (only admin accounts can delete an issue) before the actual migration.
## Run the import script
-Please specify the `min` option to 1 and `max` option to the maximum number of the Lucene Jira issue, that will be known by then.
+Please specify the `min` option to 1 and `max` option to the maximum number of the Lucene Jira issue, that will be known by then (how? based on the un-tgz'd GitHub import data? or maybe you/we will communicate this number to them? if so, let's say that above?)
Review Comment:
Thank you very much!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@lucene.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@lucene.apache.org
For additional commands, e-mail: issues-help@lucene.apache.org
[GitHub] [lucene-jira-archive] mocobeta commented on a diff in pull request #145: Polish INFRA instructions a bit
Posted by GitBox <gi...@apache.org>.
mocobeta commented on code in PR #145:
URL: https://github.com/apache/lucene-jira-archive/pull/145#discussion_r944395455
##########
migration/instructions-for-infra-team.md:
##########
@@ -35,7 +35,7 @@ GH-LUCENE-10677.json
# set the GitHub PAT token to an env variable
migration $ cp .env.example .env
migration $ vi .env
-export GITHUB_PAT=<set the personal access token to be used for importing here>
+export GITHUB_PAT=<set the `asfgit` personal access token to be used for importing here>
Review Comment:
Note: `asfbot` is my proposal/request to infra. I think we are still not fully sure what account will be used, but fine with this for now. I'll make sure of the correct account information.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@lucene.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@lucene.apache.org
For additional commands, e-mail: issues-help@lucene.apache.org
[GitHub] [lucene-jira-archive] mocobeta commented on a diff in pull request #145: Polish INFRA instructions a bit
Posted by GitBox <gi...@apache.org>.
mocobeta commented on code in PR #145:
URL: https://github.com/apache/lucene-jira-archive/pull/145#discussion_r944395455
##########
migration/instructions-for-infra-team.md:
##########
@@ -35,7 +35,7 @@ GH-LUCENE-10677.json
# set the GitHub PAT token to an env variable
migration $ cp .env.example .env
migration $ vi .env
-export GITHUB_PAT=<set the personal access token to be used for importing here>
+export GITHUB_PAT=<set the `asfgit` personal access token to be used for importing here>
Review Comment:
Note: `asfbot` is my proposal/request. I think we are still not fully sure what account will be used, but fine with this for now. I'll make sure of the correct account information.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@lucene.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@lucene.apache.org
For additional commands, e-mail: issues-help@lucene.apache.org
[GitHub] [lucene-jira-archive] mikemccand commented on a diff in pull request #145: Polish INFRA instructions a bit
Posted by GitBox <gi...@apache.org>.
mikemccand commented on code in PR #145:
URL: https://github.com/apache/lucene-jira-archive/pull/145#discussion_r944386278
##########
migration/instructions-for-infra-team.md:
##########
@@ -77,17 +77,19 @@ JiraKey,GitHubUrl,GitHubNumber
LUCENE-1,https://github.com/apache/lucene/issues/1080,1080
```
+Peek at the issue through GitHub and confirm it was imported and looks reasonable.
+
### Clean up the test data
-Once the test is done, please delete `mapping-data/issue-map.csv` file and the imported issue (only admin accounts can delete an issue) before the actual migration.
+Once the test is done, please delete `mapping-data/issue-map.csv` local file and the imported issue through GitHub (only admin accounts can delete an issue) before the actual migration.
## Run the import script
-Please specify the `min` option to 1 and `max` option to the maximum number of the Lucene Jira issue, that will be known by then.
+Please specify the `min` option to 1 and `max` option to the maximum number of the Lucene Jira issue, that will be known by then (how? based on the un-tgz'd GitHub import data? or maybe you/we will communicate this number to them? if so, let's say that above?)
Review Comment:
Oh I see, `<will be known>` means "we will fill this in before we hand off these instructions to INFRA on the actual day of migration", OK. I'll try to word that in.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@lucene.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@lucene.apache.org
For additional commands, e-mail: issues-help@lucene.apache.org
[GitHub] [lucene-jira-archive] mikemccand commented on a diff in pull request #145: Polish INFRA instructions a bit
Posted by GitBox <gi...@apache.org>.
mikemccand commented on code in PR #145:
URL: https://github.com/apache/lucene-jira-archive/pull/145#discussion_r944368903
##########
migration/instructions-for-infra-team.md:
##########
@@ -77,17 +77,19 @@ JiraKey,GitHubUrl,GitHubNumber
LUCENE-1,https://github.com/apache/lucene/issues/1080,1080
```
+Peek at the issue through GitHub and confirm it was imported and looks reasonable.
+
### Clean up the test data
-Once the test is done, please delete `mapping-data/issue-map.csv` file and the imported issue (only admin accounts can delete an issue) before the actual migration.
+Once the test is done, please delete `mapping-data/issue-map.csv` local file and the imported issue through GitHub (only admin accounts can delete an issue) before the actual migration.
## Run the import script
-Please specify the `min` option to 1 and `max` option to the maximum number of the Lucene Jira issue, that will be known by then.
+Please specify the `min` option to 1 and `max` option to the maximum number of the Lucene Jira issue, that will be known by then (how? based on the un-tgz'd GitHub import data? or maybe you/we will communicate this number to them? if so, let's say that above?)
Review Comment:
Here I thought we should explicitly state that we will tell them the max id?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@lucene.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@lucene.apache.org
For additional commands, e-mail: issues-help@lucene.apache.org