You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@myfaces.apache.org by Mike Kienenberger <mk...@gmail.com> on 2006/04/11 22:04:18 UTC
RE: default AutoScroll setting depends on Tomahawk
On 4/11/06, Mario Ivankovits (JIRA) <de...@myfaces.apache.org> wrote:
> We need to update the documentation.
> I dont know when this changed and who it was, but the ExtensionsFilter is
> required to add the javascript required by myfaces e.g. to handle the
> scrolling stuff.
Mario.
The problem isn't that Tomahawk is needed to make autoscrolling work.
The problem is that MyFaces without tomahawk doesn't work if it's enabled.
If autoscrolling is part of Tomahawk (the location could be argued
either way in my opinion) rather than part of impl, then the
autoscroll setting in the web.xml file should be ignored if tomahawk
isn't installed.
Instead, the autoscroll setting is being checked, and the impl assumes
that Tomahawk is going to be in place to handle the javascript being
generated.
Unfortunately, in all of the MyFaces example web.xml files, this value
is set true by default, causing MyFaces to unexpectly break when used
without Tomahawk.
It's affecting a large number of users in a way that is
incredibily-difficult to diagnose.
Re: default AutoScroll setting depends on Tomahawk
Posted by Mario Ivankovits <ma...@ops.co.at>.
Hi Sean!
>> No - its in shared.
>> And no - I cant add it to the branch as there are already additions for
>> tomahawk in the same class.
>>
>
> Are we talking about r393309? If so this looks pretty
> self-contained. Its not immediately obvious to me why this revision
> can't be added to the branch and then merged down. Unless these
> methods have been renamed or something.
>
Its a method added called for the "checkExtensionsFilter" stuff. Even if
it might not disturb, this configuration is useless in the branch and
thus the tomahawk check cant be merged down (you'll get conflicts)
Its packported now.
Could someone please test it.
Ciao,
Mario
Re: default AutoScroll setting depends on Tomahawk
Posted by Sean Schofield <se...@gmail.com>.
> No - its in shared.
> And no - I cant add it to the branch as there are already additions for
> tomahawk in the same class.
Are we talking about r393309? If so this looks pretty
self-contained. Its not immediately obvious to me why this revision
can't be added to the branch and then merged down. Unless these
methods have been renamed or something.
> You know, I asked some days ago what to do with these tomahawk additions.
>
> What I can do is to add it to the branch too, but then you cant merge it
> down.
Please add whatever you need to get it to work to the branch. We'll
deal with merging down after the release.
> Sean, are you reachable throug gmail or skype? Maybe icq if I manage to
> rebuild my kopete.
gtalk. I accepted your invitation but we should generally keep these
kinds of discussions on the list so all can participate. Plus I'm
only available for small chunks of time these days.
> Ciao,
> Mario
Sean
Re: default AutoScroll setting depends on Tomahawk
Posted by Mario Ivankovits <ma...@ops.co.at>.
Hi Sean!
>> I think Sean is going to make a new branch tonight so you won't have
>> to worry about it if you get it in before then.
>>
>
> Is this a core change? If so it should go on the *existing* branch
> (and not the trunk.) If its on the trunk please back it out so I can
> merge down from the branch when the TCK tests are over.
>
No - its in shared.
And no - I cant add it to the branch as there are already additions for
tomahawk in the same class.
You know, I asked some days ago what to do with these tomahawk additions.
What I can do is to add it to the branch too, but then you cant merge it
down.
Sean, are you reachable throug gmail or skype? Maybe icq if I manage to
rebuild my kopete.
Ciao,
Mario
Re: default AutoScroll setting depends on Tomahawk
Posted by Sean Schofield <se...@gmail.com>.
> I think Sean is going to make a new branch tonight so you won't have
> to worry about it if you get it in before then.
Is this a core change? If so it should go on the *existing* branch
(and not the trunk.) If its on the trunk please back it out so I can
merge down from the branch when the TCK tests are over.
Sean
Re: default AutoScroll setting depends on Tomahawk
Posted by Mario Ivankovits <ma...@ops.co.at>.
Hi!
>> It looks like this solution works with myfaces head, have to take a look
>> how to get it into the branch too.
>>
>
> I think Sean is going to make a new branch tonight so you won't have
> to worry about it if you get it in before then.
>
Ok, so its committed now. I hope I havent overlooked something, I just
checked with our samples (and a locally castrated sample1.jsp)
Autoscrolling, DetectJavascript, AddResourceClass and
CheckExtensionsFilter are disabled now if tomahawk-.jar is missing.
Ciao,
Mario
Re: default AutoScroll setting depends on Tomahawk
Posted by Mike Kienenberger <mk...@gmail.com>.
On 4/11/06, Mario Ivankovits <ma...@ops.co.at> wrote:
> It looks like this solution works with myfaces head, have to take a look
> how to get it into the branch too.
I think Sean is going to make a new branch tonight so you won't have
to worry about it if you get it in before then.
Re: default AutoScroll setting depends on Tomahawk
Posted by Mario Ivankovits <ma...@ops.co.at>.
Hi!
> On 4/11/06, Mario Ivankovits <ma...@ops.co.at> wrote:
>
>> Ok, so I'll check if the ExtensionsFilter is available (its part of
>> tomahawk) - and if not, this feature is disabled (and a warning logged).
>>
>> If this is sufficient, I'll give that a try.
>>
>
> If we're planning on keeping autoscrolling in tomhawk (and that seems
> to be the current idea), then that sounds like a good solution.
>
Anything else and Sean will jump out of the window ;-)
It looks like this solution works with myfaces head, have to take a look
how to get it into the branch too.
Are you reachable throug gtalk?
Ciao,
Mario
Re: default AutoScroll setting depends on Tomahawk
Posted by Mike Kienenberger <mk...@gmail.com>.
On 4/11/06, Mario Ivankovits <ma...@ops.co.at> wrote:
> Ok, so I'll check if the ExtensionsFilter is available (its part of
> tomahawk) - and if not, this feature is disabled (and a warning logged).
>
> If this is sufficient, I'll give that a try.
If we're planning on keeping autoscrolling in tomhawk (and that seems
to be the current idea), then that sounds like a good solution.
Thanks!
Re: default AutoScroll setting depends on Tomahawk
Posted by Mario Ivankovits <ma...@ops.co.at>.
Mike Kienenberger schrieb:
> On 4/11/06, Mario Ivankovits (JIRA) <de...@myfaces.apache.org> wrote:
>
>> We need to update the documentation.
>> I dont know when this changed and who it was, but the ExtensionsFilter is
>> required to add the javascript required by myfaces e.g. to handle the
>> scrolling stuff.
>>
>
> Mario.
>
> The problem isn't that Tomahawk is needed to make autoscrolling work.
> The problem is that MyFaces without tomahawk doesn't work if it's enabled.
>
Ok, so I'll check if the ExtensionsFilter is available (its part of
tomahawk) - and if not, this feature is disabled (and a warning logged).
If this is sufficient, I'll give that a try.
Ciao,
Mario