You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@ratis.apache.org by "Tsz Wo Nicholas Sze (JIRA)" <ji...@apache.org> on 2017/03/30 03:01:41 UTC
[jira] [Commented] (RATIS-52) Refactor RaftUtils into different
classes
[ https://issues.apache.org/jira/browse/RATIS-52?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15948327#comment-15948327 ]
Tsz Wo Nicholas Sze commented on RATIS-52:
------------------------------------------
Thanks Enis, I also want to do something similar. Just haven't got a chance. I only have two minor comments
- Let's rename Iterables to CollectionUtils so that we may add other Collection related utility methods there.
- Let's use interface instead of class so that all the fields are automatic public static final and all the methods are automatic public.
> Refactor RaftUtils into different classes
> -----------------------------------------
>
> Key: RATIS-52
> URL: https://issues.apache.org/jira/browse/RATIS-52
> Project: Ratis
> Issue Type: Improvement
> Reporter: Enis Soztutar
> Assignee: Enis Soztutar
> Attachments: ratis-52_v1.patch
>
>
> Ideally we should not have a generic {{RaftUtils}} class. The code should be broken up into at least:
> {code}
> ReflectionUtils -> All reflection, construction, initialization logic
> IOUtils -> Add buffer and IO logic
> SystemUtils or PlatformUtils -> OS type detection, etc
> Preconditions (or something like that) -> assertTrue, etc
> {code}
--
This message was sent by Atlassian JIRA
(v6.3.15#6346)