You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@jmeter.apache.org by bu...@apache.org on 2018/11/05 15:16:57 UTC
[Bug 62887] New: SampleLabel displays incorrectly in Jmeter 5.0
https://bz.apache.org/bugzilla/show_bug.cgi?id=62887
Bug ID: 62887
Summary: SampleLabel displays incorrectly in Jmeter 5.0
Product: JMeter
Version: 5.0
Hardware: PC
OS: Linux
Status: NEW
Severity: minor
Priority: P2
Component: Main
Assignee: issues@jmeter.apache.org
Reporter: alansq16@hotmail.com
Target Milestone: JMETER_5.1
After upgrading my project's pom.xml to the Jmeter 5.0 JARs, I noticed that the
SampleResult's label no longer displays with my custom messages.
See labels with Jmeter 4.0's JARs: https://imgur.com/a/JD6pB2m
After upgrading to Jmeter 5.0 JARs: https://imgur.com/PsJdbHo
I'm setting my labels with the SetSampleLabel method:
https://jmeter.apache.org/api/org/apache/jmeter/samplers/SampleResult.html#setSampleLabel-java.lang.String-.
--
You are receiving this mail because:
You are the assignee for the bug.
[Bug 62887] Customized SampleLabel is ignored and overwritten by
JMeter 5.0
Posted by bu...@apache.org.
https://bz.apache.org/bugzilla/show_bug.cgi?id=62887
--- Comment #17 from Philippe Mouawad <p....@ubik-ingenierie.com> ---
(In reply to Alan Silva from comment #16)
> (In reply to Philippe Mouawad from comment #10)
> > (In reply to Alan Silva from comment #9)
> > > Oh yes. You're absolutely right @Philippe Mouawad.
> > >
> > > The patch should haven been an if/else. My mistake.
> > >
> > > In any case, as I said in my previous comment:
> > >
> > > Calling addSubResult(SampleResult subResult, false) is good enough I think.
> > >
> > > That's what I ended up doing and I would presume that it's what other Jmeter
> > > users that upgraded to 5.0 and use custom result labels did as well.
> >
> > Hello Alan,
> > Thanks for your feedback.
> >
> > So In your opinion, is it ok to do nothing ? or should we do something.
> >
> > Of course we should add a note on this in release notes.
> >
> > Thanks
>
> Hi, sorry I stopped monitoring this ticket for a bit.
>
> IMO, you could leave the current implementation as is, as long as it's
> mentioned in the rel notes like you suggested.
>
> As long as other users like myself don't have to open up the code to find
> out why things changed, then I think everything is good.
>
> Cheers
Thanks Alan for your feedback.
@Artem, thanks a lot for your work on this and PR.
But, IMO, we shouldn't do anything about it except add to release notes of 5.0
the Incompatible changes section.
--
You are receiving this mail because:
You are the assignee for the bug.
[Bug 62887] SampleLabel displays incorrectly in Jmeter 5.0
Posted by bu...@apache.org.
https://bz.apache.org/bugzilla/show_bug.cgi?id=62887
--- Comment #5 from Alan Silva <al...@hotmail.com> ---
Hi,
So while running the unit tests, I noticed that the HTTPSamplerBase (and other
samplers perhaps), use a pattern of:
public SampleResult sample() {
SampleResult res = null;
try {
res = sample(getUrl(), getMethod(), false, 0);
if (res != null) {
res.setSampleLabel(getName());
}
return res;
} catch (Exception e) {
return errorResult(e, new HTTPSampleResult());
}
}
Meaning, the sampler's name gets inserted to the SampleResult before returning.
So I can't really check for subResult.getSampleLabel().isEmpty() since it will
most likely won't be.
Also, I noticed that the subResult currently just uses it's parent Result's
label.
So I tried applying the attached patch which just checks if the subResult has
the same label as its parent result object.
If it does, I let the rename happen.
Otherwise, I assume that the subResult's label was modified for a reason and
shouldn't be touched.
Unfortunately, it seems to be breaking some of the unit tests but at this
point, I honestly don't know if it be worthwhile to fix all of them for a
cosmetic change.
I already changed our internal code to not automatically assume the subResult
will have the same label as the parent with the existing
addSubResult(subResult, false) method and will probably leave it at that.
Feel free to close this ticket if you wish.
@Philippe Mouawad
Simply make two SampleResult objects X and Y and try to add Y as a subResult of
X with X.addResult(Y)
You'll see that Y will always have the same name as X even if you call
Y.setSampleLabel("foo") or something.
--
You are receiving this mail because:
You are the assignee for the bug.
[Bug 62887] Customized SampleLabel is ignored and overwritten by
JMeter 5.0
Posted by bu...@apache.org.
https://bz.apache.org/bugzilla/show_bug.cgi?id=62887
--- Comment #12 from Felix Schumacher <fe...@internetallee.de> ---
(In reply to Artem Fedorov from comment #11)
> Hi
> I added a PR https://github.com/apache/jmeter/pull/429
> Also I use compareTo() instead of equals() for string comparison.
> Performance comparison of these functions I got from
> http://jniosocket.sourceforge.net/result.html
Have you tried to reproduce those performance experiments? They were done with
java 1.4.2 which is reallly old. Sadly the source code used for those
experiments is not available anymore (at least not from the site directly).
--
You are receiving this mail because:
You are the assignee for the bug.
[Bug 62887] Customized SampleLabel is ignored and overwritten by
JMeter 5.0
Posted by bu...@apache.org.
https://bz.apache.org/bugzilla/show_bug.cgi?id=62887
--- Comment #8 from Philippe Mouawad <p....@ubik-ingenierie.com> ---
(In reply to Artem Fedorov from comment #7)
> Hi all,
>
> I agree with attached fix, but it can throw NPE, because it skip check for
> null
>
>
> if(subResult == null) {
> // see https://bz.apache.org/bugzilla/show_bug.cgi?id=54778
> return;
> }
>
> The other suggestion is add jmeter.property for enable/disable subResults
> rename option.
Hello Artem,
1/ IMO, having a property that can break report is a bit weird no ? And it's
another option for a requirement that is a edgy.
2/ Regarding the patch , I don't understand why addSubResult is called twice.
Am I missing something ? Should the second addSubResults be in an else ?
Same issue for other methods unless I am wrong.
3/ Also wouldn't this patch have an impact on JMeter performances by adding a
String comparison for every Sub result addition .
Thanks
--
You are receiving this mail because:
You are the assignee for the bug.
[Bug 62887] Customized SampleLabel is ignored and overwritten by
JMeter 5.0
Posted by bu...@apache.org.
https://bz.apache.org/bugzilla/show_bug.cgi?id=62887
--- Comment #13 from Artem Fedorov <ar...@blazemeter.com> ---
(In reply to Felix Schumacher from comment #12)
> (In reply to Artem Fedorov from comment #11)
> > Hi
> > I added a PR https://github.com/apache/jmeter/pull/429
> > Also I use compareTo() instead of equals() for string comparison.
> > Performance comparison of these functions I got from
> > http://jniosocket.sourceforge.net/result.html
>
> Have you tried to reproduce those performance experiments? They were done
> with java 1.4.2 which is reallly old. Sadly the source code used for those
> experiments is not available anymore (at least not from the site directly).
Sure, this code and experiment is very old and not actual for current Java
version. The String implementation was changed (I found 1.4 jdk and decompile
code).
I can try to make benchmark test and attach some results late
--
You are receiving this mail because:
You are the assignee for the bug.
[Bug 62887] Customized SampleLabel is ignored and overwritten by
JMeter 5.0
Posted by bu...@apache.org.
https://bz.apache.org/bugzilla/show_bug.cgi?id=62887
Philippe Mouawad <p....@ubik-ingenierie.com> changed:
What |Removed |Added
----------------------------------------------------------------------------
Status|NEEDINFO |RESOLVED
Resolution|--- |WONTFIX
Keywords| |FixedInTrunk
--- Comment #18 from Philippe Mouawad <p....@ubik-ingenierie.com> ---
pmouawad@apache.org
8:45 AM (1 minute ago)
to commits
Author: pmouawad
Date: Tue Dec 4 07:45:20 2018
New Revision: 1848126
URL: http://svn.apache.org/viewvc?rev=1848126&view=rev
Log:
Bug 62887 - Customized SampleLabel is ignored and overwritten by JMeter 5.0
Document incompatible changes of JMeter 5.0
Bugzilla Id: 62887
Modified:
jmeter/trunk/xdocs/changes_history.xml
--
You are receiving this mail because:
You are the assignee for the bug.
[Bug 62887] SampleLabel displays incorrectly in Jmeter 5.0
Posted by bu...@apache.org.
https://bz.apache.org/bugzilla/show_bug.cgi?id=62887
Alan Silva <al...@hotmail.com> changed:
What |Removed |Added
----------------------------------------------------------------------------
Status|NEEDINFO |NEW
--- Comment #2 from Alan Silva <al...@hotmail.com> ---
Sure thing.
I'm using a Parameterized Controller
(https://jmeter-plugins.org/wiki/ParameterizedController/) to call a custom HLS
sampler (an Apple media streaming protocol).
I've found the change to be in
src/core/org/apache/jmeter/samplers/SampleResult.java in the:
public void addSubResult(SampleResult subResult) {
addSubResult(subResult, true);
}
which in turns calls
public void addSubResult(SampleResult subResult, boolean renameSubResults)
to clobber my custom result label names.
I honestly find this design choice pretty strange because:
1 - It breaks labels for users upgrading from Jmeter 4.0 to Jmeter 5.0 and the
change is not explicitly documented in the Jmeter 5.0 release notes
(https://jmeter.apache.org/changes.html)
2 - Clobbering a user's SampleResult labels by default is ill-advised.
I would propose simply doing the following:
public void addSubResult(SampleResult subResult) {
addSubResult(subResult, subResult.getSampleLabel().isEmpty());
}
1 - If the user's label is empty, cool, use the new renameSubResults feature.
2 - If it's not, respect the given label to the SampleResult object.
I wouldn't even make
addSubResult(SampleResult subResult, boolean renameSubResults)
a public method. It should only be called privately due to the lack of a
SampleLabel by a user.
The scenario in which a user goes through the effort of naming their
SampleResult label and then calling addSubResult(subResult, true) makes no
sense to me. The logical thing to do if they if don't care about their label
anymore would be simply to remove their call to subResult.setSampleLabel().
What are your thoughts on this?
Cheers.
--
You are receiving this mail because:
You are the assignee for the bug.
[Bug 62887] SampleLabel displays incorrectly in Jmeter 5.0
Posted by bu...@apache.org.
https://bz.apache.org/bugzilla/show_bug.cgi?id=62887
Philippe Mouawad <p....@ubik-ingenierie.com> changed:
What |Removed |Added
----------------------------------------------------------------------------
Status|NEW |NEEDINFO
--- Comment #3 from Philippe Mouawad <p....@ubik-ingenierie.com> ---
(In reply to Alan Silva from comment #2)
> Sure thing.
>
> I'm using a Parameterized Controller
> (https://jmeter-plugins.org/wiki/ParameterizedController/) to call a custom
> HLS sampler (an Apple media streaming protocol).
>
>
> I've found the change to be in
> src/core/org/apache/jmeter/samplers/SampleResult.java in the:
>
> public void addSubResult(SampleResult subResult) {
> addSubResult(subResult, true);
> }
>
> which in turns calls
>
> public void addSubResult(SampleResult subResult, boolean renameSubResults)
>
> to clobber my custom result label names.
>
> I honestly find this design choice pretty strange because:
> 1 - It breaks labels for users upgrading from Jmeter 4.0 to Jmeter 5.0 and
> the change is not explicitly documented in the Jmeter 5.0 release notes
> (https://jmeter.apache.org/changes.html)
Yes it should have been documented.
> 2 - Clobbering a user's SampleResult labels by default is ill-advised.
Still, modifying labels is a bit of an edgy case.
>
> I would propose simply doing the following:
>
> public void addSubResult(SampleResult subResult) {
> addSubResult(subResult, subResult.getSampleLabel().isEmpty());
> }
>
> 1 - If the user's label is empty, cool, use the new renameSubResults feature.
> 2 - If it's not, respect the given label to the SampleResult object.
>
> I wouldn't even make
>
> addSubResult(SampleResult subResult, boolean renameSubResults)
>
> a public method. It should only be called privately due to the lack of a
> SampleLabel by a user.
>
Can you fork our repository on github, apply your patch and run test as per:
http://jmeter.apache.org/building.html
This way you'll see if your approach works and if it doesn't break things.
>
> The scenario in which a user goes through the effort of naming their
> SampleResult label and then calling addSubResult(subResult, true) makes no
> sense to me. The logical thing to do if they if don't care about their label
> anymore would be simply to remove their call to subResult.setSampleLabel().
>
> What are your thoughts on this?
I'll be able to look at this issue in more details only in few days.
So for now no answer on my side yet.
> Cheers.
--
You are receiving this mail because:
You are the assignee for the bug.
[Bug 62887] Customized SampleLabel is ignored and overwritten by
JMeter 5.0
Posted by bu...@apache.org.
https://bz.apache.org/bugzilla/show_bug.cgi?id=62887
--- Comment #9 from Alan Silva <al...@hotmail.com> ---
Oh yes. You're absolutely right @Philippe Mouawad.
The patch should haven been an if/else. My mistake.
In any case, as I said in my previous comment:
Calling addSubResult(SampleResult subResult, false) is good enough I think.
That's what I ended up doing and I would presume that it's what other Jmeter
users that upgraded to 5.0 and use custom result labels did as well.
--
You are receiving this mail because:
You are the assignee for the bug.
[Bug 62887] Customized SampleLabel is ignored and overwritten by
JMeter 5.0
Posted by bu...@apache.org.
https://bz.apache.org/bugzilla/show_bug.cgi?id=62887
Philippe Mouawad <p....@ubik-ingenierie.com> changed:
What |Removed |Added
----------------------------------------------------------------------------
Resolution|WONTFIX |DUPLICATE
--- Comment #19 from Philippe Mouawad <p....@ubik-ingenierie.com> ---
*** This bug has been marked as a duplicate of bug 63055 ***
--
You are receiving this mail because:
You are the assignee for the bug.
[Bug 62887] Customized SampleLabel is ignored and overwritten by
JMeter 5.0
Posted by bu...@apache.org.
https://bz.apache.org/bugzilla/show_bug.cgi?id=62887
--- Comment #15 from Artem Fedorov <ar...@blazemeter.com> ---
Benchmark results:
# Run complete. Total time: 00:37:59
Benchmark (index) Mode Cnt Score Error Units
StringBenchmark.compareToBenchmark 0 thrpt 20 0.823 ± 0.013 ops/ns
StringBenchmark.compareToBenchmark 1 thrpt 20 0.829 ± 0.007 ops/ns
StringBenchmark.compareToBenchmark 2 thrpt 20 0.822 ± 0.012 ops/ns
StringBenchmark.compareToBenchmark 3 thrpt 20 0.822 ± 0.017 ops/ns
StringBenchmark.compareToBenchmark 4 thrpt 20 0.817 ± 0.012 ops/ns
StringBenchmark.compareToBenchmark 5 thrpt 20 0.829 ± 0.003 ops/ns
StringBenchmark.compareToBenchmark 6 thrpt 20 0.828 ± 0.009 ops/ns
StringBenchmark.equalsBenchmark 0 thrpt 20 0.829 ± 0.002 ops/ns
StringBenchmark.equalsBenchmark 1 thrpt 20 0.745 ± 0.006 ops/ns
StringBenchmark.equalsBenchmark 2 thrpt 20 0.745 ± 0.006 ops/ns
StringBenchmark.equalsBenchmark 3 thrpt 20 0.818 ± 0.013 ops/ns
StringBenchmark.equalsBenchmark 4 thrpt 20 0.738 ± 0.013 ops/ns
StringBenchmark.equalsBenchmark 5 thrpt 20 0.744 ± 0.008 ops/ns
StringBenchmark.equalsBenchmark 6 thrpt 20 0.828 ± 0.003 ops/ns
StringBenchmark.compareToBenchmark 0 avgt 20 1.208 ± 0.009 ns/op
StringBenchmark.compareToBenchmark 1 avgt 20 1.218 ± 0.017 ns/op
StringBenchmark.compareToBenchmark 2 avgt 20 1.236 ± 0.021 ns/op
StringBenchmark.compareToBenchmark 3 avgt 20 1.203 ± 0.005 ns/op
StringBenchmark.compareToBenchmark 4 avgt 20 1.211 ± 0.011 ns/op
StringBenchmark.compareToBenchmark 5 avgt 20 1.234 ± 0.029 ns/op
StringBenchmark.compareToBenchmark 6 avgt 20 1.208 ± 0.012 ns/op
StringBenchmark.equalsBenchmark 0 avgt 20 1.203 ± 0.003 ns/op
StringBenchmark.equalsBenchmark 1 avgt 20 1.353 ± 0.024 ns/op
StringBenchmark.equalsBenchmark 2 avgt 20 1.342 ± 0.008 ns/op
StringBenchmark.equalsBenchmark 3 avgt 20 1.209 ± 0.003 ns/op
StringBenchmark.equalsBenchmark 4 avgt 20 1.341 ± 0.015 ns/op
StringBenchmark.equalsBenchmark 5 avgt 20 1.351 ± 0.019 ns/op
StringBenchmark.equalsBenchmark 6 avgt 20 1.209 ± 0.014 ns/op
# Run complete. Total time: 00:37:54
Benchmark (index) Mode Cnt Score Error Units
StringBenchmark.compareToBenchmark 0 thrpt 20 0.802 ± 0.028 ops/ns
StringBenchmark.compareToBenchmark 1 thrpt 20 0.807 ± 0.032 ops/ns
StringBenchmark.compareToBenchmark 2 thrpt 20 0.802 ± 0.022 ops/ns
StringBenchmark.compareToBenchmark 3 thrpt 20 0.794 ± 0.043 ops/ns
StringBenchmark.compareToBenchmark 4 thrpt 20 0.808 ± 0.019 ops/ns
StringBenchmark.compareToBenchmark 5 thrpt 20 0.826 ± 0.007 ops/ns
StringBenchmark.compareToBenchmark 6 thrpt 20 0.807 ± 0.011 ops/ns
StringBenchmark.equalsBenchmark 0 thrpt 20 0.822 ± 0.011 ops/ns
StringBenchmark.equalsBenchmark 1 thrpt 20 0.743 ± 0.007 ops/ns
StringBenchmark.equalsBenchmark 2 thrpt 20 0.722 ± 0.026 ops/ns
StringBenchmark.equalsBenchmark 3 thrpt 20 0.815 ± 0.016 ops/ns
StringBenchmark.equalsBenchmark 4 thrpt 20 0.736 ± 0.019 ops/ns
StringBenchmark.equalsBenchmark 5 thrpt 20 0.719 ± 0.023 ops/ns
StringBenchmark.equalsBenchmark 6 thrpt 20 0.815 ± 0.017 ops/ns
StringBenchmark.compareToBenchmark 0 avgt 20 1.221 ± 0.013 ns/op
StringBenchmark.compareToBenchmark 1 avgt 20 1.258 ± 0.058 ns/op
StringBenchmark.compareToBenchmark 2 avgt 20 1.250 ± 0.044 ns/op
StringBenchmark.compareToBenchmark 3 avgt 20 1.254 ± 0.061 ns/op
StringBenchmark.compareToBenchmark 4 avgt 20 1.229 ± 0.022 ns/op
StringBenchmark.compareToBenchmark 5 avgt 20 1.216 ± 0.016 ns/op
StringBenchmark.compareToBenchmark 6 avgt 20 1.273 ± 0.075 ns/op
StringBenchmark.equalsBenchmark 0 avgt 20 1.244 ± 0.049 ns/op
StringBenchmark.equalsBenchmark 1 avgt 20 1.376 ± 0.045 ns/op
StringBenchmark.equalsBenchmark 2 avgt 20 1.377 ± 0.040 ns/op
StringBenchmark.equalsBenchmark 3 avgt 20 1.220 ± 0.032 ns/op
StringBenchmark.equalsBenchmark 4 avgt 20 1.348 ± 0.010 ns/op
StringBenchmark.equalsBenchmark 5 avgt 20 1.375 ± 0.041 ns/op
StringBenchmark.equalsBenchmark 6 avgt 20 1.232 ± 0.040 ns/op
So 'equals()' looks a little bit slower than 'compareTo()', but the difference
between them is not bigger than ~10%
--
You are receiving this mail because:
You are the assignee for the bug.
[Bug 62887] Customized SampleLabel is ignored and overwritten by
JMeter 5.0
Posted by bu...@apache.org.
https://bz.apache.org/bugzilla/show_bug.cgi?id=62887
--- Comment #11 from Artem Fedorov <ar...@blazemeter.com> ---
Hi
I added a PR https://github.com/apache/jmeter/pull/429
Also I use compareTo() instead of equals() for string comparison. Performance
comparison of these functions I got from
http://jniosocket.sourceforge.net/result.html
--
You are receiving this mail because:
You are the assignee for the bug.
[Bug 62887] Customized SampleLabel is ignored and overwritten by
JMeter 5.0
Posted by bu...@apache.org.
https://bz.apache.org/bugzilla/show_bug.cgi?id=62887
--- Comment #16 from Alan Silva <al...@hotmail.com> ---
(In reply to Philippe Mouawad from comment #10)
> (In reply to Alan Silva from comment #9)
> > Oh yes. You're absolutely right @Philippe Mouawad.
> >
> > The patch should haven been an if/else. My mistake.
> >
> > In any case, as I said in my previous comment:
> >
> > Calling addSubResult(SampleResult subResult, false) is good enough I think.
> >
> > That's what I ended up doing and I would presume that it's what other Jmeter
> > users that upgraded to 5.0 and use custom result labels did as well.
>
> Hello Alan,
> Thanks for your feedback.
>
> So In your opinion, is it ok to do nothing ? or should we do something.
>
> Of course we should add a note on this in release notes.
>
> Thanks
Hi, sorry I stopped monitoring this ticket for a bit.
IMO, you could leave the current implementation as is, as long as it's
mentioned in the rel notes like you suggested.
As long as other users like myself don't have to open up the code to find out
why things changed, then I think everything is good.
Cheers
--
You are receiving this mail because:
You are the assignee for the bug.
[Bug 62887] SampleLabel displays incorrectly in Jmeter 5.0
Posted by bu...@apache.org.
https://bz.apache.org/bugzilla/show_bug.cgi?id=62887
--- Comment #6 from Alan Silva <al...@hotmail.com> ---
Created attachment 36247
--> https://bz.apache.org/bugzilla/attachment.cgi?id=36247&action=edit
Patch for fix
--
You are receiving this mail because:
You are the assignee for the bug.
[Bug 62887] SampleLabel displays incorrectly in Jmeter 5.0
Posted by bu...@apache.org.
https://bz.apache.org/bugzilla/show_bug.cgi?id=62887
Philippe Mouawad <p....@ubik-ingenierie.com> changed:
What |Removed |Added
----------------------------------------------------------------------------
Status|NEW |NEEDINFO
CC| |p.mouawad@ubik-ingenierie.c
| |om
--- Comment #1 from Philippe Mouawad <p....@ubik-ingenierie.com> ---
Hello,
This is intentional and related to Bug 62550.
Could you describe the usage your making of it and the type of Parent used ? Is
it a Transaction Controller ?
Thanks
--
You are receiving this mail because:
You are the assignee for the bug.
[Bug 62887] Customized SampleLabel is ignored and overwritten by
JMeter 5.0
Posted by bu...@apache.org.
https://bz.apache.org/bugzilla/show_bug.cgi?id=62887
Philippe Mouawad <p....@ubik-ingenierie.com> changed:
What |Removed |Added
----------------------------------------------------------------------------
OS|Linux |All
Summary|SampleLabel displays |Customized SampleLabel is
|incorrectly in Jmeter 5.0 |ignored and overwritten by
| |JMeter 5.0
Hardware|PC |All
--
You are receiving this mail because:
You are the assignee for the bug.
[Bug 62887] Customized SampleLabel is ignored and overwritten by
JMeter 5.0
Posted by bu...@apache.org.
https://bz.apache.org/bugzilla/show_bug.cgi?id=62887
--- Comment #10 from Philippe Mouawad <p....@ubik-ingenierie.com> ---
(In reply to Alan Silva from comment #9)
> Oh yes. You're absolutely right @Philippe Mouawad.
>
> The patch should haven been an if/else. My mistake.
>
> In any case, as I said in my previous comment:
>
> Calling addSubResult(SampleResult subResult, false) is good enough I think.
>
> That's what I ended up doing and I would presume that it's what other Jmeter
> users that upgraded to 5.0 and use custom result labels did as well.
Hello Alan,
Thanks for your feedback.
So In your opinion, is it ok to do nothing ? or should we do something.
Of course we should add a note on this in release notes.
Thanks
--
You are receiving this mail because:
You are the assignee for the bug.
[Bug 62887] Customized SampleLabel is ignored and overwritten by
JMeter 5.0
Posted by bu...@apache.org.
https://bz.apache.org/bugzilla/show_bug.cgi?id=62887
--- Comment #14 from Artem Fedorov <ar...@blazemeter.com> ---
Created attachment 36260
--> https://bz.apache.org/bugzilla/attachment.cgi?id=36260&action=edit
Benchmark test class
I created a benchmark test for equals and compareTo methods.
Dependencies:
<dependency>
<groupId>org.openjdk.jmh</groupId>
<artifactId>jmh-core</artifactId>
<version>1.19</version>
</dependency>
<dependency>
<groupId>org.openjdk.jmh</groupId>
<artifactId>jmh-generator-annprocess</artifactId>
<version>1.19</version>
</dependency>
--
You are receiving this mail because:
You are the assignee for the bug.
[Bug 62887] Customized SampleLabel is ignored and overwritten by
JMeter 5.0
Posted by bu...@apache.org.
https://bz.apache.org/bugzilla/show_bug.cgi?id=62887
--- Comment #7 from Artem Fedorov <ar...@blazemeter.com> ---
Hi all,
I agree with attached fix, but it can throw NPE, because it skip check for null
if(subResult == null) {
// see https://bz.apache.org/bugzilla/show_bug.cgi?id=54778
return;
}
The other suggestion is add jmeter.property for enable/disable subResults
rename option.
--
You are receiving this mail because:
You are the assignee for the bug.
[Bug 62887] SampleLabel displays incorrectly in Jmeter 5.0
Posted by bu...@apache.org.
https://bz.apache.org/bugzilla/show_bug.cgi?id=62887
--- Comment #4 from Philippe Mouawad <p....@ubik-ingenierie.com> ---
Also, can you please share a simple reproducer of what you're doing ?
Because if I test with a JSR223 PostProcessor modifying setSampleLabel , the
modified label are respected.
Thank you
--
You are receiving this mail because:
You are the assignee for the bug.