You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@wicket.apache.org by "Martin Grigorov (Resolved) (JIRA)" <ji...@apache.org> on 2012/02/23 16:52:49 UTC

[jira] [Resolved] (WICKET-4026) Consider moving registration of IMarkupFilter implementations to I***Settings

     [ https://issues.apache.org/jira/browse/WICKET-4026?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Martin Grigorov resolved WICKET-4026.
-------------------------------------

       Resolution: Won't Fix
    Fix Version/s:     (was: 6.0.0)

IComponentResolver is not directly related to IMarkupFilter. In your case it is but usually it is not.
IMarkupFilter is more advanced feature that is more or less coupled with the current MarkupParser implementation. Additionally there are some undocumented rules which should be followed when creating your own IMarkupFilter. For now it will be as it is.
                
> Consider moving registration of IMarkupFilter implementations to I***Settings
> -----------------------------------------------------------------------------
>
>                 Key: WICKET-4026
>                 URL: https://issues.apache.org/jira/browse/WICKET-4026
>             Project: Wicket
>          Issue Type: Improvement
>          Components: wicket
>    Affects Versions: 1.5-RC7
>            Reporter: Bruno Borges
>            Priority: Minor
>              Labels: tags, wicket
>         Attachments: myproject.zip
>
>
> Adding a custom tag handler to PageSettings is not enough to have Wicket understanding a new tag.
> 		getPageSettings().addComponentResolver(new WicketVarResolver());
> 		getPageSettings().addComponentResolver(new WicketVarTagHandler());
> The MarkupFactory object must be replaced with a custom one that adds the tag handler object to the MarkupParser
> public class VariablesSupportMarkupFactory extends MarkupFactory {
> 	public MarkupParser newMarkupParser(final MarkupResourceStream resource) {
> 		MarkupParser mp = super.newMarkupParser(resource);
> 		mp.add(new WicketVarTagHandler());
> 		return mp;
> 	}
> }

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira