You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@guacamole.apache.org by mike-jumper <gi...@git.apache.org> on 2017/01/05 14:31:54 UTC

[GitHub] incubator-guacamole-client pull request #101: GUACAMOLE-36: Add support for ...

GitHub user mike-jumper opened a pull request:

    https://github.com/apache/incubator-guacamole-client/pull/101

    GUACAMOLE-36: Add support for password aging

    This change adds support for password policies driven by password age, allowing passwords to automatically expire and preventing passwords from being changed too frequently, if desired.

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/mike-jumper/incubator-guacamole-client password-aging

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/incubator-guacamole-client/pull/101.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #101
    
----
commit a207411241a6a4bbdab80f4f8aba4da6b89be845
Author: Michael Jumper <mj...@apache.org>
Date:   2016-08-22T19:01:58Z

    GUACAMOLE-36: Add password reset date to schema.

commit 5f6fb8a1994206a85bd71b57b877fa24c630b7c3
Author: Michael Jumper <mj...@apache.org>
Date:   2016-08-20T00:35:12Z

    GUACAMOLE-36: Implement password aging checks.

commit 80b80655cf734e6bf13901654e58ae4ccdf7346b
Author: Michael Jumper <mj...@apache.org>
Date:   2016-08-22T21:56:39Z

    GUACAMOLE-36: Automatically update password date. Store previous date for comparison.

----


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] incubator-guacamole-client pull request #101: GUACAMOLE-36: Add support for ...

Posted by mike-jumper <gi...@git.apache.org>.
Github user mike-jumper commented on a diff in the pull request:

    https://github.com/apache/incubator-guacamole-client/pull/101#discussion_r94819001
  
    --- Diff: extensions/guacamole-auth-jdbc/modules/guacamole-auth-jdbc-base/src/main/java/org/apache/guacamole/auth/jdbc/security/PasswordPolicy.java ---
    @@ -43,6 +43,36 @@
         int getMinimumLength() throws GuacamoleException;
     
         /**
    +     * Returns the minimum number of days which must elapse before the user's
    +     * password may be reset. If this restriction does not apply, this will be
    +     * zero.
    +     *
    +     * @return
    +     *     The minimum number of days which must elapse before the user's
    +     *     password must be reset, or zero if this restriction does not apply.
    --- End diff --
    
    Oops. Yes.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] incubator-guacamole-client pull request #101: GUACAMOLE-36: Add support for ...

Posted by asfgit <gi...@git.apache.org>.
Github user asfgit closed the pull request at:

    https://github.com/apache/incubator-guacamole-client/pull/101


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] incubator-guacamole-client pull request #101: GUACAMOLE-36: Add support for ...

Posted by jmuehlner <gi...@git.apache.org>.
Github user jmuehlner commented on a diff in the pull request:

    https://github.com/apache/incubator-guacamole-client/pull/101#discussion_r94816705
  
    --- Diff: extensions/guacamole-auth-jdbc/modules/guacamole-auth-jdbc-base/src/main/java/org/apache/guacamole/auth/jdbc/security/PasswordPolicy.java ---
    @@ -43,6 +43,36 @@
         int getMinimumLength() throws GuacamoleException;
     
         /**
    +     * Returns the minimum number of days which must elapse before the user's
    +     * password may be reset. If this restriction does not apply, this will be
    +     * zero.
    +     *
    +     * @return
    +     *     The minimum number of days which must elapse before the user's
    +     *     password must be reset, or zero if this restriction does not apply.
    --- End diff --
    
    Did you mean "may be reset" here?


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---