You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@dolphinscheduler.apache.org by GitBox <gi...@apache.org> on 2021/01/20 18:57:14 UTC
[GitHub] [incubator-dolphinscheduler] codecov-io commented on pull request #4513: [Improvement][service] Refactor service module to fix code smell
codecov-io commented on pull request #4513:
URL: https://github.com/apache/incubator-dolphinscheduler/pull/4513#issuecomment-763861445
# [Codecov](https://codecov.io/gh/apache/incubator-dolphinscheduler/pull/4513?src=pr&el=h1) Report
> Merging [#4513](https://codecov.io/gh/apache/incubator-dolphinscheduler/pull/4513?src=pr&el=desc) (235d28a) into [dev](https://codecov.io/gh/apache/incubator-dolphinscheduler/commit/679f2b89e7161a76340b554fe48d03590514d381?el=desc) (679f2b8) will **increase** coverage by `0.26%`.
> The diff coverage is `22.64%`.
[](https://codecov.io/gh/apache/incubator-dolphinscheduler/pull/4513?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## dev #4513 +/- ##
============================================
+ Coverage 43.48% 43.74% +0.26%
- Complexity 3204 3216 +12
============================================
Files 471 476 +5
Lines 21812 21771 -41
Branches 2646 2637 -9
============================================
+ Hits 9484 9523 +39
+ Misses 11421 11342 -79
+ Partials 907 906 -1
```
| [Impacted Files](https://codecov.io/gh/apache/incubator-dolphinscheduler/pull/4513?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
|---|---|---|---|
| [...che/dolphinscheduler/common/utils/StringUtils.java](https://codecov.io/gh/apache/incubator-dolphinscheduler/pull/4513/diff?src=pr&el=tree#diff-ZG9scGhpbnNjaGVkdWxlci1jb21tb24vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2RvbHBoaW5zY2hlZHVsZXIvY29tbW9uL3V0aWxzL1N0cmluZ1V0aWxzLmphdmE=) | `73.33% <ø> (-1.67%)` | `15.00 <0.00> (+2.00)` | :arrow_down: |
| [...lphinscheduler/dao/entity/ProcessAlertContent.java](https://codecov.io/gh/apache/incubator-dolphinscheduler/pull/4513/diff?src=pr&el=tree#diff-ZG9scGhpbnNjaGVkdWxlci1kYW8vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2RvbHBoaW5zY2hlZHVsZXIvZGFvL2VudGl0eS9Qcm9jZXNzQWxlcnRDb250ZW50LmphdmE=) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (ø)` | |
| [...heduler/server/master/runner/MasterExecThread.java](https://codecov.io/gh/apache/incubator-dolphinscheduler/pull/4513/diff?src=pr&el=tree#diff-ZG9scGhpbnNjaGVkdWxlci1zZXJ2ZXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2RvbHBoaW5zY2hlZHVsZXIvc2VydmVyL21hc3Rlci9ydW5uZXIvTWFzdGVyRXhlY1RocmVhZC5qYXZh) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (ø)` | |
| [...he/dolphinscheduler/server/utils/AlertManager.java](https://codecov.io/gh/apache/incubator-dolphinscheduler/pull/4513/diff?src=pr&el=tree#diff-ZG9scGhpbnNjaGVkdWxlci1zZXJ2ZXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2RvbHBoaW5zY2hlZHVsZXIvc2VydmVyL3V0aWxzL0FsZXJ0TWFuYWdlci5qYXZh) | `0.86% <0.00%> (-0.05%)` | `1.00 <0.00> (ø)` | |
| [...heduler/service/bean/SpringApplicationContext.java](https://codecov.io/gh/apache/incubator-dolphinscheduler/pull/4513/diff?src=pr&el=tree#diff-ZG9scGhpbnNjaGVkdWxlci1zZXJ2aWNlL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9kb2xwaGluc2NoZWR1bGVyL3NlcnZpY2UvYmVhbi9TcHJpbmdBcHBsaWNhdGlvbkNvbnRleHQuamF2YQ==) | `0.00% <ø> (ø)` | `0.00 <0.00> (ø)` | |
| [...ce/exceptions/CuratorZookeeperClientException.java](https://codecov.io/gh/apache/incubator-dolphinscheduler/pull/4513/diff?src=pr&el=tree#diff-ZG9scGhpbnNjaGVkdWxlci1zZXJ2aWNlL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9kb2xwaGluc2NoZWR1bGVyL3NlcnZpY2UvZXhjZXB0aW9ucy9DdXJhdG9yWm9va2VlcGVyQ2xpZW50RXhjZXB0aW9uLmphdmE=) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
| [...eduler/service/exceptions/PermissionException.java](https://codecov.io/gh/apache/incubator-dolphinscheduler/pull/4513/diff?src=pr&el=tree#diff-ZG9scGhpbnNjaGVkdWxlci1zZXJ2aWNlL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9kb2xwaGluc2NoZWR1bGVyL3NlcnZpY2UvZXhjZXB0aW9ucy9QZXJtaXNzaW9uRXhjZXB0aW9uLmphdmE=) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
| [...r/service/exceptions/QuartzExecutorsException.java](https://codecov.io/gh/apache/incubator-dolphinscheduler/pull/4513/diff?src=pr&el=tree#diff-ZG9scGhpbnNjaGVkdWxlci1zZXJ2aWNlL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9kb2xwaGluc2NoZWR1bGVyL3NlcnZpY2UvZXhjZXB0aW9ucy9RdWFydHpFeGVjdXRvcnNFeGNlcHRpb24uamF2YQ==) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
| [...nscheduler/service/permission/PermissionCheck.java](https://codecov.io/gh/apache/incubator-dolphinscheduler/pull/4513/diff?src=pr&el=tree#diff-ZG9scGhpbnNjaGVkdWxlci1zZXJ2aWNlL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9kb2xwaGluc2NoZWR1bGVyL3NlcnZpY2UvcGVybWlzc2lvbi9QZXJtaXNzaW9uQ2hlY2suamF2YQ==) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (ø)` | |
| [...inscheduler/service/quartz/ProcessScheduleJob.java](https://codecov.io/gh/apache/incubator-dolphinscheduler/pull/4513/diff?src=pr&el=tree#diff-ZG9scGhpbnNjaGVkdWxlci1zZXJ2aWNlL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9kb2xwaGluc2NoZWR1bGVyL3NlcnZpY2UvcXVhcnR6L1Byb2Nlc3NTY2hlZHVsZUpvYi5qYXZh) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (ø)` | |
| ... and [43 more](https://codecov.io/gh/apache/incubator-dolphinscheduler/pull/4513/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-dolphinscheduler/pull/4513?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/incubator-dolphinscheduler/pull/4513?src=pr&el=footer). Last update [fb5501f...235d28a](https://codecov.io/gh/apache/incubator-dolphinscheduler/pull/4513?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org