You are viewing a plain text version of this content. The canonical link for it is here.

Posted to issues@nifi.apache.org by nickcarenza <gi...@git.apache.org> on 2017/02/02 18:52:15 UTC

[GitHub] nifi pull request #1468: NIFI-3430 adds support for date format property to ...

GitHub user nickcarenza opened a pull request:

    https://github.com/apache/nifi/pull/1468

    NIFI-3430 adds support for date format property to parse incoming date strings

    Thank you for submitting a contribution to Apache NiFi.
    
    In order to streamline the review of the contribution we ask you
    to ensure the following steps have been taken:
    
    ### For all changes:
    - [ ] Is there a JIRA ticket associated with this PR? Is it referenced 
         in the commit message?
    
    - [ ] Does your PR title start with NIFI-XXXX where XXXX is the JIRA number you are trying to resolve? Pay particular attention to the hyphen "-" character.
    
    - [ ] Has your PR been rebased against the latest commit within the target branch (typically master)?
    
    - [ ] Is your initial contribution a single, squashed commit?
    
    ### For code changes:
    - [ ] Have you ensured that the full suite of tests is executed via mvn -Pcontrib-check clean install at the root nifi folder?
    - [ ] Have you written or updated unit tests to verify your changes?
    - [ ] If adding new dependencies to the code, are these dependencies licensed in a way that is compatible for inclusion under [ASF 2.0](http://www.apache.org/legal/resolved.html#category-a)? 
    - [ ] If applicable, have you updated the LICENSE file, including the main LICENSE file under nifi-assembly?
    - [ ] If applicable, have you updated the NOTICE file, including the main NOTICE file found under nifi-assembly?
    - [ ] If adding new Properties, have you added .displayName in addition to .name (programmatic access) for each of the new properties?
    
    ### For documentation related changes:
    - [ ] Have you ensured that format looks appropriate for the output in which it is rendered?
    
    ### Note:
    Please ensure that once the PR is submitted, you check travis-ci for build issues and submit an update to your PR as soon as possible.


You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/nickcarenza/nifi NIFI-3430

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/nifi/pull/1468.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #1468
    
----
commit 16fdb3b5753f5393ebe0d902269de5b1cf82fd03
Author: Nick Carenza <ni...@thecontrolgroup.com>
Date:   2017-02-02T01:41:45Z

    adds date_format property to parse incoming date strings

commit 65178852a81413a926bc7bc3d1f664c33de9fcfb
Author: Nick Carenza <ni...@thecontrolgroup.com>
Date:   2017-02-02T18:49:50Z

    refactored to use the existing valueFormat and java.time.format.DateTimeFormatter

----


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] nifi issue #1468: NIFI-3430 adds support for date format property to parse i...

Posted by nickcarenza <gi...@git.apache.org>.

Github user nickcarenza commented on the issue:

    https://github.com/apache/nifi/pull/1468
  
    @trixpan squashed and added details about the change in the processor description.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] nifi issue #1468: NIFI-3430 adds support for date format property to parse i...

Posted by trixpan <gi...@git.apache.org>.

Github user trixpan commented on the issue:

    https://github.com/apache/nifi/pull/1468
  
    Nick, thank you for the contribution. would you mind squashing the commits?


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] nifi issue #1468: NIFI-3430 adds support for date format property to parse i...

Posted by pvillard31 <gi...@git.apache.org>.

Github user pvillard31 commented on the issue:

    https://github.com/apache/nifi/pull/1468
  
    LGTM, I'll take care of merging @trixpan ;)
    Thanks @nickcarenza 


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] nifi pull request #1468: NIFI-3430 adds support for date format property to ...

Posted by asfgit <gi...@git.apache.org>.

Github user asfgit closed the pull request at:

    https://github.com/apache/nifi/pull/1468


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---