You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@spark.apache.org by GitBox <gi...@apache.org> on 2019/04/02 08:04:15 UTC

[GitHub] [spark] dongjoon-hyun commented on issue #24195: [SPARK-25496][SQL] Deprecate from_utc_timestamp and to_utc_timestamp

dongjoon-hyun commented on issue #24195: [SPARK-25496][SQL] Deprecate from_utc_timestamp and to_utc_timestamp
URL: https://github.com/apache/spark/pull/24195#issuecomment-478889103
 
 
   Hi, guys.
   
   The last Jenkins result looks stale because it was executed 4 days ago. This commit causes UT failures on `master` branches and PR builders.
   - https://amplab.cs.berkeley.edu/jenkins/view/Spark%20QA%20Test%20(Dashboard)/job/spark-master-test-maven-hadoop-2.7/6197/
   - https://amplab.cs.berkeley.edu/jenkins/view/Spark%20QA%20Test%20(Dashboard)/job/spark-master-test-maven-hadoop-2.7-jdk-11-ubuntu-testing/583/
   - https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/104179/testReport/ (https://github.com/apache/spark/pull/24253)
   
   I also verified this locally. When I run the test, it also fails. It succeeds in case of reverting this. 
   ```scala
   ~/A/spark:master$ build/sbt "sql/testOnly *.StreamingAggregationSuite"
   ...
   [info] - prune results by current_date, complete mode - state format version 1 *** FAILED *** (675 milliseconds)
   [info]   == Results ==
   [info]   !== Correct Answer - 3 ==   == Spark Answer - 2 ==
   [info]   !struct<_1:bigint,_2:int>   struct<CAST((CAST(value AS BIGINT) / 86400) AS BIGINT):bigint,count(1):bigint>
   [info]   ![0,1]                      [10,1]
   [info]   ![10,1]                     [5,2]
   [info]   ![5,2]
   ...
   [info] *** 2 TESTS FAILED ***
   [error] Failed: Total 33, Failed 2, Errors 0, Passed 31
   [error] Failed tests:
   [error] 	org.apache.spark.sql.streaming.StreamingAggregationSuite
   [error] (sql/test:testOnly) sbt.TestsFailedException: Tests unsuccessful
   [error] Total time: 60 s, completed Apr 2, 2019 12:48:26 AM
   ```
   
   I'll revert this to unblock the other PRs.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org