[GitHub] [curator] tisonkun commented on a diff in pull request #454: CURATOR-666: Fix twice unfixForNamespace in background create

["tisonkun (via GitHub)" <gi...@apache.org>]

tisonkun commented on code in PR #454:
URL: https://github.com/apache/curator/pull/454#discussion_r1156234143


##########
curator-framework/src/main/java/org/apache/curator/framework/imps/CreateBuilderImpl.java:
##########
@@ -900,8 +900,6 @@ private void sendBackgroundResponse(int rc, String path, Object ctx, String name
 
     private static CuratorEvent makeCuratorEvent(CuratorFrameworkImpl client, int rc, String path, Object ctx, String name, Stat stat)
     {

Review Comment:
   Let's inline this method since it's now only a delegate.



##########
curator-framework/src/main/java/org/apache/curator/framework/imps/CreateBuilderImpl.java:
##########
@@ -797,7 +797,7 @@ public void performBackgroundOperation(OperationAndData<T> dummy) throws Excepti
                 {
                     if ( !client.getZookeeperClient().getRetryPolicy().allowRetry(e) )
                     {
-                        final CuratorEvent event = makeCuratorEvent(client, e.code().intValue(), e.getPath(), null, e.getPath(), null);

Review Comment:
   I'm fine with this change.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@curator.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org