You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@wicket.apache.org by astrapi69 <gi...@git.apache.org> on 2015/09/24 11:45:23 UTC
[GitHub] wicket pull request: Changed return type of
GitHub user astrapi69 opened a pull request:
https://github.com/apache/wicket/pull/137
Changed return type of
Program to Interface, not Implementation
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/astrapi69/wicket patch-3
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/wicket/pull/137.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #137
----
commit 597bf5960a980d13ef316cc3c3030625f4888edb
Author: astrapi69 <as...@gmx.net>
Date: 2015-09-24T09:45:11Z
Changed return type of
Program to Interface, not Implementation
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] wicket pull request: Changed return type of
Posted by astrapi69 <gi...@git.apache.org>.
Github user astrapi69 commented on the pull request:
https://github.com/apache/wicket/pull/137#issuecomment-142894282
Ok than for release 8.x :-)
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] wicket pull request: Changed return type of
Posted by martin-g <gi...@git.apache.org>.
Github user martin-g commented on the pull request:
https://github.com/apache/wicket/pull/137#issuecomment-142891991
I'm afraid this change could not be applied.
It is an API break and we could not merge it in 7.x branch (currently master).
The methods are `static` so they are not overrideable, so I think there is no big issue here.
Thanks for the PR anyway!
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] wicket pull request: Changed return type of
Posted by astrapi69 <gi...@git.apache.org>.
Github user astrapi69 closed the pull request at:
https://github.com/apache/wicket/pull/137
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---