You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@hive.apache.org by Vihang Karajgaonkar <vi...@cloudera.com> on 2016/12/22 21:11:01 UTC

Review Request 54997: HIVE-14956 : Parallelize TestHCatLoader

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/54997/
-----------------------------------------------------------

Review request for hive and Aihua Xu.


Bugs: HIVE-14956
    https://issues.apache.org/jira/browse/HIVE-14956


Repository: hive-git


Description
-------

HIVE-14956 : Parallelize TestHCatLoader


Diffs
-----

  hcatalog/hcatalog-pig-adapter/src/test/java/org/apache/hive/hcatalog/pig/AbstractHCatLoaderTest.java PRE-CREATION 
  hcatalog/hcatalog-pig-adapter/src/test/java/org/apache/hive/hcatalog/pig/TestAvroHCatLoader.java PRE-CREATION 
  hcatalog/hcatalog-pig-adapter/src/test/java/org/apache/hive/hcatalog/pig/TestHCatLoader.java 71b09b0568defe2c02a3aa1ffc32a36a95690b8b 
  hcatalog/hcatalog-pig-adapter/src/test/java/org/apache/hive/hcatalog/pig/TestOrcHCatLoader.java PRE-CREATION 
  hcatalog/hcatalog-pig-adapter/src/test/java/org/apache/hive/hcatalog/pig/TestParquetHCatLoader.java PRE-CREATION 
  hcatalog/hcatalog-pig-adapter/src/test/java/org/apache/hive/hcatalog/pig/TestRCFileHCatLoader.java PRE-CREATION 
  hcatalog/hcatalog-pig-adapter/src/test/java/org/apache/hive/hcatalog/pig/TestSequenceFileHCatLoader.java PRE-CREATION 
  hcatalog/hcatalog-pig-adapter/src/test/java/org/apache/hive/hcatalog/pig/TestTextFileHCatLoader.java PRE-CREATION 

Diff: https://reviews.apache.org/r/54997/diff/


Testing
-------


Thanks,

Vihang Karajgaonkar

Re: Review Request 54997: HIVE-14956 : Parallelize TestHCatLoader

Posted by Vihang Karajgaonkar <vi...@cloudera.com>.

> On Dec. 22, 2016, 9:27 p.m., Aihua Xu wrote:
> > hcatalog/hcatalog-pig-adapter/src/test/java/org/apache/hive/hcatalog/pig/AbstractHCatLoaderTest.java, line 5
> > <https://reviews.apache.org/r/54997/diff/1/?file=1591307#file1591307line5>
> >
> >     This is very clean. The only question is: seems TestHCatLoader.java is not needed any more since we are not testing anything there. If there is a new format, we can add a subclass to test it. Can we remove TestHCatLoader.java?
> >     
> >     Otherwise, everything looks good.

I agree. I will remove it and post it again.


- Vihang


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/54997/#review160014
-----------------------------------------------------------


On Dec. 22, 2016, 9:11 p.m., Vihang Karajgaonkar wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/54997/
> -----------------------------------------------------------
> 
> (Updated Dec. 22, 2016, 9:11 p.m.)
> 
> 
> Review request for hive and Aihua Xu.
> 
> 
> Bugs: HIVE-14956
>     https://issues.apache.org/jira/browse/HIVE-14956
> 
> 
> Repository: hive-git
> 
> 
> Description
> -------
> 
> HIVE-14956 : Parallelize TestHCatLoader
> 
> 
> Diffs
> -----
> 
>   hcatalog/hcatalog-pig-adapter/src/test/java/org/apache/hive/hcatalog/pig/AbstractHCatLoaderTest.java PRE-CREATION 
>   hcatalog/hcatalog-pig-adapter/src/test/java/org/apache/hive/hcatalog/pig/TestAvroHCatLoader.java PRE-CREATION 
>   hcatalog/hcatalog-pig-adapter/src/test/java/org/apache/hive/hcatalog/pig/TestHCatLoader.java 71b09b0568defe2c02a3aa1ffc32a36a95690b8b 
>   hcatalog/hcatalog-pig-adapter/src/test/java/org/apache/hive/hcatalog/pig/TestOrcHCatLoader.java PRE-CREATION 
>   hcatalog/hcatalog-pig-adapter/src/test/java/org/apache/hive/hcatalog/pig/TestParquetHCatLoader.java PRE-CREATION 
>   hcatalog/hcatalog-pig-adapter/src/test/java/org/apache/hive/hcatalog/pig/TestRCFileHCatLoader.java PRE-CREATION 
>   hcatalog/hcatalog-pig-adapter/src/test/java/org/apache/hive/hcatalog/pig/TestSequenceFileHCatLoader.java PRE-CREATION 
>   hcatalog/hcatalog-pig-adapter/src/test/java/org/apache/hive/hcatalog/pig/TestTextFileHCatLoader.java PRE-CREATION 
> 
> Diff: https://reviews.apache.org/r/54997/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Vihang Karajgaonkar
> 
>

Re: Review Request 54997: HIVE-14956 : Parallelize TestHCatLoader

Posted by Aihua Xu <ax...@cloudera.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/54997/#review160014
-----------------------------------------------------------




hcatalog/hcatalog-pig-adapter/src/test/java/org/apache/hive/hcatalog/pig/AbstractHCatLoaderTest.java (line 5)
<https://reviews.apache.org/r/54997/#comment231019>

    This is very clean. The only question is: seems TestHCatLoader.java is not needed any more since we are not testing anything there. If there is a new format, we can add a subclass to test it. Can we remove TestHCatLoader.java?
    
    Otherwise, everything looks good.


- Aihua Xu


On Dec. 22, 2016, 9:11 p.m., Vihang Karajgaonkar wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/54997/
> -----------------------------------------------------------
> 
> (Updated Dec. 22, 2016, 9:11 p.m.)
> 
> 
> Review request for hive and Aihua Xu.
> 
> 
> Bugs: HIVE-14956
>     https://issues.apache.org/jira/browse/HIVE-14956
> 
> 
> Repository: hive-git
> 
> 
> Description
> -------
> 
> HIVE-14956 : Parallelize TestHCatLoader
> 
> 
> Diffs
> -----
> 
>   hcatalog/hcatalog-pig-adapter/src/test/java/org/apache/hive/hcatalog/pig/AbstractHCatLoaderTest.java PRE-CREATION 
>   hcatalog/hcatalog-pig-adapter/src/test/java/org/apache/hive/hcatalog/pig/TestAvroHCatLoader.java PRE-CREATION 
>   hcatalog/hcatalog-pig-adapter/src/test/java/org/apache/hive/hcatalog/pig/TestHCatLoader.java 71b09b0568defe2c02a3aa1ffc32a36a95690b8b 
>   hcatalog/hcatalog-pig-adapter/src/test/java/org/apache/hive/hcatalog/pig/TestOrcHCatLoader.java PRE-CREATION 
>   hcatalog/hcatalog-pig-adapter/src/test/java/org/apache/hive/hcatalog/pig/TestParquetHCatLoader.java PRE-CREATION 
>   hcatalog/hcatalog-pig-adapter/src/test/java/org/apache/hive/hcatalog/pig/TestRCFileHCatLoader.java PRE-CREATION 
>   hcatalog/hcatalog-pig-adapter/src/test/java/org/apache/hive/hcatalog/pig/TestSequenceFileHCatLoader.java PRE-CREATION 
>   hcatalog/hcatalog-pig-adapter/src/test/java/org/apache/hive/hcatalog/pig/TestTextFileHCatLoader.java PRE-CREATION 
> 
> Diff: https://reviews.apache.org/r/54997/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Vihang Karajgaonkar
> 
>

Re: Review Request 54997: HIVE-14956 : Parallelize TestHCatLoader

Posted by Vihang Karajgaonkar <vi...@cloudera.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/54997/
-----------------------------------------------------------

(Updated Dec. 22, 2016, 10:02 p.m.)


Review request for hive, Aihua Xu and Vaibhav Gumashta.


Changes
-------

Removed TestHCatLoader as per Aihua's suggestion.


Bugs: HIVE-14956
    https://issues.apache.org/jira/browse/HIVE-14956


Repository: hive-git


Description
-------

HIVE-14956 : Parallelize TestHCatLoader


Diffs (updated)
-----

  hcatalog/hcatalog-pig-adapter/src/test/java/org/apache/hive/hcatalog/pig/AbstractHCatStorerTest.java 2975287afda37a9b6026b4f8716f16309d6841b7 
  hcatalog/hcatalog-pig-adapter/src/test/java/org/apache/hive/hcatalog/pig/TestAvroHCatLoader.java PRE-CREATION 
  hcatalog/hcatalog-pig-adapter/src/test/java/org/apache/hive/hcatalog/pig/TestE2EScenarios.java 4c970fa2db836b60a80e6c8322b2190f0fb62aaa 
  hcatalog/hcatalog-pig-adapter/src/test/java/org/apache/hive/hcatalog/pig/TestHCatLoader.java 71b09b0568defe2c02a3aa1ffc32a36a95690b8b 
  hcatalog/hcatalog-pig-adapter/src/test/java/org/apache/hive/hcatalog/pig/TestHCatLoaderEncryption.java 7b069c78d4b450a54c16942070becf6e0c4dbb7b 
  hcatalog/hcatalog-pig-adapter/src/test/java/org/apache/hive/hcatalog/pig/TestHCatLoaderStorer.java dfde522c5a224bd0f472e29333a3e0e5b557bb42 
  hcatalog/hcatalog-pig-adapter/src/test/java/org/apache/hive/hcatalog/pig/TestOrcHCatLoader.java PRE-CREATION 
  hcatalog/hcatalog-pig-adapter/src/test/java/org/apache/hive/hcatalog/pig/TestParquetHCatLoader.java PRE-CREATION 
  hcatalog/hcatalog-pig-adapter/src/test/java/org/apache/hive/hcatalog/pig/TestRCFileHCatLoader.java PRE-CREATION 
  hcatalog/hcatalog-pig-adapter/src/test/java/org/apache/hive/hcatalog/pig/TestSequenceFileHCatLoader.java PRE-CREATION 
  hcatalog/hcatalog-pig-adapter/src/test/java/org/apache/hive/hcatalog/pig/TestTextFileHCatLoader.java PRE-CREATION 

Diff: https://reviews.apache.org/r/54997/diff/


Testing
-------


Thanks,

Vihang Karajgaonkar