You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@cloudstack.apache.org by GitBox <gi...@apache.org> on 2022/02/09 15:01:40 UTC
[GitHub] [cloudstack] sureshanaparti commented on a change in pull request #5911: Improve the guest OS hypervisor mappings addition on upgrade.
sureshanaparti commented on a change in pull request #5911:
URL: https://github.com/apache/cloudstack/pull/5911#discussion_r802756067
##########
File path: engine/schema/src/main/java/com/cloud/storage/GuestOSVO.java
##########
@@ -113,7 +113,7 @@ public Date getRemoved() {
}
@Override
- public boolean isUserDefined() {
+ public boolean getIsUserDefined() {
Review comment:
agree, but i think it works if field name is _userDefined_
https://github.com/apache/cloudstack/blob/41d25d54a79c21877b4c493261ab6a60251b9f34/framework/db/src/main/java/com/cloud/utils/db/SearchBase.java#L484-L486
https://github.com/apache/cloudstack/blob/41d25d54a79c21877b4c493261ab6a60251b9f34/framework/db/src/main/java/com/cloud/utils/db/SqlGenerator.java#L83-L84
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org