You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@tomcat.apache.org by bu...@apache.org on 2010/07/05 21:51:45 UTC

DO NOT REPLY [Bug 49554] New: Clean up Functions

https://issues.apache.org/bugzilla/show_bug.cgi?id=49554

           Summary: Clean up Functions
           Product: Taglibs
           Version: 1.2.0
          Platform: PC
            Status: NEW
          Severity: enhancement
          Priority: P2
         Component: Standard Taglib
        AssignedTo: dev@tomcat.apache.org
        ReportedBy: jboynes@apache.org


The implementation of Functions has checks for null parameters that are
redundant given coercion required by the Engine. As discussed on the mailing
list, these checks can be removed.

Functions should have JavaDoc.

Some function implementations, such as replace, are now available in the JRE
allowing this class to be simplified. Also usage of StringBuffer can be
replaced with StringBuilder avoiding unneeded synchronization.

-- 
Configure bugmail: https://issues.apache.org/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@tomcat.apache.org
For additional commands, e-mail: dev-help@tomcat.apache.org

DO NOT REPLY [Bug 49554] Clean up Functions

Posted by bu...@apache.org.
https://issues.apache.org/bugzilla/show_bug.cgi?id=49554

Henri Yandell <ba...@apache.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |RESOLVED
         Resolution|                            |FIXED
         OS/Version|                            |All

--- Comment #2 from Henri Yandell <ba...@apache.org> 2010-07-06 02:47:41 EDT ---
I was a bit concerned about substring's:

-        if (beginIndex >= input.length()) return "";

and substringAfter's:

-        if (substring.length() == 0) return input;


However you have unit tests for both and they pass before the Functions.java
change is applied and afterwards.

Committed as r960814.

-- 
Configure bugmail: https://issues.apache.org/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@tomcat.apache.org
For additional commands, e-mail: dev-help@tomcat.apache.org

DO NOT REPLY [Bug 49554] Clean up Functions

Posted by bu...@apache.org.
https://issues.apache.org/bugzilla/show_bug.cgi?id=49554

--- Comment #1 from Jeremy Boynes <jb...@apache.org> 2010-07-05 16:01:53 EDT ---
Created an attachment (id=25711)
 --> (https://issues.apache.org/bugzilla/attachment.cgi?id=25711)
Patch to clean up Functions

pom.xml also includes changes from attachment 25694 for SetSupport

-- 
Configure bugmail: https://issues.apache.org/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@tomcat.apache.org
For additional commands, e-mail: dev-help@tomcat.apache.org