You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@hive.apache.org by "Hive QA (JIRA)" <ji...@apache.org> on 2019/05/08 01:50:00 UTC
[jira] [Commented] (HIVE-21703) Break up DDLTask - extract
Partition related operations
[ https://issues.apache.org/jira/browse/HIVE-21703?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16835236#comment-16835236 ]
Hive QA commented on HIVE-21703:
--------------------------------
| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote || Subsystem || Runtime || Comment ||
|| || || || {color:brown} Prechecks {color} ||
| {color:green}+1{color} | {color:green} @author {color} | {color:green} 0m 0s{color} | {color:green} The patch does not contain any @author tags. {color} |
|| || || || {color:brown} master Compile Tests {color} ||
| {color:blue}0{color} | {color:blue} mvndep {color} | {color:blue} 1m 43s{color} | {color:blue} Maven dependency ordering for branch {color} |
| {color:green}+1{color} | {color:green} mvninstall {color} | {color:green} 7m 5s{color} | {color:green} master passed {color} |
| {color:green}+1{color} | {color:green} compile {color} | {color:green} 2m 46s{color} | {color:green} master passed {color} |
| {color:green}+1{color} | {color:green} checkstyle {color} | {color:green} 1m 42s{color} | {color:green} master passed {color} |
| {color:blue}0{color} | {color:blue} findbugs {color} | {color:blue} 4m 5s{color} | {color:blue} ql in master has 2253 extant Findbugs warnings. {color} |
| {color:blue}0{color} | {color:blue} findbugs {color} | {color:blue} 0m 38s{color} | {color:blue} hcatalog/core in master has 28 extant Findbugs warnings. {color} |
| {color:blue}0{color} | {color:blue} findbugs {color} | {color:blue} 0m 27s{color} | {color:blue} hcatalog/streaming in master has 11 extant Findbugs warnings. {color} |
| {color:blue}0{color} | {color:blue} findbugs {color} | {color:blue} 0m 26s{color} | {color:blue} streaming in master has 2 extant Findbugs warnings. {color} |
| {color:blue}0{color} | {color:blue} findbugs {color} | {color:blue} 0m 41s{color} | {color:blue} itests/hive-unit in master has 2 extant Findbugs warnings. {color} |
| {color:green}+1{color} | {color:green} javadoc {color} | {color:green} 2m 1s{color} | {color:green} master passed {color} |
|| || || || {color:brown} Patch Compile Tests {color} ||
| {color:blue}0{color} | {color:blue} mvndep {color} | {color:blue} 0m 25s{color} | {color:blue} Maven dependency ordering for patch {color} |
| {color:green}+1{color} | {color:green} mvninstall {color} | {color:green} 3m 11s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} compile {color} | {color:green} 2m 47s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} javac {color} | {color:green} 2m 47s{color} | {color:green} the patch passed {color} |
| {color:red}-1{color} | {color:red} checkstyle {color} | {color:red} 0m 45s{color} | {color:red} ql: The patch generated 19 new + 568 unchanged - 39 fixed = 587 total (was 607) {color} |
| {color:green}+1{color} | {color:green} whitespace {color} | {color:green} 0m 0s{color} | {color:green} The patch has no whitespace issues. {color} |
| {color:red}-1{color} | {color:red} findbugs {color} | {color:red} 4m 14s{color} | {color:red} ql generated 6 new + 2246 unchanged - 7 fixed = 2252 total (was 2253) {color} |
| {color:red}-1{color} | {color:red} findbugs {color} | {color:red} 0m 45s{color} | {color:red} hcatalog/core generated 1 new + 28 unchanged - 0 fixed = 29 total (was 28) {color} |
| {color:green}+1{color} | {color:green} javadoc {color} | {color:green} 1m 58s{color} | {color:green} the patch passed {color} |
|| || || || {color:brown} Other Tests {color} ||
| {color:green}+1{color} | {color:green} asflicense {color} | {color:green} 0m 14s{color} | {color:green} The patch does not generate ASF License warnings. {color} |
| {color:black}{color} | {color:black} {color} | {color:black} 40m 13s{color} | {color:black} {color} |
\\
\\
|| Reason || Tests ||
| FindBugs | module:ql |
| | Class org.apache.hadoop.hive.ql.ddl.table.partition.AlterTableAddPartitionDesc defines non-transient non-serializable instance field partitions In AlterTableAddPartitionDesc.java:instance field partitions In AlterTableAddPartitionDesc.java |
| | Class org.apache.hadoop.hive.ql.ddl.table.partition.AlterTableAddPartitionDesc defines non-transient non-serializable instance field replicationSpec In AlterTableAddPartitionDesc.java:instance field replicationSpec In AlterTableAddPartitionDesc.java |
| | Class org.apache.hadoop.hive.ql.ddl.table.partition.AlterTableDropPartitionDesc defines non-transient non-serializable instance field replicationSpec In AlterTableDropPartitionDesc.java:instance field replicationSpec In AlterTableDropPartitionDesc.java |
| | Class org.apache.hadoop.hive.ql.ddl.table.partition.AlterTableRenamePartitionDesc defines non-transient non-serializable instance field replicationSpec In AlterTableRenamePartitionDesc.java:instance field replicationSpec In AlterTableRenamePartitionDesc.java |
| | Exception is caught when Exception is not thrown in org.apache.hadoop.hive.ql.exec.repl.bootstrap.events.filesystem.FSTableEvent.partitionDesc(Path, ImportTableDesc, Partition) At FSTableEvent.java:is not thrown in org.apache.hadoop.hive.ql.exec.repl.bootstrap.events.filesystem.FSTableEvent.partitionDesc(Path, ImportTableDesc, Partition) At FSTableEvent.java:[line 210] |
| | Exception is caught when Exception is not thrown in org.apache.hadoop.hive.ql.metadata.Hive.createPartitions(AlterTableAddPartitionDesc) At Hive.java:is not thrown in org.apache.hadoop.hive.ql.metadata.Hive.createPartitions(AlterTableAddPartitionDesc) At Hive.java:[line 3079] |
| FindBugs | module:hcatalog/core |
| | Redundant nullcheck of ddlDesc, which is known to be non-null in org.apache.hive.hcatalog.cli.SemanticAnalysis.HCatSemanticAnalyzer.authorizeDDLWork2(HiveSemanticAnalyzerHookContext, Hive, DDLWork2) Redundant null check at HCatSemanticAnalyzer.java:is known to be non-null in org.apache.hive.hcatalog.cli.SemanticAnalysis.HCatSemanticAnalyzer.authorizeDDLWork2(HiveSemanticAnalyzerHookContext, Hive, DDLWork2) Redundant null check at HCatSemanticAnalyzer.java:[line 335] |
\\
\\
|| Subsystem || Report/Notes ||
| Optional Tests | asflicense javac javadoc findbugs checkstyle compile |
| uname | Linux hiveptest-server-upstream 3.16.0-4-amd64 #1 SMP Debian 3.16.43-2+deb8u5 (2017-09-19) x86_64 GNU/Linux |
| Build tool | maven |
| Personality | /data/hiveptest/working/yetus_PreCommit-HIVE-Build-17161/dev-support/hive-personality.sh |
| git revision | master / 47aa61e |
| Default Java | 1.8.0_111 |
| findbugs | v3.0.0 |
| checkstyle | http://104.198.109.242/logs//PreCommit-HIVE-Build-17161/yetus/diff-checkstyle-ql.txt |
| findbugs | http://104.198.109.242/logs//PreCommit-HIVE-Build-17161/yetus/new-findbugs-ql.html |
| findbugs | http://104.198.109.242/logs//PreCommit-HIVE-Build-17161/yetus/new-findbugs-hcatalog_core.html |
| modules | C: ql hcatalog/core hcatalog/streaming streaming itests/hive-unit U: . |
| Console output | http://104.198.109.242/logs//PreCommit-HIVE-Build-17161/yetus.txt |
| Powered by | Apache Yetus http://yetus.apache.org |
This message was automatically generated.
> Break up DDLTask - extract Partition related operations
> -------------------------------------------------------
>
> Key: HIVE-21703
> URL: https://issues.apache.org/jira/browse/HIVE-21703
> Project: Hive
> Issue Type: Sub-task
> Components: Hive
> Affects Versions: 3.1.1
> Reporter: Miklos Gergely
> Assignee: Miklos Gergely
> Priority: Major
> Labels: refactor-ddl
> Fix For: 4.0.0
>
> Attachments: HIVE-21703.01.patch
>
>
> DDLTask is a huge class, more than 5000 lines long. The related DDLWork is also a huge class, which has a field for each DDL operation it supports. The goal is to refactor these in order to have everything cut into more handleable classes under the package org.apache.hadoop.hive.ql.exec.ddl:
> * have a separate class for each operation
> * have a package for each operation group (database ddl, table ddl, etc), so the amount of classes under a package is more manageable
> * make all the requests (DDLDesc subclasses) immutable
> * DDLTask should be agnostic to the actual operations
> * right now let's ignore the issue of having some operations handled by DDLTask which are not actual DDL operations (lock, unlock, desc...)
> In the interim time when there are two DDLTask and DDLWork classes in the code base the new ones in the new package are called DDLTask2 and DDLWork2 thus avoiding the usage of fully qualified class names where both the old and the new classes are in use.
> Step #8: extract all the partition related operations from the old DDLTask, and move them under the new package.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)